From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 945C2C433F5 for ; Fri, 28 Jan 2022 16:50:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2175D6B00BA; Fri, 28 Jan 2022 11:50:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C5AF6B00BC; Fri, 28 Jan 2022 11:50:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08DFE6B00C2; Fri, 28 Jan 2022 11:50:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id F021E6B00BA for ; Fri, 28 Jan 2022 11:50:04 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BAE4093676 for ; Fri, 28 Jan 2022 16:50:04 +0000 (UTC) X-FDA: 79080283128.28.5EE1002 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf02.hostedemail.com (Postfix) with ESMTP id 488088001D for ; Fri, 28 Jan 2022 16:50:04 +0000 (UTC) Received: by mail-pf1-f178.google.com with SMTP id e6so6631918pfc.7 for ; Fri, 28 Jan 2022 08:50:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VRPDGMB2yv2UCcnyNA1XpQwhMox6PqjnnqptMofNKR4=; b=dTBBeXMyg1oj7klVQGzyS8Pb6J1TmwcLk3mELUpgI3UsMN24RFRMpWN7iqcbI5PgCu QaWS2lof3mq2x+BuWlTbiSuoLBwYliMitZgVWgsqUSUKLbHwEy58VR22Qql8zAy1/sTN fcKfk5DifS8VHL8ES5rU3AgTcM7E5PRbm3FcuT8ipKwXRhPyJmlDbg3C0WKX3BZApWjZ Ix3CHYZRfvLTz6Kgx2becCCoYgBHFGWFtAymrtZrSP/UzoSZWov0QCpBWBJoGTkJ0wLU Rd4MPgdKpJqnDTl7lX3lclbeoKs2GZQ26mU7ufprI0dbpXP/D6Jbwklc9dtxAJJVAk+7 xepA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VRPDGMB2yv2UCcnyNA1XpQwhMox6PqjnnqptMofNKR4=; b=VaTBZJBRgwGpmqRBUKHidsDi9VPK+EMMScMzdccHS3rCmMDRMSV6GjwHRsx/sypKM8 +g+uXISkANteTc83erCaJWnn0a0TaXrne1GvhSKxIrwtLjj2yDN2SjnAholHoRCNl2fl VFcxmiGjGWJ5SlUrHbyk2tVikFZMNtfKQVa+v4Al58ptw47SfLgKtkWMFta/16vPf5sJ bExra3UbXNdhUCy37ln9suwCCTFmVabDvkGqks/nlIIyK7LPV9T2beLMge/xh6moB61P 9RvFOWWC+MTAy1UWlBTtXR0JqEF5liryKoS0Zqb+lalYYQy4bkEawLr4/ZXghn7bK6gE /YsQ== X-Gm-Message-State: AOAM530pVJT3OvlL0vo1zn9T6FzeTWP8dvSoxzhg5yxRlyrOVzAWR1qP aWgyfsO0oh9tcIiJUgvmoEq4aN3fmtqYX8/COxg= X-Google-Smtp-Source: ABdhPJyd2+oGjlGWVy/GU2KOrUTbh+YI67jawNt4aUdIX5x7oXnyeY4+J0f34V8rjPfqxAUrhf0seNoo46SKLv/ePDU= X-Received: by 2002:a62:15c3:: with SMTP id 186mr8870670pfv.59.1643388602926; Fri, 28 Jan 2022 08:50:02 -0800 (PST) MIME-Version: 1.0 References: <20220128075346.GG8421@xsang-OptiPlex-9020> In-Reply-To: From: Alexei Starovoitov Date: Fri, 28 Jan 2022 08:49:51 -0800 Message-ID: Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail To: Sean Young Cc: kernel test robot , Alexei Starovoitov , Shuah Khan , LKML , Linux Memory Management List , lkp@lists.01.org, kbuild test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 488088001D X-Rspam-User: nil Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dTBBeXMy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com X-Stat-Signature: q87dz7mhhsga3gumc859ygrkbd9nucbs X-Rspamd-Server: rspam08 X-HE-Tag: 1643388604-619988 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 1:32 AM Sean Young wrote: > > On Fri, Jan 28, 2022 at 03:53:46PM +0800, kernel test robot wrote: > > > > > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: e2bcbd7769ee8f05e1b3d10848aace98973844e4 ("tools headers UAPI: = remove stale lirc.h") > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > > > in testcase: kernel-selftests > > version: kernel-selftests-x86_64-db530529-1_20220124 > > with following parameters: > > > > group: group-01 > > ucode: 0xe2 > > > > test-description: The kernel contains a set of "self tests" under the t= ools/testing/selftests/ directory. These are intended to be small unit test= s to exercise individual code paths in the kernel. > > test-url: https://www.kernel.org/doc/Documentation/kselftest.txt > > > > > > on test machine: 8 threads Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz with= 16G memory > > > > caused below changes (please refer to attached dmesg/kmsg for entire lo= g/backtrace): > > > > > > > > > > If you fix the issue, kindly add following tag > > Reported-by: kernel test robot > > > > > > > > 2022-01-27 18:57:29 make -C ir > > make: Entering directory '/usr/src/perf_selftests-x86_64-rhel-8.3-kself= tests-e2bcbd7769ee8f05e1b3d10848aace98973844e4/tools/testing/selftests/ir' > > gcc -Wall -O2 -I../../../include/uapi ir_loopback.c -o /usr/src/per= f_selftests-x86_64-rhel-8.3-kselftests-e2bcbd7769ee8f05e1b3d10848aace989738= 44e4/tools/testing/selftests/ir/ir_loopback > > ir_loopback.c: In function =E2=80=98main=E2=80=99: > > ir_loopback.c:147:20: error: =E2=80=98RC_PROTO_RCMM32=E2=80=99 undeclar= ed (first use in this function); did you mean =E2=80=98RC_PROTO_RC6_MCE=E2= =80=99? > > if (rc_proto =3D=3D RC_PROTO_RCMM32 && > > ^~~~~~~~~~~~~~~ > > RC_PROTO_RC6_MCE > > ir_loopback.c:147:20: note: each undeclared identifier is reported only= once for each function it appears in > > make: *** [../lib.mk:146: /usr/src/perf_selftests-x86_64-rhel-8.3-kself= tests-e2bcbd7769ee8f05e1b3d10848aace98973844e4/tools/testing/selftests/ir/i= r_loopback] Error 1 > > make: Leaving directory '/usr/src/perf_selftests-x86_64-rhel-8.3-kselft= ests-e2bcbd7769ee8f05e1b3d10848aace98973844e4/tools/testing/selftests/ir' > > 2022-01-27 18:57:29 make run_tests -C ir > > make: Entering directory '/usr/src/perf_selftests-x86_64-rhel-8.3-kself= tests-e2bcbd7769ee8f05e1b3d10848aace98973844e4/tools/testing/selftests/ir' > > gcc -Wall -O2 -I../../../include/uapi ir_loopback.c -o /usr/src/per= f_selftests-x86_64-rhel-8.3-kselftests-e2bcbd7769ee8f05e1b3d10848aace989738= 44e4/tools/testing/selftests/ir/ir_loopback > > ir_loopback.c: In function =E2=80=98main=E2=80=99: > > ir_loopback.c:147:20: error: =E2=80=98RC_PROTO_RCMM32=E2=80=99 undeclar= ed (first use in this function); did you mean =E2=80=98RC_PROTO_RC6_MCE=E2= =80=99? > > if (rc_proto =3D=3D RC_PROTO_RCMM32 && > > ^~~~~~~~~~~~~~~ > > RC_PROTO_RC6_MCE > > So this commit removes the copy of lirc.h from tools/include/uapi/linux/l= irc.h, > so now the test uses /usr/include/linux/lirc.h. It appears that this file > does not have RC_PROTO_RCMM32 defined on this system, which means it is a > kernel header from v5.1 or earlier (this was added in commit > 721074b03411327e7bf41555d4cc7c18f49313f7). > > It looks like this machine is redhat 8.3, which ships with kernel 4.18. > > I guess my change was far too optimistic; I had no ideal enterprise kerne= ls > were so ancient. > > We should probably drop e2bcbd7769ee8f05e1b3d10848aace98973844e4. Sorry a= bout > the turbulence. I'd rather avoid reverting. Just add ifdef or something to shut up the error on old distros. > > Sean > > > ir_loopback.c:147:20: note: each undeclared identifier is reported only= once for each function it appears in > > make: *** [../lib.mk:146: /usr/src/perf_selftests-x86_64-rhel-8.3-kself= tests-e2bcbd7769ee8f05e1b3d10848aace98973844e4/tools/testing/selftests/ir/i= r_loopback] Error 1 > > make: Leaving directory '/usr/src/perf_selftests-x86_64-rhel-8.3-kselft= ests-e2bcbd7769ee8f05e1b3d10848aace98973844e4/tools/testing/selftests/ir' Please trim your replies.