From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD74AC5475B for ; Sat, 9 Mar 2024 01:37:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0170C8D0016; Fri, 8 Mar 2024 20:37:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBAB58D0014; Fri, 8 Mar 2024 20:37:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D35488D0016; Fri, 8 Mar 2024 20:37:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B83A38D0014 for ; Fri, 8 Mar 2024 20:37:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8C1481213C1 for ; Sat, 9 Mar 2024 01:37:27 +0000 (UTC) X-FDA: 81875788134.29.35D11D1 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf08.hostedemail.com (Postfix) with ESMTP id DD3B416000F for ; Sat, 9 Mar 2024 01:37:25 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ilhf3Gb4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709948246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t9sJfx/dPoC4PHFHcz79QVELMCRzIgS/uV7VsG1ZiEU=; b=gMUS2iIIsnnPn33Ii4GyT8CUYMd0y0qIUy6oKy4U+BRuY7VmcTKTEyG9MpIobXNd0zXyku SOXI5LrgNu/Ngm7KaxY6nrdwxsXJfiKj9pU0lHIWEbu1Wgjulgs8DO77vWJPkLVRjgiDfD EculC3lVqGHDdbHsU+oyYvDkf77CFus= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ilhf3Gb4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709948246; a=rsa-sha256; cv=none; b=P7kOp543iv2Y9vWomsJctSstqf6N6S/k9nV8S2qt7C7wreBE4TAfYJRcC1L6i3UvKrNd0T 5c/5iCKK5QSDeGOkDu/3VCagoMWuPeLSXCMpXOeYltoLEAnES31RD8hjVU39D+Wdadtiw2 szE8yhRmDlM5Ewje119Ckb2O9KVZSjQ= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-41312c3ab40so10788875e9.3 for ; Fri, 08 Mar 2024 17:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709948244; x=1710553044; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t9sJfx/dPoC4PHFHcz79QVELMCRzIgS/uV7VsG1ZiEU=; b=Ilhf3Gb41zT9gWwGN+qSglic7sV+8UXgAP6jCgmkm3xvvi+Vr/WTe+wIEDQQVwgsng fHKms6zfqKv7ImP6sKv082/XsYUnwQk+pauGFHpEBHAZrl0lL7PeJcd0hoGXKHk4c8uk 5E9rNfGn1qC7qqPseHPxc17LUW4Ppu9Q1xxs8N+Kt+effUNUNPHnjboUUzyLSJVqBed0 WoLo774fCZTsNi0ors+Iu8zvkFdwjCUh3JQ0jiV4IvH48ZRUGetRPIn4JuIDMzU3ytk7 CboF6hAfu7c2/mbTiZaVEjUVZB4Uospz6SeL1zzRUmVnTGP3sIMbe7h5v0HJkV+eg028 PnkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709948244; x=1710553044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t9sJfx/dPoC4PHFHcz79QVELMCRzIgS/uV7VsG1ZiEU=; b=jaWqkUNmeGqEAGcn/fHKoW9syH1qpnJqy7/GU5pRKGIlr2LbTffXq1oNrbaIaHwmmr Z2D1HXsjTUf5q8oHexrgfygmjq2EWg728DChrFrXKnPJaqbD9bLgLSoyOGXb3o07Z9yZ 8hjU4HQ/LW3nmNpW3MJBeKi7lrRqq02OSoVsE/xttYyixWmjnzg/dZ4gx4nq221BAT6b zYd8o8uhfQmg/kWfKfzzh9uGrQ1nJsbfk60jW949wkkXnoNnkefUmy/6ZV5AP8R2Z5Pz TWmXDAN5InXqZTwNf/NGwaUb19aqxy5T9k86jf/iPcGGj1HNtvduu3cNPO3jlE5E8glK +n6Q== X-Forwarded-Encrypted: i=1; AJvYcCV9mewU2D4+sQPi3IL6RGTHDsm4c/rr5hkPiXXioPirJxbeY2DBkP52UsVmjPZQhnzIkEEM3szXH7IBv9lqfzMcFwY= X-Gm-Message-State: AOJu0YxczE66IQkAncPBwaN/59WHOknOl9WDUcV2e4xfO4JhjI13imst ixk6HcQeNcXkPEArCuO2dIFxKnRdH+oHDFNQZabqyh30zhFZ7IjYhFFiv42Wba2H2Yz//woklXo YN2cdq29T4hWIQgEx0AEs0IMzEfE= X-Google-Smtp-Source: AGHT+IG8nKUYYOjFdMCUDQrm7i9rcMegPic9EYSlh0DvVf0EaRVfqjGxM834FUWChCcqgKR7fVJIScN+mCzQErdyEKM= X-Received: by 2002:a05:600c:190c:b0:413:1139:3bec with SMTP id j12-20020a05600c190c00b0041311393becmr525736wmq.35.1709948244238; Fri, 08 Mar 2024 17:37:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexei Starovoitov Date: Fri, 8 Mar 2024 17:37:13 -0800 Message-ID: Subject: Re: vm_area at addr ffffffffc0800000 is not marked as VM_IOREMAP To: Christoph Hellwig Cc: Miguel Ojeda , Linus Torvalds , linux-mm , Andrew Morton , Catalin Marinas , Will Deacon , Linux ARM , Daniel Borkmann , bpf , Bjorn Helgaas , linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ijmcy8g97g79rekbscbzzgk9z54k7ooo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DD3B416000F X-HE-Tag: 1709948245-543469 X-HE-Meta: U2FsdGVkX1/xXGaUmMRUuQEoK0dLkleBEtq3wyVwS4KtoSXP32F99HiRWp7RpD7Q6YwaWEWIgWrL8Ne1LUx3bJiua282WpfCPS0fwtHJ2B1bU0ekb2EStU7hRlP4KAHwDQ4Nv0OzW6d+YgSptlXg1Pludg4V3yThRIb7zgcrgHd425aY5FNM0d5+NwX18X/8ErXt/WCOmaI/dIqhXAUzxAFBXu4ZF3IrC/6x9PaLCLakVTBFb/rwYSZ01GRLiBwy/au1I+Qe7J+2xxbVpEO+8rZQnItwclI1IrQ1AGN7u0gdsiof2uOcYBsvHanI5zsXcQZEgdDItXP85QduD862K51eyhslOdNWos5ooyumNTHdiv/LFlxIauGPO7Ng/Hx58FseAjnfLaPZbJgttodc5YIz1/+FyS/Id6TY4yhF+pESboPyhQuB3FHHhxSOCgBRBEP9Ma0hKbpImnY7OQ6UqYr+8karYyfYF1CqvfspFs1ui+R8IiS8eRX3R5iytS2k76rawF16p84/r9QlkpqJV9vv1WXqBygtFXQOETNpg5D0AUxtm9xJsV1b5NJhzbiM7iBJjiGrG2/Yg+DUWMBwQQXyaaXwzanCEeSdy4VMb8+GZo/9jnrfANlMf047IofK4fxAAUzYA3XIAVC4+WfB95mN1rydWBri+KkyQr2Jietp767KzASFWNmnpDNd4eA0ZQC/Rju6aIAYLDyltC/nsKb+U/vSN3O99u49F40dnldRv3dceLOTrfJ+GJUgjSkPn9dtCOm5I01eKOpqPSMOkTEUmNtUtTD0PpJqgUa3/J0xfgnwh9dMkV5oW4Cd8f2TZBDF3gBNd7Ub2cD2PIR+tvnoSSC8A0aRbwiAigp5r2zTKiJPFtYlts5+bCiaB2iwc2VPdYRk1sHgLSMv/CAfzWXR5jWjOEyKtnbTNK3Y6DUlw0u6FvlAGVICiplq2G6pqB9LThRzmIZLWy/+WfD WqRx2Jeh 56kcEAv2spOEqE7bqLz7Qb8jVumwXnYG2OO93kzyuCN2ZmRHa1Rwu5SVzVHgOGvLPuE1HbMkEZXn+oq5zmRzna/4I7vQzTdkS5WPOACqkTNK3vg83KTbLanDjRee7wwla5WX48KjIaHs/5yu67C9vOOVxZNbjbgSmuUPR0adeYt418+xMezUHUJD2NsFQMUkaVskw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 8, 2024 at 2:44=E2=80=AFPM Alexei Starovoitov wrote: > > On Fri, Mar 8, 2024 at 9:53=E2=80=AFAM Alexei Starovoitov > wrote: > > > > On Fri, Mar 8, 2024 at 9:24=E2=80=AFAM Christoph Hellwig wrote: > > > > > > On Fri, Mar 08, 2024 at 09:20:24AM -0800, Alexei Starovoitov wrote: > > > > ok. Like the attached patch? > > > > > > Looks sensibe, but I think the powerpc callers of ioremap_page_range > > > will need the same treatment. > > > > Good point. Only one of the callers in arch/powerpc needs adjusting. > > Found few other similar arch users. > > See attached patch. > > > > ioremap_page() in arch/arm/mm/ioremap.c is an interesting case. > > It is EXPORT_SYMBOL, but there are no in-tree users. > > I think we shouldn't apply checks to it, > > since some out-of-tree module may fail. > > I have no arm boards to test, I suggest we play safe than sorry. > > I double checked on my newly setup arm64 VM that the fix works. > I believe the regression needs to be fixed today, but > looks like Chritoph is out for today. > So I can either revert the offending commit or > apply the proposed fix to bpf-next. > I'm going to do the latter soon if no one objects. And now applied the fix to bpf-next https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id= =3Dd0d131e3b655fd267d14bb1bed49e3f990a1465e I've looked through all remaining users of ioremap_page_range() in alpha, arm, loongarch, mips, powerpc, sh, x86 and all of them do the right thing: *get_vm_area*(.. VM_IOREMAP, ...) followed by ioremap_page_range().