From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73F3C5B543 for ; Thu, 5 Jun 2025 16:17:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BB896B0105; Thu, 5 Jun 2025 12:17:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76C376B014E; Thu, 5 Jun 2025 12:17:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 633D86B05C1; Thu, 5 Jun 2025 12:17:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 40FD26B0105 for ; Thu, 5 Jun 2025 12:17:35 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E80315E959 for ; Thu, 5 Jun 2025 16:17:34 +0000 (UTC) X-FDA: 83521852428.23.6C89A84 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 010E0160002 for ; Thu, 5 Jun 2025 16:17:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YqtZeAVK; spf=pass (imf08.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749140253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/dGbqrQdsgTzP3UjIz0kbTw/JkIIyQml15jcZJHvF5Y=; b=2VOCcHjjMbO6IHDPU+gYRL9kZdzyTF4dMSb4AyVzx8lV1aNyjK3G4RmdXQbeo6u4r6uVgo KYeiL5xbK47L8x29x+rqzpSh2i614h/y93hmFOIQMRuoEbqjbgsS1wz4Ajik/NsC7qsqpU in9tJEFvyiHWqK6YifmRiI+Ecx8KzFw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YqtZeAVK; spf=pass (imf08.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749140253; a=rsa-sha256; cv=none; b=GxEWxyEbX38RBtaem5ehI1554b9kluQX+yizLQcNfZmqmPLN5jMm4oeMrEukAVENGUBeYq iL9OxhyVVHjYL/0Jh2eWBVNa7NOXjZFT8cTJNcGCzcCELKH2OqLr4yY2SYaLHCdyr1wt5t OEJ9aZjgeUaajbCKuVO7oTaOyRT8+/Q= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-450ce3a2dd5so10491415e9.3 for ; Thu, 05 Jun 2025 09:17:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749140251; x=1749745051; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/dGbqrQdsgTzP3UjIz0kbTw/JkIIyQml15jcZJHvF5Y=; b=YqtZeAVKpQcMQkrhKGAlRiEZIzXGBR+ROQbuHX8E2ek9vvrVoABRZWRiVj1z9JehYe haugFDoWYDY1PYNvGbRwFHm7stYotM0NZQwIsU06SHQRCbcI718LUEf3H+r/6Vt0tOBm 79quqskkTFQEBSG4HOpYSMLjfXmCFquuZ+ofpgVJQ/LapSxHFeWJ9BrAtLb/Ddce0yPc IOXSmqPEzzwCBJrNACYimeY3YRCHIu4eXu83eZ+P2c6UFFdOBA1P1ZiQRmK0SNeGunbn UMdoznpfWklwMnJ7RcMNGqT5W/u5rdw5zZoluzuInqgcQ1JjfuVWUsDe9EVx+eGi3vD+ YwQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749140251; x=1749745051; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/dGbqrQdsgTzP3UjIz0kbTw/JkIIyQml15jcZJHvF5Y=; b=onUSQqLA+q2vkIsbEoKakqcBByUcDBPrQllWtHgCDIhN1/slYfBc8T7CkN1vfu0itG AD3q0iP1IX+an7jLaRwhxXfS4VKtc2+d8dzqQ1574AfxqGIp4Ukj0jYbBfStF0yus13/ 0hmABpa7psIyXC4JJcEuNIv0fozZHISPsQNnrI14NsNLWEjKSN66oWerL5GgQGgd+4Ig uMG91VtMrQeR4dsU4Bo/VeZHr2B6o2uxe3NXXkQuy960TrgjVR3FuJc0R8xtyvrRjubH ctSxnNf3jPPk7ZivIdyckIs+O+6D0VM+IJkkzvvf7E4nGYUZMeyaQq/5f+eOdoeTbsuI wmCA== X-Forwarded-Encrypted: i=1; AJvYcCXk8CYTVvM7HfiRU2Y4xIe/arsBfe9u3bLA4OmtPz1QE0A3mlunYBk0StQSEbFo4m075fc3ZcsqQQ==@kvack.org X-Gm-Message-State: AOJu0Yx1kEZeHuONYpGKyn5t/2rWumaw6lElLbYS3CLuuAdAL4p+ITzT QoU6uZkYXuD0Yc5+5BKWa2Y2EAJjKN3UubivOS6AKBrUeT09C8i2F9ttN8sKyoZVGIq74TMI1JC D7cvkbJAszXKIWQdmJXUOOK6zACH/22w= X-Gm-Gg: ASbGncujdWYX/JNqGE0FpBgrbR6+Vh/k/vhjw6pHZgbPpHE/c1Llu0UVxwg/DePKTHB J3fCNow3G3w9q8JsDbPMKIdIDWoiD1mb+V9Z777v9txf3HAeaW6zqAvvrtqeZ0wLlYwEinhpXHv ptyh76p49xzdpeu9818QAC+a759soEyvXtvfTvjHBYzrMAqECQ X-Google-Smtp-Source: AGHT+IHljy+LoIqRi4m59r5NW96Zx9RUujcAPzsJblEj/I1z4yadqfI1VE3DoTtvbIg5PXHzHL/unxbytcYK+wMwODQ= X-Received: by 2002:a05:600c:6298:b0:43c:fe15:41cb with SMTP id 5b1f17b1804b1-451f0ac62ddmr74940415e9.15.1749140251202; Thu, 05 Jun 2025 09:17:31 -0700 (PDT) MIME-Version: 1.0 References: <20250127160709.80604-1-ubizjak@gmail.com> <20250127160709.80604-7-ubizjak@gmail.com> <02c00acd-9518-4371-be2c-eb63e5d11d9c@kernel.org> <8ea2aefc-2847-433e-b56e-5caad49e54f2@kernel.org> In-Reply-To: <8ea2aefc-2847-433e-b56e-5caad49e54f2@kernel.org> From: Alexei Starovoitov Date: Thu, 5 Jun 2025 09:17:19 -0700 X-Gm-Features: AX0GCFvfio4DaSSiJPkWxk8FfTQS7aYWnm7rRe7RN7TCaeYNdx8m0LgRscw5pY4 Message-ID: Subject: Re: Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers] To: Jiri Slaby Cc: Uros Bizjak , X86 ML , linux-mm , LKML , linux-bcachefs@vger.kernel.org, linux-arch , Network Development , Nadav Amit , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Brian Gerst , Peter Zijlstra , Shung-Hsi Yu , Alexei Starovoitov , Daniel Borkmann , John Fastabend , bpf , Martin KaFai Lau Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 010E0160002 X-Stat-Signature: r1ifedkjuu56xd3xjajzibpkdf7hf3ib X-Rspam-User: X-HE-Tag: 1749140252-867667 X-HE-Meta: U2FsdGVkX1+6P5DN+Jzz0PWavDYOKVEeS28ImHTMOnJL/CqmmtiYTyEwARosWcK2cSAt7HEYK2elkMdJSG+ApGrtXiBjRJuMITerbYdb97N98DwBe4vixzQjPGIHtxurDfctqwvNQvi4xQwARjU/f29xuPxnFIeB/lr4EkE3Cy0QLnBGrYX+5h4DO13E2fYQM9YShB6Zg8m55YsPcpsipAmVQiPZunsu6uXfv57P+sD1+j0AZOm4oyRnY3OevynAGX2qCd5Q4XQAjth/pcfRsLJOV+sxYMdeKQxbAYvRBF72i5l7oTQbKIa/wjNP3ygdOUwQzlQxL3wbcXiAjoE9sgPMtl17CORKgSpzRnpEeLORNjiLfPjDfGhOWFTJDCjbJKrIp5KPOo3cerybxxK6OTqSh6SoqVAFj2vZcBw9kFpRxmsiMczVZoJcXPbe1QPavx1ywMNdxyYWVo26vIr6GcrxobixqSwQcT9Xw+ykf77FaOy2A3LHj4k5nDYjeGUKp2tNIy12xFhohVYgMMwQeqiO8KY8+tGbsA0c+XF3H1pwbaSUB2sGGP3/Dtadm0xdkGnSqPXgRpO6AD5GHfXUKSXxRYuK3cMwwIxev/6V3h+szaDLuF9oaxmt4drvKSyfCecTSq6wSkBAzNNG3Hqga+uy2CjX9ezsLLHCwRrYfOZXDIEfs/fVaKo+SCRU1vo4kgF4CHSbxgdKOu8Y+tzTIq7ex5F25Et1ODDF5b/JrV7r2j5KaXYWnp4en6M9twncGBa39AviXGQ42sU01iwI7fxr1/Sf6zbAaBEcs2xon5NJeIsdaxGxv3AtSv+iZiM12II3+pTA4FRKcA/4x4EFhuA7UiJCr+vK5bxk76PpRdEarO+hiLWuTr5d0K7n4stbxMYB/bp7zVe08qTwP0lspbANyvep4SubL9hsDhkJ7jBTKytV/hX3WW7ITZIpfrPcuyEwYUAxtxQuDMoK1u4 OP2pXuEb MK7X5OBmYEVwKa2QG4VF61hIJL/2EwmmCMibVE/jRLIUSsp/bA2lHUrAD/qiCSipiJneTYc3Q4H27rrM7P5ySg/Aj5tKBKGQsrPELgYP5rosf9fuvB7eOO3VpYstrid5/R0USwbNDYlVJuM8M5hgHPSL3pDXqS2BlaFvXtT3nohzOvqzlme2S+zSwYSKSo3+YsS73C391DWGZCoEFyn/w5TzbEW897bESn7PgpUoDr/oFG7vSwmRMYB70Mgk9eKmYVn8TDHRGXMRJSuKX1iP13WnWmPUIiI8vs2t6Ztd4s97woXNgP60tLZfLSD+FF3P4eCQbZAGuTFok6pfr9boHQGX9kI8/Nm/wRGY9x3Cx01C2sFFJvNLTSuqqM9t/AwtZWBL61YQz0aiCo9JXZ2swCFybRMgnkWAACi1DNpiTrTI6h7rdPyJyx17ujadh1yXu626BCtim5r4kYehFY6hcHUELTT1DqxQNYZPHUHHZkrhzDxAZnNuVk5QRY5Hyal9E0DxHMZba4Kpn5jSwK4CSFTTp7xQdGaZel19Cr4/bHgkqq+rQryNAM0Nal6ZTmkXRik/nqOziwzcP10HEjDd5b0o4QfPzZ3RX0VpvmjCkGf+qJEz/NQ/m8qhcV9lKPnlgoe3Aajd6pfxJBJq9ahYVG8+16FHjXnFr98AgmwCFRhNIAgH7r0WqbDybCFs/t0O3tRt6BV5V00jQMnlkACGYfHxPONaqW9ZbrZUQ5ZhWq1690ajqYcrmgEKGSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 5, 2025 at 7:32=E2=80=AFAM Jiri Slaby wr= ote: > > Cc BPF people, just so you know. > > On 05. 06. 25, 16:27, Jiri Slaby wrote: > > On 27. 01. 25, 17:05, Uros Bizjak wrote: > >> This patch declares percpu variables in __seg_gs/__seg_fs named AS > >> and keeps them named AS qualified until they are dereferenced with > >> percpu accessor. This approach enables various compiler check > >> for cross-namespace variable assignments. > >> > >> Signed-off-by: Uros Bizjak > >> Acked-by: Nadav Amit > >> Cc: Dennis Zhou > >> Cc: Tejun Heo > >> Cc: Christoph Lameter > >> Cc: Thomas Gleixner > >> Cc: Ingo Molnar > >> Cc: Borislav Petkov > >> Cc: Dave Hansen > >> Cc: "H. Peter Anvin" > >> Cc: Linus Torvalds > >> Cc: Andy Lutomirski > >> Cc: Brian Gerst > >> Cc: Peter Zijlstra > >> --- > >> arch/x86/include/asm/percpu.h | 15 ++++++++++++--- > >> 1 file changed, 12 insertions(+), 3 deletions(-) > >> > >> diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/ > >> percpu.h > >> index 27f668660abe..474d648bca9a 100644 > >> --- a/arch/x86/include/asm/percpu.h > >> +++ b/arch/x86/include/asm/percpu.h > >> @@ -95,9 +95,18 @@ > >> #endif /* CONFIG_SMP */ > >> -#define __my_cpu_type(var) typeof(var) __percpu_seg_override > >> -#define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force > >> uintptr_t)(ptr) > >> -#define __my_cpu_var(var) (*__my_cpu_ptr(&(var))) > >> +#if defined(CONFIG_USE_X86_SEG_SUPPORT) && defined(USE_TYPEOF_UNQUAL) > >> +# define __my_cpu_type(var) typeof(var) > >> +# define __my_cpu_ptr(ptr) (ptr) > >> +# define __my_cpu_var(var) (var) > >> + > >> +# define __percpu_qual __percpu_seg_override > >> +#else > >> +# define __my_cpu_type(var) typeof(var) __percpu_seg_override > >> +# define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force > >> uintptr_t)(ptr) > >> +# define __my_cpu_var(var) (*__my_cpu_ptr(&(var))) > >> +#endif > >> + > > > > Another issue with this is this causes all modules in 6.15 are 2-4 time= s > > (compressed size) bigger: > > $ ll /usr/lib/modules/*-[0-9]-default/kernel/drivers/atm/atmtcp.ko.zst > > > -rw-r--r--. 1 root root 10325 May 13 11:49 /usr/lib/modules/6.14.6-2= - > > default/kernel/drivers/atm/atmtcp.ko.zst > > > -rw-r--r--. 1 root root 39677 Jun 2 09:13 /usr/lib/modules/6.15.0-1= - > > default/kernel/drivers/atm/atmtcp.ko.zst > > > > It's due to larger .BTF section: > > .BTF PROGBITS 0000000000000000 [-00003080-] > > [- 00000000000011a8-] {+00003100+} > > {+ 0000000000012cf8+} 0000000000000000 0 0 1 > > > > There are a lot of new BTF types defined in each module like: > > +attribute_group STRUCT > > +backing_dev_info STRUCT > > +bdi_writeback STRUCT > > +bin_attribute STRUCT > > +bio_end_io_t TYPEDEF > > +bio_list STRUCT > > +bio_set STRUCT > > +bio STRUCT > > +bio_vec STRUCT > > > > Reverting this gives me back to normal sizes. > > > > Any ideas? Try newer pahole ? It was fixed by: https://lore.kernel.org/bpf/20250429161042.2069678-1-alan.maguire@oracle.co= m/