From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F446C43334 for ; Thu, 7 Jul 2022 22:41:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EC156B0072; Thu, 7 Jul 2022 18:41:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D226B0073; Thu, 7 Jul 2022 18:41:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 664056B0074; Thu, 7 Jul 2022 18:41:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 545EE6B0072 for ; Thu, 7 Jul 2022 18:41:25 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 24A6460634 for ; Thu, 7 Jul 2022 22:41:25 +0000 (UTC) X-FDA: 79661776530.31.7D113D3 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf20.hostedemail.com (Postfix) with ESMTP id A3D0C1C0038 for ; Thu, 7 Jul 2022 22:41:24 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id dn9so29549518ejc.7 for ; Thu, 07 Jul 2022 15:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x0hTg3svlPkX7yjZEejAqipfWlRrXxPxf4EQelGBTvo=; b=JjLDLcNl//HbIrbRbWAfVo8D/EHxetYwwUclgU4IpzJTW1aVvb76jqCKqg3pQTeotv uI+pfXcAlpsxTDhK2XQU/X0vIHaOXSJoKWs9rkTxjxYJ9wiOflV/IzcsJSUlO04l7cjS uDSH6tP2pdODKwl8VBAPJ715+J05mEiLpIH5b5kK+VQoCEQfpNJ0Wgyh9SG3orG3Hx+P enbo2ru4HaAYtaJKwPwZTV8Jc0rTwxb1Y6qPZDBw7LzK7qLy0N+3fslDNlZWbTnvnTyi x2LlCTlGHuTrJscVe/nGn5oSQABB6NQTA2FMSsEn5XXQ1rUyE9gMoiUWHUSGTufjkeXo DxBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x0hTg3svlPkX7yjZEejAqipfWlRrXxPxf4EQelGBTvo=; b=CBIFLCgVbr5z5eoubOsLkjiYKYxiMDLEFQnv6sIKecq9QoE+qTVIMknzX2hOc8/ogE w61xdce91HMJoJoXOANCsZHx5nR5WzSXLWu5STLeDlQ1uzfOnRowxnAvqhhlisyzGTkQ jxKj6IG1GW/hJ4v+1wu5furT0tYaQpYfjxVAYvwcMWKFNcgpf5jXRLhnpMbdnszFxeZr zeKy3uDVrU7p9mBb535wMiB3sgQL0RmD5JIjXMSK7KA/IPLRtYMnozJy83ARklBC1H+b rnkN+S3C1LErsNYx6ewfE4H8c7C9ILDfsJ552LN8t7rLT0vjh4Dp+aTtrSpuyse6QAig jTZw== X-Gm-Message-State: AJIora9JZ2OYyKnGvn1LU2pkyEnBVwehhIjEzp4FcLu3+ZVaYK/yqIpF V8Yrs7R0foVl8mEXvB+B/CPcaefOsHDG/Wx49/U= X-Google-Smtp-Source: AGRyM1s0deLui/79j5hjBtPHHhjWJfeoyGA22i+D5HMSMsSL5RUY87JhVevlzB1bvYW08banAks08/NbPsWpeOf/OlM= X-Received: by 2002:a17:906:8444:b0:72a:7dda:5d71 with SMTP id e4-20020a170906844400b0072a7dda5d71mr425919ejy.94.1657233683381; Thu, 07 Jul 2022 15:41:23 -0700 (PDT) MIME-Version: 1.0 References: <20220702033521.64630-1-roman.gushchin@linux.dev> In-Reply-To: From: Alexei Starovoitov Date: Thu, 7 Jul 2022 15:41:11 -0700 Message-ID: Subject: Re: [PATCH] mm: memcontrol: do not miss MEMCG_MAX events for enforced allocations To: Roman Gushchin Cc: Yafang Shao , Michal Hocko , Shakeel Butt , Andrew Morton , Johannes Weiner , Muchun Song , Cgroups , Linux MM , bpf Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657233684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x0hTg3svlPkX7yjZEejAqipfWlRrXxPxf4EQelGBTvo=; b=nPcmQ0VXZJqv3cidv7L9p9Z5tfQBob2u1FNQ24NNWjiAxnCMo2OD3Ik4qIX/RWP1ohzfNL 9wQ4Ha5G12b73o1KyU1M9XqOtqMq7GRSOKMr/5Go3FIHc56gq+11HLOmfKrMioPmJy6eI2 TLi2raZw1dLcQeLvDEnQcGk0yJooIOs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657233684; a=rsa-sha256; cv=none; b=CAAEn3PyKgDYhi0fB5AsTWl7oxhIczKFIOjk9qCFGJNUc41EJVXxnXQF2YJgtPixIURNcQ KTnKCn/Xuq2wQlrBRj/wK/pd0kh2YcUTJ6XJ1RE8cFz3O30wXisGoo5/1u5bPeFwjwdCon J5sznGPhiwpAzanUm8GhBz/6hMkKjLg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JjLDLcNl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JjLDLcNl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com X-Stat-Signature: 99rqiep1au5pgd5xksogcikoxt1oyrpo X-Rspamd-Queue-Id: A3D0C1C0038 X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1657233684-952320 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 5, 2022 at 9:24 PM Roman Gushchin wrote: > > Anyway, here is the patch for reparenting bpf maps: > https://github.com/rgushchin/linux/commit/f57df8bb35770507a4624fe52216b6c14f39c50c > > I gonna post it to bpf@ after some testing. Please do. It looks good. It needs #ifdef CONFIG_MEMCG_KMEM because get_obj_cgroup_from_current() is undefined otherwise. Ideally just adding a static inline to a .h ? and if (map->objcg) memcg = get_mem_cgroup_from_objcg(map->objcg); or !NULL check inside get_mem_cgroup_from_objcg() which would be better.