From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F60C83F10 for ; Wed, 9 Jul 2025 23:15:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9D2A6B0092; Wed, 9 Jul 2025 19:15:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B75666B0171; Wed, 9 Jul 2025 19:15:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8B066B0172; Wed, 9 Jul 2025 19:15:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 95B696B0092 for ; Wed, 9 Jul 2025 19:15:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 13A5F58B65 for ; Wed, 9 Jul 2025 23:15:00 +0000 (UTC) X-FDA: 83646283560.03.F1B3E38 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf07.hostedemail.com (Postfix) with ESMTP id 2E4234000E for ; Wed, 9 Jul 2025 23:14:57 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dKJQto1j; spf=pass (imf07.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752102898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BYJOdamhFPgWOOLsL56Q4wei5GHMmw+MZHBvYTLYgYk=; b=pt1cd7SqTP3E/vamDm9l5DTx6og/hPHy8CycWdYaB7UIXHayCYa8oLKHNd/ISFTxUsZFVj piKrC6ddGTDK7lKKtvEqNmqEDVBYyqrbOX7T8t2IDww3MVmrkby+cuJ/rQqu2rD2AgJ1DV Lil97Il52uOjrDjcPqZFr/yLNtXYRnc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dKJQto1j; spf=pass (imf07.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752102898; a=rsa-sha256; cv=none; b=p8aVaiTUkyPRFlH5AoJCBAQtYxOsaUXvL91KChRkCdh9sDrlnendu8+XPTRVIuKf8y9bnK NjLpLhoG0n7rALQ/dqJWsgCKjD3EVtTWOmC50haK4UG6Jx7M5taQJVxWUNd2zc1/hxFOeE tCgXrS2nyLeiU0EoloklH5YDitKAj7U= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-450cb2ddd46so2149615e9.2 for ; Wed, 09 Jul 2025 16:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752102896; x=1752707696; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BYJOdamhFPgWOOLsL56Q4wei5GHMmw+MZHBvYTLYgYk=; b=dKJQto1jkEkuSyviuPX7ZSNBlpfsegAvyAhk+VLzizDyjFR6++Vcfbetkivu9AkmiC AvbxSKeDQeTOj08OPtf7t4UeccxBj2Ec5O0IN0YFgET+xlj+rdtNEWoNDkbqZKv3IBUk z6F5RHuLljh1CS4pT3s0Ku/tSFde+RujYP9n1ikTgfdCw14kUQcodRsoIW4oQDUW+9Ly wBmWEMgHHsaumbDETPtwMveTV0SZjaoF1w9eNl3Bp89HhagLTV9Jm1v/8BvgyCnvnu8c V+eFWdGhyJFIfH2ReG300Pz/EyoZEfQbHVRVcvXMxRyLb6HTcLqBuxcakpxR+2wnfdUr 9JnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752102896; x=1752707696; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BYJOdamhFPgWOOLsL56Q4wei5GHMmw+MZHBvYTLYgYk=; b=eTtiBTYpFro39rTVdfB1+o5OHigaUk1UPL7+b5lChIkTtLP0rwqXe3ceUjB0uscv92 WgAFubgjI8XmOYzH9ts+u91r9Ci4XLYqfSvrWeXRJcC3p0vIJp6o/tfjEDTSV3ebd8ys cmwFvyZc/hqk6M856F7klCZ/Ntr7ZctujEYYdF3vT8UMTg6RQ7AVuW3vZVtarFjs3LK3 On2qvglwdzF0Xc/wgZh+V99BstopQHC0mAEzD6NybB1R4pYXsvYQU9ZShY6Uv7VmQPgn ewl0TyqGJP3tIT5LhG/gcGOwaKGoD79gGHjgTnLH5XKKSvgqsuGRBoP4NMMEFGiGvbBS /GBQ== X-Forwarded-Encrypted: i=1; AJvYcCWqWI80pPpq6i12bbq8UpmSILLb5y6imiAplY8DwyZYKaoyLkx89l1qGALcfbMO5JQvVBvu1mqt7w==@kvack.org X-Gm-Message-State: AOJu0YxygkCFvQrJY0pebJV3dlScGHark2gr0Jz5hkNlqM35YFk6SN6s If1Nf+Voc3HnEAfIvmfjecTfSA5/XJ8v8wzp+kQz1ULHb4psD2KsOCaR89TiUaSU79oVv7naU9c h7J9cbznEsVZBJ+EIM61FxoMBweQKVds= X-Gm-Gg: ASbGncvKGAZxqbXKm3PexK6NTVBNIdkYR8PBpQNIrz6y7swf2NRNdS8W1fKHdUCxb3t 7rxJ/gCFM09JGCvfbX11cszd6dmQhjlyQfYJhEMkohoxfApiJsxDkq/OzXGFY835cakxQM81cQm VtDtbpRf1j+TFMSOf49x6o/sNjSSuG5s0r1P+kTF6W8RxU/X6otfNKvPOkE2/m8m4Szk4W07z/6 qKA8a9uoIc= X-Google-Smtp-Source: AGHT+IH2U4htcocDaxL/p00xb0f1oc0l7cDxqJ0pRS18MFAp8gYunrtlWXqenpefwu6fXfVI/uyDO3Sv/FaxpvA7yQo= X-Received: by 2002:a05:6000:24c1:b0:3b3:9ca4:ac8e with SMTP id ffacd0b85a97d-3b5e4537ad2mr3933193f8f.44.1752102896415; Wed, 09 Jul 2025 16:14:56 -0700 (PDT) MIME-Version: 1.0 References: <20250709172345.1031907-1-vitaly.wool@konsulko.se> <20250709172416.1031970-1-vitaly.wool@konsulko.se> <14b08e7c-c2e8-435c-a1dd-bd51cfb42060@kernel.org> In-Reply-To: <14b08e7c-c2e8-435c-a1dd-bd51cfb42060@kernel.org> From: Alexei Starovoitov Date: Wed, 9 Jul 2025 16:14:45 -0700 X-Gm-Features: Ac12FXwMoZpB8rTLNPshgJLrHIXikIq47lGVql6Qo7vJk3Tj5z4cIDxTFaOoom4 Message-ID: Subject: Re: [PATCH v12 1/4] mm/vmalloc: allow to set node and align in vrealloc To: Danilo Krummrich Cc: Vitaly Wool , linux-mm , Andrew Morton , LKML , Uladzislau Rezki , Alice Ryhl , Vlastimil Babka , rust-for-linux , Lorenzo Stoakes , "Liam R . Howlett" , Kent Overstreet , linux-bcachefs@vger.kernel.org, bpf , Herbert Xu , Jann Horn , Pedro Falcato Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 2E4234000E X-Rspamd-Server: rspam09 X-Stat-Signature: 3q59atnzzuj9nou3sjurzw19idry4e5z X-HE-Tag: 1752102897-446615 X-HE-Meta: U2FsdGVkX1/krG1Ij7JzZuuB9MrHYlqN5MY0y9znoc8PmZVEAdrJI5KfmnO4WUh/xlf5vxAve4rom/Q+9wzLNbjW4CMbSMCjnpNl6ko6wTxhWIKSf5QEcFWvPvaIazc3Ip3STO3b5h1iEsinsjpTQQcs0LcnvI/PpKM/peVD9bT6E/YdewgNlKD8Zju4fwVuIbVUMBilqYDhiclsHZzdxPteqvApP8gV5J1I3vmhhjc/gyJXq0ZM+2tRS2ugdFnlMkQq9xy57PRW0MK8Udd6+ns+qq111g+c7ntwl0keqxsnZveiWRVsr4PSua5aLJrVYkyzs4xzbdwGV8V7dvPlwDmO9mBGUn0rOqVrrm7gUJPD+Z3vNtltuRuwGNfgov+1xbnk2ooo9qACihObNAIqLsm/Fh7E3sTmoPlrPvNyOh8N6yy1eK7yYcP4PoiCrt/mq4VeSGiCHPdGZXqqfLC2FwTSk2Z/bPg6F6TtgavVL0asuPyc1AJCN6Ojs3sMNw31AmgfB77XkYiuO8i/Y6iHf1U3uZjYfKKNca6ecJp5ZJW6unmpDctfNEqmExsJBGMzGj+CWqda8yAglLNWlLEggcXt7jfKEjqPMVOSLoy+KDvPMqmvBaKrJtXFKTrOYlkA4qu5PV9qQXclzNxWu2mqrRDXzIU8TjbVn/ywhZ8tXP7QU4jaIQ2cHMdLuUGvd9JYCH3GmL7N9viG3IEYK17nKusEh1OH7Ow+AClL5BsIQGFLgo39DInKSuhRNkyQkagKPntS2liYbFXl3D1ufS26b+6Msq/hf66K4gDSIyNcqY/muc10dbhDCAYfUAqIAqoQXoVUTTkfOz2K0Aav2QxTUbheMIOugl99sGYzhxhM2LYqim4f4N0p7RwlaveVimn6v+7mh4sR3fMcoKniw7/d3xjXKo+g9fU9RVrHNAVwPBJgfhUm9Ldn6iTkxtF27uVYLF6BrrSUIds6SH8KIT7 orjOrYa2 nxs76FGAVmH4P0XeYX81rdz2h7ATDRePw7OGIv/3JjdAZfJjw4lHfrMzfWrInovw4s8oaoPoyQYaVRkfAlI08iatipgjkA2+A2DyBKDc+aw9CKObhLFeQlAcxrrq4LJWbQuvXeA2U2xGjv+ncM6WWpGYs55U4Ef73PBVddSlETQ9h+BgcAiSJTUm8wPoORph6wE7eE0LByXX35JMEQXaW3f47w/Y5vKlJJKWFfTT8mB9g6UJPGoIvOG6mFi6BdrSSBsijMxlgMgO/RPojzeLEzKxQTDRsC6L4VGFBFHqqnwa+j83QT//wxyzbfutJ9H9PWfUbonP0/pBYcVseKuw8wwTVJm3RwHwJnMBYDKJ3CAw0DH7BX38GNP9B/5VlL5MmKm3U0SKpyw8gn7Qyc286Kv9tVaMd0TjDqyV5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 9, 2025 at 3:57=E2=80=AFPM Danilo Krummrich w= rote: > > On 7/10/25 12:53 AM, Alexei Starovoitov wrote: > > On Wed, Jul 9, 2025 at 10:25=E2=80=AFAM Vitaly Wool wrote: > >> > >> > >> -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > >> +void *vrealloc_node_align_noprof(const void *p, size_t size, unsigned= long align, > >> + gfp_t flags, int node) > >> { > > > > imo this is a silly pattern to rename functions because they > > got new arguments. > > The names of the args are clear enough "align" and "node". > > I see no point in adding the same suffixes to a function name. > > In the future this function will receive another argument and > > the function would be renamed again?! > > "_noprof" suffix makes sense, since it's there for alloc_hooks, > > but "_node_align_" is unnecessary. > > Do you have an alternative proposal given that we also have vrealloc() an= d > vrealloc_node()? vrealloc_node()?! There is no such thing in the tree. There are various k[zm]alloc_node() which are artifacts of the past when NUMA just appeared and people cared about CONFIG_NUMA vs not. Nowadays NUMA is everywhere and any new code must support NUMA from the start. Hence no point in carrying old baggage and obsolete names.