From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 651BCC3ABBC for ; Tue, 6 May 2025 22:05:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B4B46B0085; Tue, 6 May 2025 18:05:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 764386B0088; Tue, 6 May 2025 18:05:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62B0C6B0089; Tue, 6 May 2025 18:05:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 444D76B0085 for ; Tue, 6 May 2025 18:05:45 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 41FC580334 for ; Tue, 6 May 2025 22:05:46 +0000 (UTC) X-FDA: 83413865892.24.64CEB7A Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf14.hostedemail.com (Postfix) with ESMTP id 36BB810000F for ; Tue, 6 May 2025 22:05:43 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R0nSgMUv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746569144; a=rsa-sha256; cv=none; b=Mp+l8Hmoa2H+G7g/ZMEl3/rPUK0ArakD1KYBeasnY2ZufjESarwpbRnUejF5DCZ0f/0H44 zIL2moFawegdAkFiFOEL7tEW4PKHuV0l95Bm/vx5SH1CYh/F5jVB2K4dbwc3G/+hy7pg9E rMtOOOoBjLRm7Pt8pjCKCmp9eU37/Vs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R0nSgMUv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746569144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KipRk4T764WfCmu0wFyxjVxI3EJCSRQ5r8frLRwrZrw=; b=wM6PJnPjTLvV+//IvK2LnBGWTMj0PT6Ve4PgxYgnkYePT7IXpIIsX1mERgdwUPJED9BWI9 JtKCq8PGMGsK/tqQGxwLK1qpQ665hLxNK2CQj4g0crFsXa0eIITOR/z/gg0/E/IaZiNzRw QRn7eXDPKErXddmObHf5qKHiE6LYJcU= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-39141ffa9fcso6669507f8f.0 for ; Tue, 06 May 2025 15:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746569142; x=1747173942; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KipRk4T764WfCmu0wFyxjVxI3EJCSRQ5r8frLRwrZrw=; b=R0nSgMUvjYksrsTMD6VBN7OSkY0bP0fPOBIIOT48LM3v2fgThqCRQWyFRJh9NRV+b6 MTjSnYS+U6tTgqW3rzZM6aSW3lnfAWmeyTYA4RrYnHJyIOH2K4wD/S/qMrss0PLNJsYk qo7zoewTKbWQnb0wd4uNV9Boqtb52jDhDJEzoaUyPiJFpoY8VsRQE3gqhIDxxpZF0aWi 0L8L1DcdB7GtDQtfAEA2vqfyc4zSDkiRRsQXPkjWsvdLPr9PeNC7FdjhUfwFw7/lqQKi 4yB/D9TdI643wysTmFy4GWByi2KCdFM7q9hqrv4fU1FkBOJgzMFVkFLPvw0CA5eDTk19 wf6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746569142; x=1747173942; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KipRk4T764WfCmu0wFyxjVxI3EJCSRQ5r8frLRwrZrw=; b=GurzxAsN/VOHjsXl56+7+YmnIwkdkgwQszk8hukeH+jg8WAkrDSLar0do0MUENqxbn J8XxPrxjR7OszoeC5GKRQ0LWrcnvvJoe97/+VbaVCWl9OshQ/zc0P0IdjHleFxBQe7SW 14F35iYyLIC4/hbpV6W/3jwhCI0o4ocKdJIeWmiHpx2gJ3UaJqHjKS4Ee7up8EqwSuU+ v9/6pWcB6V03knSQpGE4BCJlmvb0uAS609UuftsRMXt9wBEPVJczmINwlMrhgrPSeKcE QVxVGrYL4tB1TqzRK00DOjPyS0L26+Xeb6ptrrwhi2R7RgQVVYzvlMItCPi8pawDBjgM uCgw== X-Forwarded-Encrypted: i=1; AJvYcCXz1MV2quNvW3KxNkFZvOaZV4gCf3ISFA09rmb531CGYBS8uIIbCEZAf/TCzuB/GW5FgsOQtMAKUw==@kvack.org X-Gm-Message-State: AOJu0Yy2bfGmdQFgUb/Ay4t7ySGkIU1K6pg9xRck5S/XNHXt3BjR4Efr TRYaWFDM97nO2qBZNlnIBl/qV7+JByH+eeq6acoNdPEXDiSGBt7FuiFat/XumudR7EHXfRdfuvW Wk36mM4wBfktM1A1f15c0B2Ck4DM= X-Gm-Gg: ASbGncvsWHg4ZEMty0OC2GOuwYeMeT5ByCxz58Z1Xry5YG3dHBU3zMijD/wRQGHi/+1 lzzt9llX544JeBlKUIfyTH2ZtDPo9BgYnGt1e2RsHUSd1lvK0T4GvOufcZYvD5nGz7yvDnWdPLU 3KfUR6xbXctq4uSR/mydBjrQ8BbcGDvHIqdbcgaq57rdXUpigIdA== X-Google-Smtp-Source: AGHT+IE25DZ//XnJlkjj3EH8ZFFd41BFs36NSpSFuQBE3faebw8bT1aWwOWkbgGGp64gVRd3F+KAiVR2q0MyqbOFdc8= X-Received: by 2002:a05:6000:40cd:b0:3a0:8712:4f51 with SMTP id ffacd0b85a97d-3a0b4a14668mr771413f8f.40.1746569142426; Tue, 06 May 2025 15:05:42 -0700 (PDT) MIME-Version: 1.0 References: <20250506112509.905147-1-kirill.shutemov@linux.intel.com> <20250506112509.905147-2-kirill.shutemov@linux.intel.com> <5loiv7lfplpruujplz7wmzj25g34rs2aezvrfsl55dsddrh7mo@rnqrlx5zccol> In-Reply-To: <5loiv7lfplpruujplz7wmzj25g34rs2aezvrfsl55dsddrh7mo@rnqrlx5zccol> From: Alexei Starovoitov Date: Tue, 6 May 2025 15:05:31 -0700 X-Gm-Features: ATxdqUEFmKJx_9lHRGWUehox8hv3ijG1FV0mSYp85G8ha8fWtihliKeq8C6j3Ns Message-ID: Subject: Re: [PATCH 1/2] mm/page_alloc: Ensure try_alloc_pages() plays well with unaccepted memory To: "Kirill A. Shutemov" Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Borislav Petkov , Thomas Gleixner , David Hildenbrand , Alexei Starovoitov , linux-mm , linux-coco@lists.linux.dev, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 36BB810000F X-Stat-Signature: wgkianqbw4ap7e8hqgbsn7odbjgjgwfx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746569143-44270 X-HE-Meta: U2FsdGVkX19t2hTZKg8j9csUzGDAFm7XQhnDmHlt6fvs59Brb/J5DRScvesRbc5xoap8qphfRF3W2wQ+HHRDONPLS9Ed3zw8DxWkw7cAHrf9TqIQD3VcXbsV9T/P2B1Paj7sCngN8M9D0BGxTAQi2cHBxbaqh9R/8Ey7Z7nNTHYoXCvD3jSEDJtSf5yUPZ8ZMa0yyPk/3ouT2aGmR+3LhvXgRHJCEqiXrCnA/XJlvEMuxJR2L1a6x1vV5/+1ZPPuzFO6xWiAcgP1TcQreNSNY9HvOHH5rJKHc+E0ChXgvziVdKvTtiV4U2ZIxmtV+I6zPSDe/zA7vfgY0G3R09/xMt1ao9i7HwZ1jpjQHsdFHQz0YcrXU3z6TOVQRqybwzY2B703fAbhr9/GlSjl5s1KC2RpZod5ppGaJWCrmqnHMAwG+wzFzUh7jJpchSjSG4gEG6CI5kBPTB5DZI04+VzygzV8odNx3xsewDUF1xLzUdBw7NDG2lPGNr/K4hbM6sN70z9Cin1uVU7GCf+DMssOM7/ZNGhfwd0Tl8OnEdsG0Kq1uGXpIKOdxlhs6XltEAUKPs2I+9Oskbz3EBEL/5rq0MJ+nxhDndHG2rsZQvMahEcXiDJ1Zq1eFHYAGvRYJKu/jZmcwX8MOwdFJHtao7sAG8TU2SYKGgqbAu3jR4r9tenEWtwTRWgV+NAkbvvWmXHucLmdxoneNXKt2yN40RIVcKMFoxuc9qBqD87FQMb+MArdBnQBBX3yW9cDGmbPtFZcBbYjRk19y3yKAcpo5ThNuxS1aYdQg/skd3VSeAfQzzbgv3vKpswzoBUdRaw4s0MXDCDm4m/5xu6hIiM0Iq/X2wABYrf+oqfftobdhS7uht03oSLYeEZeqBWj5SYGs0EUntDu00d6t6XA9L5s7I+0V6Z+AsPXf7LRhhE0z1Uw7p3sRiRQP3VeD2gJ+ckTyx3syqJrPd/2fcmZB509R0G 9a0GoR6E bx40qBtZL0TmgL4jyOii5hHFKD0fSOAPJIRKJ2x58hXlTBIk0CerPVI1vmYzD9ZVyOiEVwtketaYGtNkXzVKoqArGNQSkolBcmg58+Xwj8mWcUXHi82JkzpUFNppr07lo+vRAlRtxgoYrC8WjHRX0wtybdD+E2/tdBiysnFFthS83spJb6TIeYUovpkYdkxG0ovNQgdMhAME6dUyljo7dbWTMrc4QwjEIQ9ElCkPRNmjF0DA0k2kXcdpFH5ZTJr593cjutq6BC+w/7KnjXywF9g1rwbSTMxkyHDJavI5WDeGk59V8uf5gJjgw4XahLcU5M+BS5HnXBCNKSqFW0jOzIIEcMf4EeY08y1XvCslaATpW7eaAK6HgqG1rG5eyNcZUqn7ihYXLM+5uMMBJYagwyT0lLVag2fiHYdCJiVBO9kDE74Pj0d9JlWnoQJZRkKnRsdXdzv25djNK35s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 6, 2025 at 12:00=E2=80=AFPM Kirill A. Shutemov wrote: > > On Tue, May 06, 2025 at 10:18:21AM -0700, Alexei Starovoitov wrote: > > On Tue, May 6, 2025 at 4:25=E2=80=AFAM Kirill A. Shutemov > > wrote: > > > > > > try_alloc_pages() will not attempt to allocate memory if the system h= as > > > *any* unaccepted memory. Memory is accepted as needed and can remain = in > > > the system indefinitely, causing the interface to always fail. > > > > > > Rather than immediately giving up, attempt to use already accepted > > > memory on free lists. > > > > > > Pass 'alloc_flags' to cond_accept_memory() and do not accept new memo= ry > > > for ALLOC_TRYLOCK requests. > > > > > > Signed-off-by: Kirill A. Shutemov > > > Fixes: 97769a53f117 ("mm, bpf: Introduce try_alloc_pages() for opport= unistic page allocation") > > > > Thanks for working on this, but the fixes tag is overkill. > > This limitation is not causing any issues in our setups. > > Have you had chance to test it on any platform with unaccepted memory? > So far it is only Intel TDX and AMD SEV guests. We don't use them, and my understanding is that such unaccepted memory will be there only during boot time.