From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A924C05027 for ; Thu, 2 Feb 2023 11:15:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0F676B0073; Thu, 2 Feb 2023 06:15:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABF206B0075; Thu, 2 Feb 2023 06:15:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 987186B0078; Thu, 2 Feb 2023 06:15:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 894796B0073 for ; Thu, 2 Feb 2023 06:15:54 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 597BD1C670D for ; Thu, 2 Feb 2023 11:15:54 +0000 (UTC) X-FDA: 80422097028.01.8184E2B Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf06.hostedemail.com (Postfix) with ESMTP id 7138E18001A for ; Thu, 2 Feb 2023 11:15:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=F9HPADDY; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675336552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wpEflEFgONyZvi4WlCVrqQszvFR7vLDMgEvU+XA8+7w=; b=xDscBa4Dg6vHNm53BK+R0opJejmCkLvK69QsXpZUxZFwqJDoKyKzSxOc30nk4Tdo0x7TZs shAR/t/hZZ3+QnBFnMw8t2vSVeKm9YGX5X+8XyBekQc4hJYEEiPuc61WphrRjfR2hV0LQj fHUlfNqrFlB2xfezTLKmEkpRtL9cG0U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=F9HPADDY; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675336552; a=rsa-sha256; cv=none; b=bP0n/BmDjIT9B5VuyeH8CAMAUG8/3rHDZCxLhHtq0APZLnRxY7aIw7bQgI1yeauH4Iuqx5 SPqMRRplKVpHviMnJ2xzq4xYwjP2wc2QAW/EdrRv1uSFdww5VM3rqQrntViCxvukFJN/8Y 7oR1FTYjZDK06YMNKk7llLy7Kb1dsQM= Received: by mail-ed1-f46.google.com with SMTP id m8so1600783edd.10 for ; Thu, 02 Feb 2023 03:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wpEflEFgONyZvi4WlCVrqQszvFR7vLDMgEvU+XA8+7w=; b=F9HPADDYpgDBMmMTw31hsL/BPt7sHthFt72xAHYYI6C4/tsAnTR9FS5BP08bc1GDo3 DlNxEE3klfp5hJgGUiMrrQ2mXMAacJZUbuP6LwQWECphzi485IppWULASmHz4LQ0aNhe xmD+ztykHvf7YxHzipN8QUabxTl21cADcR325iN5Z22Re7fK+YDv+KzZtQndt4y5qkdR FvWv+JZ4jOrSNBvgP++Q08Zn2vgEBArx8wh4B7VvOiWaOtUyeJ4ZEG+usB/Ibqg1JjPd Y7k9q6EN6VNFNdx2Qh5peMUR9I7rEkdi8CWxdUbf7hKziuzJzDOYs8600k1Q5nl5p6ld vFyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wpEflEFgONyZvi4WlCVrqQszvFR7vLDMgEvU+XA8+7w=; b=KfcznlnXUB28vZqEQUtgMP2nAWCnytruEvshNVVtgKss2UPNJQ8t4DPo38i4HWAcG6 NqZo7m9xoLi5dQnUKUwjTer2bSb6/UYYw5e1rQc/QLFMQe7QutLGJHzTMxK0AJlIQV7P H53q3vZxGHvBeWPIeunlLX8Qz0/Wsitd4B9LgTbgsrJDdSqHLCu1jeAGmGuPo1QShgFb uiETEIljuWqQLNQsdioNdrrQyQnceuwtHAKmN1PB3Twjgk9quJ+pFhl5jAjiTna5S3xK C2Uj2VxkMxF2N7r0Hr8qPKVWoI/VYVggviRHAHhliCBVl9SGzYKuVJUfwEg6Nj/3Jlu2 c61A== X-Gm-Message-State: AO0yUKVnP0d7MCSX3yDvIsARy7PNIC15RwROjJiBjY57EOwiC46l1a+Y ZY9tL24/UY9s3Qoo8ySRzIdExJZ0WHl29eiQuyE= X-Google-Smtp-Source: AK7set/7vshqxPiS23f8zcEnLOB/WqJuLi7g76SaS9Fq+nI1GtacYnaPHdA3rg1UlpyFnJfbN29NT+FyA7W/0XKnnAM= X-Received: by 2002:aa7:d385:0:b0:49e:6501:57a2 with SMTP id x5-20020aa7d385000000b0049e650157a2mr1774099edq.43.1675336550794; Thu, 02 Feb 2023 03:15:50 -0800 (PST) MIME-Version: 1.0 References: <20230201135737.800527-1-jolsa@kernel.org> In-Reply-To: <20230201135737.800527-1-jolsa@kernel.org> From: Alexei Starovoitov Date: Thu, 2 Feb 2023 03:15:39 -0800 Message-ID: Subject: Re: [RFC 0/5] mm/bpf/perf: Store build id in file object To: Jiri Olsa Cc: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , bpf , linux-mm , LKML , Linux-Fsdevel , "linux-perf-use." , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7138E18001A X-Rspam-User: X-Stat-Signature: 38b1f5gsxbh41h5erxhy9zz7444c7x9d X-HE-Tag: 1675336552-748428 X-HE-Meta: U2FsdGVkX19gQxUTtWCOjcLu7LBA2CrAHwRzggJGnpVfY7TGQ3Moo0AU6fGlbfr9rXv4/kfK/gDRBHj0P8oZE/K1OuGlrgmjfY7QRlrf5jki9xPoUlClwr6HBuvVXS4zMd8p5HA5aGJ4BjI3RGUO3VelUN4DT/ZtvcxpJ/sXTd/nmON96ITKXnJa7vVC7Jtz2LZJzDoMFEcZraF/Wr686wdV21iRIVX6RRO3XusFWq5wCkCZJAdTenr5qfLsiTwcI1ZX2UycXPfLrUOMsBztzMF5q+VFW2lKOria/fdnrBLf2t6rhKecdp2QR3Uovpi08bDJAFteU3jnNVjfTxNu9orsosuEGHv2JdE0jmY04qlSOoajHUfUs8pKubowyrbW3kGIx45TjSz8rkkiqSa/GbhiqbyyWliqpySHNa6hdKeOuH3WlaraTZZr1MINmFrz0K46pP8awzPeYPA6EZbstTBoVlEjmQpto3JT0+jcXUSomJMogU9FiQ1FKKcgimThO/b3GE8cevo0PdawLG0QzslhmjZaOZm5TYqS78EJDFrgG2XMBF6jrwRuiEw0S+N5ugUL+khuvxTbmCok+uYRLMZhf3If7VjZIiUm1cSqCLpx9VSmM7sqeg3S2pdYuDz756RNm5YGgvuxEPApbTzRfQbkJzkTKi0eR8triXEF/hn/6ZUqYLFQw5agLOEtXwOGv3RsOmDc/yl5RZhyv9AmyBs5PVAjmYGUIcCiP5hIzk4Y464WGv5WpPluH/PHv4URagUHSyFwOrb+zw64jSNnX1iOfPQDZhFdnty5RlfLNcwD1sLEM9+vwbK7sr1a/O0gxpYmopRtJls59B3nP/O0lZuNt7RGM1OFsCO0lVMmdVuo5dlP1HMuf25TzS7rVa5r03dwdGlhbjIk6wwpTrV9DTYqqtQvk60NjDJTLNtuCrEeeOeXFNQTP7J+qIIpKMGqfI0DE6sz/gBU3zd6ezW hizMF5zt khFcm7quunp4TcL8reWql24fKVNWECz5lIMdBRKSLvsw2wIM8a542youBS4FwY5H/NW6gf/kFQKksHXdLZg5THECeO33L4ZS6tpGsuPvW39iqkQQ6fxkcZ3a5VmgvzXfnFKXk9/++PMxJ38OEC8GNnLgkMRORvoC1zg8zihnxAQxU31M+XUhsCUnvXxQyS83Yq6MbNHQDxWO3hd4cBJCaPECvRz3CQMGUFTh3hi1iTtoRpNngahJXD1UcztcpfDIZwxpiw3X1fbtNYrtlzW34e134Qjrj9ELHXSqtq45heBaEWURj1RzGDOGB8iJRmhrfse0iI8Ga4OSUDfB667jaS0ZBNB/EW3i+xIl/UkmojPH3uWArc36PB1l9lMUAp/MXYd/mSC48zUExdPOhUWDn0ux4YAQxs/yOdIGVXa4T+4O/cBkTNmTvjwA4583wxDiql7C19YgBA23q90kXMrOrDBADh9ji4uFhnZRsLQu1WHtblqvSccDyVZcNbiygCvr7pYaRQyWgGp6WQ1axWV+VlNgZ4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 1, 2023 at 5:57 AM Jiri Olsa wrote: > > hi, > we have a use cases for bpf programs to use binary file's build id. > > After some attempts to add helpers/kfuncs [1] [2] Andrii had an idea [3] > to store build id directly in the file object. That would solve our use > case and might be beneficial for other profiling/tracing use cases with > bpf programs. > > This RFC patchset adds new config CONFIG_FILE_BUILD_ID option, which adds > build id object pointer to the file object when enabled. The build id is > read/populated when the file is mmap-ed. > > I also added bpf and perf changes that would benefit from this. > > I'm not sure what's the policy on adding stuff to file object, so apologies > if that's out of line. I'm open to any feedback or suggestions if there's > better place or way to do this. struct file represents all files while build_id is for executables only, and not all executables, but those currently running, so I think it's cleaner to put it into vm_area_struct.