From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD18C83F17 for ; Thu, 10 Jul 2025 00:40:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DC746B0099; Wed, 9 Jul 2025 20:40:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B41D6B009A; Wed, 9 Jul 2025 20:40:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A3266B009B; Wed, 9 Jul 2025 20:40:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E92196B0099 for ; Wed, 9 Jul 2025 20:40:02 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9BC711A01F9 for ; Thu, 10 Jul 2025 00:40:02 +0000 (UTC) X-FDA: 83646497844.19.EC820A2 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by imf09.hostedemail.com (Postfix) with ESMTP id A3D4D140010 for ; Thu, 10 Jul 2025 00:40:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CWJkXpKP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752108000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8+EH9We4Q8uZNtUfBicIKlMK3P33lcOOMogm1wF7Hgw=; b=wkDxKapbWYbelIiUBoTuufolVGK699PStW6bO7uOOQqPApRELtp4pNJr+3zzNXSYG/Kw8Z +fEL+tL3pyQzLGAAawOdIpCs8A7k12MPz6yCb7WN9aoVgF10GTwbvKQABBg72ZoMZZ97sj MCMY4j3hkYxH4IW6khkRAEawzHMKOss= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CWJkXpKP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752108000; a=rsa-sha256; cv=none; b=hhmkVqx4Mu43mjbWyvj/Jz+nXHjRkRS7vG7Xy40XaZue7RxD/ky7hUh7HymW8oh6GtTFja Jtt7Xkk9+o0YmXZHFBh2jrHrKpfGG3mwvZK8Bh+i6Ht7Xli8Oh5B3iSys0pxV9LvcBvj+C m4Be2Ir128b5XWbw8ZI38ni/2gYicXc= Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3b5e6bfb427so253469f8f.2 for ; Wed, 09 Jul 2025 17:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752107999; x=1752712799; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8+EH9We4Q8uZNtUfBicIKlMK3P33lcOOMogm1wF7Hgw=; b=CWJkXpKPIivF1E0Ip4sF1opixT5DlT9oosjzxv5x/KSB1Pq26yHA73j+hgLf1LzX+p H8NJafUg8ZxSTKk0snm/pZPbi/Jkc5q+rYa92rz7XB1l25aE6OyabZ4xOn7uAbcbMyCj nahpq5LcnqUIKRgE8q/MbMR/fYm96UNWd9nmDewVaAuw7OTyzrPo74+FKrobAzgeQKCq upRwP8RgaZT4MTaQ5qRDDlBqTWQHOvi1Ff2AXL/ybwNZPSG8S8v7I3AQ6m1/PkTzsef/ /WSooxGrlJ9O9hamy2gw0klDGgwxSZnZcohpMi/4OhRoyMRGI0r6XDOPaLBsQC3e2iYn yufg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752107999; x=1752712799; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8+EH9We4Q8uZNtUfBicIKlMK3P33lcOOMogm1wF7Hgw=; b=LbCqMFW3u5+rfjeabH6oCihUBWONa6hSeUeNRoBuM05w8TEHy8DDqlW6AxAPvy3Axm Ai1T5j8qnblm4MJ8hzcz070BQns0FHwzg/G4bViP9RykwAg+bn4Zf8TCGbRfahZXfw27 9cZATVSdWdND74t/fT/EROyMAM0pzPyY2SSf0qlW+erRsXRb/1YiLgZ4F1gSCtQger7J HA21kQ2S7dvQzAuGDMJv8ZTbleLrQY4WXMzaU9U+myP2wtVmIIosEoV42x+zLTRQylbG rJUgHZiLoiXf1cVAkDVxgM8pgRoo68fC7Kce5acoNpGGc19d08ERLEhEbPZTiLLouiUY AqCg== X-Forwarded-Encrypted: i=1; AJvYcCX74nck8kVB2EPZ9YQFxLObw2YGWPe/pIM8VstQI+gEczKaJy4Nr31wnD6eO69PS+EdOhU0zxmQNg==@kvack.org X-Gm-Message-State: AOJu0YxS6CxL2cyd+kZ6jzIq/5bwHT4qUHZuMgZ/gTuluJOCeQ5PuP9U fP4B4cQGTdwUXbu2URBy56f5VvKZI9dEtgka2hRNHcyiunF+A4pmiKP0gNo2QzoBS9NGXvITSZf ZCYWSnuKbMXo7vX2ATzRBXoWmvecWWnw= X-Gm-Gg: ASbGncv/j9cLBN48w3UrxK/7tlZYXPIdp8tnbncx8uKA0WbBALgmXp62/4tmryy5co9 +nlXUQrbpC31GLhS/1k7a/zq6IhtNUi36SfOcJrFgtNTSpbL1EKktIwUyQBghMWQnm5Lj2UUTdq dSJUF9dBDKjBeiQGVH58h3o124xVOYkmb+A9VIDo3FawMrlMKxgorjlM/gYwf7Z5a7IUReBH0T X-Google-Smtp-Source: AGHT+IGl307g/Cb4M8ys7xRkMqsB4P7qgaJ2qzazbro0cQv4i2hb8605y1TULKlRw0ArBOPaqrTdi/ue/nQVGUiy4P4= X-Received: by 2002:a5d:64ef:0:b0:3a4:f7e6:284b with SMTP id ffacd0b85a97d-3b5e788110cmr2130070f8f.10.1752107998781; Wed, 09 Jul 2025 17:39:58 -0700 (PDT) MIME-Version: 1.0 References: <20250709172345.1031907-1-vitaly.wool@konsulko.se> <20250709172416.1031970-1-vitaly.wool@konsulko.se> <14b08e7c-c2e8-435c-a1dd-bd51cfb42060@kernel.org> In-Reply-To: From: Alexei Starovoitov Date: Wed, 9 Jul 2025 17:39:47 -0700 X-Gm-Features: Ac12FXyQfyO3szxMDVVNHvlOhNb_Gbvf_td5xMFONVF3fAKwKJRT2QZYiRmaY0s Message-ID: Subject: Re: [PATCH v12 1/4] mm/vmalloc: allow to set node and align in vrealloc To: Danilo Krummrich Cc: Vitaly Wool , linux-mm , Andrew Morton , LKML , Uladzislau Rezki , Alice Ryhl , Vlastimil Babka , rust-for-linux , Lorenzo Stoakes , "Liam R . Howlett" , Kent Overstreet , linux-bcachefs@vger.kernel.org, bpf , Herbert Xu , Jann Horn , Pedro Falcato Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A3D4D140010 X-Stat-Signature: cyobu1grtdojgg86tqrc9odx4an5nqwt X-Rspam-User: X-HE-Tag: 1752108000-459510 X-HE-Meta: U2FsdGVkX1+f4HAaVnXcfkXODV0l5apXv85uEx7Ty9SDrJwgi+3G9JIWo85NguQLZ6a+BOHIrtEC5YiOYqtfUKsuZE1HS3AXXueia4zDa5w2MSuYOTJJKnzTl71BEkjBIY04WMhnlAPrsksc/cCdKxKiqiT15FAEv7oRnDmG6XR8BmaF/ANctTnOkfBVvAsl6KD2M2C1FviaDNd7ggD27+Uj+qy6VuOatW64gQdvnMYVVVRRiOsnohlXkzX7TOQuMKMwRFHJ3t4bX/qjUkmdFUjexWxD0FA1xP8m3QOEFLbUBHH/2Zakciru+aWtPXDGEY/pT9ZqVfzNH5WY6ynJUcAoRzxN1pq2xxx83BPVKB2ZiDFVZjLphortKYaIOumsp0qWakVGdqGt6QVxt1rD8LJxY0AEs8LrdVkQJSwYl7VyNv3bdHGO+DAMbc+8EXWkKvj5lp3N0qOH4yed37uE2XAs5QKLYGoPaLfZzme9mSO7f88QepsqwETYpjXIICYG4393pGaArv5426fUFr5ow1V17wG30ORRTiLKP+7jzLbTlaCf48SJRr+gQg2TUvUe81rwY8mIuiekTBI4AffqpUGGQnNNOOt6tj+tdpgZrHBH8ZwfQHeYw6g2rwGi4KD5TSAs1gSNG3teTPI3Tg5nx/raxE0G38IuNpwTGBNOFbLwAljknveTleIjXaNqzf8ddAYrlcAvxB4V6bCLNifXQWVhEdluuSHT0jztnD/ZmIZUWz/VEe6RAOsOJiXNkMDYx00jlxOtD20GpvujEy0nU6lLDWSKe/cZBrVjgdtObHDZqH7UFLM+cVEfGnzZPwihnkJcjGt+L/B6dQNmm1Af6/ud6xXCqZjYOW3k04qRgXw0xwlqin7/MgvH3WnV+uRI78sOmlgxut4UGKg5CkFX8xodkeag332VBtfmSpUCm6h/lw9pcO6XanEjlv17WsJg0jkEdfoWsAJwceS95E8 Fw+84BkA 0M5MNwAuhJ92wsUGdYRXk6KTE+hfwFqD7ZakyOA8RH1XgzPXy/bh6nyOdioZJfqSwbqsOo0sU+OSYl+/5uex0sKfp4FE8lcBCdyfEUrdvDEi2bvazUyW5+ywTzU8i3txciGibCaIvQIa2RpHWfbYqPtEZkCGnxAAhEdHmK4xXFf3KGR7FTcDO/O6o9JwMtRIjYu3L5UEMhe1Za8l5J8NvikhEkBvJoEsYmnnrgTMS1Q337FbE6yNKNqn//NEQmiJnn9C8q5gkoglcxgaBF3P8UsfiytGsyVvWpJDh0oedBtcG8Fw+XD8OFkHh44i42AIuu4syN8lKh+CFwUuz+Jht9wuhdJjGkbDzskMIwSXCYdT9fA2Y/qs69k22pA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 9, 2025 at 4:26=E2=80=AFPM Danilo Krummrich w= rote: > > On Thu Jul 10, 2025 at 1:14 AM CEST, Alexei Starovoitov wrote: > > On Wed, Jul 9, 2025 at 3:57=E2=80=AFPM Danilo Krummrich wrote: > >> > >> On 7/10/25 12:53 AM, Alexei Starovoitov wrote: > >> > On Wed, Jul 9, 2025 at 10:25=E2=80=AFAM Vitaly Wool wrote: > >> >> > >> >> > >> >> -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > >> >> +void *vrealloc_node_align_noprof(const void *p, size_t size, unsig= ned long align, > >> >> + gfp_t flags, int node) > >> >> { > >> > > >> > imo this is a silly pattern to rename functions because they > >> > got new arguments. > >> > The names of the args are clear enough "align" and "node". > >> > I see no point in adding the same suffixes to a function name. > >> > In the future this function will receive another argument and > >> > the function would be renamed again?! > >> > "_noprof" suffix makes sense, since it's there for alloc_hooks, > >> > but "_node_align_" is unnecessary. > >> > >> Do you have an alternative proposal given that we also have vrealloc()= and > >> vrealloc_node()? > > > > vrealloc_node()?! There is no such thing in the tree. > > There are various k[zm]alloc_node() which are artifacts of the past > > when NUMA just appeared and people cared about CONFIG_NUMA vs not. > > Nowadays NUMA is everywhere and any new code must support NUMA > > from the start. Hence no point in carrying old baggage and obsolete nam= es. > > This patch adds it; do you suggest to redefine vrealloc_noprof() to take = align > and nid? If we don't mind being inconsistent with krealloc_noprof() and > kvrealloc_noprof() that's fine I guess. > > FWIW, I prefer consistency. What inconsistency are you talking about? That krealloc_noprof(const void *p, size_t new_size, gfp_t flags) and vrealloc_noprof(const void *p, size_t size, unsigned long align, gfp_t flags, int node) have different number of arguments?! See: alloc_pages_noprof(gfp_t gfp, unsigned int order); __alloc_pages_noprof(gfp_t gfp, unsigned int order, int preferred_nid, nodemask_t *nodemask); Adding double underscore to keep all existing callers of vrealloc_noprof() without changes and do: vrealloc_noprof(const void *p, size_t size, gfp_t flags); __vrealloc_noprof(const void *p, size_t size, unsigned long align, gfp_t flags, int node); is fine and consistent with how things were done in the past, but adding "_node_align_" to the function name and code churn to all callsites is a cargo cult.