From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA0B1C48260 for ; Thu, 8 Feb 2024 18:59:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DAA06B00A2; Thu, 8 Feb 2024 13:59:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 38A866B00A3; Thu, 8 Feb 2024 13:59:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 252256B00A4; Thu, 8 Feb 2024 13:59:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1580C6B00A2 for ; Thu, 8 Feb 2024 13:59:50 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D4A53120F09 for ; Thu, 8 Feb 2024 18:59:49 +0000 (UTC) X-FDA: 81769550898.13.6DCD40E Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf23.hostedemail.com (Postfix) with ESMTP id 0DEA7140021 for ; Thu, 8 Feb 2024 18:59:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cws2xQEX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707418788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vxENL0d9cN+r2jFXWcDqh1BfTN+NV64aEboOi7cVLpo=; b=Ep0RGNT9fRiiJA5m4NEDg4MGBr3lLSlqBKNeTDUgQnFJYyI8I7mlEAIywV/L2K8aB2rf+8 4cFK4Py707LvTbhexRLtftHtU+c4UPAOZdFg49wxCS4TUSBebKsiE4pFrvqvDKeNT7T7v0 nHXs6MZlWNz2x/00j3rTMV+JksNkv0k= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cws2xQEX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707418788; a=rsa-sha256; cv=none; b=EyBsicpnFpQ8M2gzgUpxpgD0qSkcJa0PgfQDdibovH/6CQjNePnV7bv4dYNxtGl//zjWu0 bHOqoLo4IFZQI4VJGjun7ev3Wwv4e7eO0FRjha8/Jrvq+GQ0EWPfmAn93Oi8x1WLAHvnJU B4fpBAXkmcPDs3VejeSyGvMcRZZDzCI= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-410504b5cf3so1450265e9.2 for ; Thu, 08 Feb 2024 10:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707418786; x=1708023586; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vxENL0d9cN+r2jFXWcDqh1BfTN+NV64aEboOi7cVLpo=; b=cws2xQEXFtNtDaBqlkrOVBXlb+dDUs6/ZckRFbjzSCSCs7oP7SStrotPBaQ74nBXMJ mvdiCQ8tkpTrE9OoSXgDjY7LIHxRW2iKepRbhq/cbc3IBY0SuxDeJwgGTec8mEJb8LhG csirpbyc9+JdLWsDDeqIj99LzggRk2Sh4tFaTI01/ekitA2xrSH+/JcHcfamr29fu7AS sveg88TMZ3AerGyCbfRQyMVjequVGrlknUMMA+2CTszfKrg2Fndmy+2WDqqI3qzqkFGE YzZp0XK2CZf/3CgPgFZVtYz8u3A1QfOf7H2lsLPO4thbQw/+ft6Hy9wuas0h4IrGulzB c5lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707418786; x=1708023586; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vxENL0d9cN+r2jFXWcDqh1BfTN+NV64aEboOi7cVLpo=; b=Tf7xXYqFarcgHa3P103Xn6xLSTDjL1njyw5NLT4nWbH+ffPPi3sL4Qr8eMHaDcBJLv BnCC4IMU0v07+hkRgUNAcsghOg0hzIk/S3gCe20CPzHAK02l+dY/DjqXKLkSCDfCs4Sa YW8DzZVqzIZKwj9i3HD3PpfDf5Wk/cWMfG21QAtiXg1xULjz4otazCaGwWePqeUI3hV5 QUOx8pGfXpaCtZ27RzZcnq+71S1iYgmjBiSPPUPG6LdExEZFbpQlzOxHWv2LY5DkpwTg pEZQHDV3EHk0aSNfwOdEzzigmyfkktT19TbMRPtI58iZRJvepmLpUrB0e4Pw8awUOzxW Ijxg== X-Gm-Message-State: AOJu0YwPAwFPXDLcfVSuZJhkNJdeDUGik0vg5kPKADBwbf2ZCoRc9pXl eOoNfPgY97UM8jLLNAO+2JLamJzVq9sMlGEnujUphaMVYemVeqem4XaZLb7NAJJYf+C40q5pq4f NbIXc6knlved3OE4spMp3ZpRoEZY= X-Google-Smtp-Source: AGHT+IHOKM+3T7heH6HaJcCg5VQj0kMASUUJP0X3sSgUsT8CpOvInoW0RNEAba23NWfO/xn+waAhMbiODjnr0WIkkBQ= X-Received: by 2002:a5d:4561:0:b0:33a:ed85:f232 with SMTP id a1-20020a5d4561000000b0033aed85f232mr256566wrc.56.1707418786405; Thu, 08 Feb 2024 10:59:46 -0800 (PST) MIME-Version: 1.0 References: <20240206220441.38311-1-alexei.starovoitov@gmail.com> <20240206220441.38311-12-alexei.starovoitov@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Thu, 8 Feb 2024 10:59:35 -0800 Message-ID: Subject: Re: [PATCH bpf-next 11/16] libbpf: Add support for bpf_arena. To: Andrii Nakryiko Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Kumar Kartikeya Dwivedi , Eddy Z , Tejun Heo , Barret Rhoden , Johannes Weiner , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0DEA7140021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: e976bqma35a6gyrtie4sufkgc8itafn1 X-HE-Tag: 1707418787-888244 X-HE-Meta: U2FsdGVkX18pSHXMaVCnuXWPG0QvhxMdMOjrXorRguqCWFPqTkuTn4lOpukW8to+1E9rBDszNmM6Qvqy4ZkSsvUpHVSKul3oHb6CNpRbt3tQjw8fWGLf9eZxx+kJm/9+xuGtJy6kPbCnIruchr02ChCtSy24sfP2Jhq7NIKuwoVSBFvLEYBd84KllF2n2atPq4Bwo0Gr+G7ZJe0TMl2Qu45LN/a2CGtA3z+vk9JXHre94iI6fY3fQpCPkB6WC8LJfuQJW7oorDp+MTRU8VquscY5NkgdTqMg0xUn4oy0xDTapYFf2ILfi5rUnkyOScmxvg9TnjoIzBZvqzXZ52+RrdKIZ+9ognDBK/Jc53PLaK//OfigAL0vj1DvZH5izVrl/DtsansmUEG9DVsVlGFdpU6o8o3LueD4khILvcvFst5MQ7BjOyjGWBu9mI6Xk+IddsfLgM8pLqdJB2sJBZNjXy31O0tn3O/83M4H7LbezQKaP2yO5yfAeYJ+napQ1P99hn3MCLbHf7g4O3jM7YQ4J68RhT6cbc9btAl66E8Ko92+6dLA2oGa7jkCm9fvPIG+YeOxoEvcYi2NA/9wDMwDqHv0LqIG531649W3Er4QrFiy6xAVAfrOzRYGMdGlYistqIkJ9aCC31uQ/Cd0WpyfgUT5Absjye9NilboB5dsoGmHKnV9urY7L+cBFLBmq7AlaUdPK69ermSMTd1S0xtyyRLSPoz5L+aqo9JI3ps9UfNpYEpbVkwRcTo5DKykuqoCeJzvT7EoZSq2YhpdAxZQJc0YVCyrsKFgazsdooRDHTgVuK2DDZFzItwfP9FaJ45iuT9Mwdev2s9p3sJq14s86qiD18t/cNBLwwnvz6tR94RsQ54lQmLAOqgjj/YWJEXue5MRIlFk5q0TUGXdx/CDKncnfj81jeqZFwEEDPhRJcHkoNh2d3iN4HD44TWDfCxYWqd1a2DkMrb5c4TDFxk T5iJlLUl 3eFPFGx9hDnkL/oSxHrjwAg+tuE3qIwbDEO93LlBqbjNOSNksuHYGJQUHFUkNaHELXvpFIiwgoegczucic1RbvZ8k8XVtYhPkM6GFQGA6EDQeTIrVfAow49sebw5VExN6l1q4nWFQVr4WeueqPvViqpaAlqAWrKidyinqTsvw5x4FYRlW8lPxJfHApeEtbHYTsStDmubEIR3zquqvD8bSnz/ehFQf3YSeJO30AruMTu+b3fVUcwPJZm/0T6UTfmP+qBLEyuE6/vZj8vzytKQHTgnaFcIF8/PhRD6bGmajiDKj7GtiMnQmn8ru26F1tSHFksOB8herQhwiEVoxiVGR8Pi4vL9f5VFiFiPq9FCEPWKYEMw+l8Qg7LxPcNXKVAbLGiFE0t81UdYcJiD9MTAVIEYQy414NEUiXP15nBM2Wu0cF9oJWigdmaVNqJJAdiQEDzceFtO0PqV7p5yGtl9BQU4a2IjFNLuxUZz68T1kZ6sWaSE0n2+P/vPdx3TfDwhTwLW5kOrwjRK7HXE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002827, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 8, 2024 at 10:55=E2=80=AFAM Andrii Nakryiko wrote: > > You mean when doing this from SYSCALL program? both. regular syscall too. > > > > Looks like we have fixes to do anyway :( > > Yeah, it's kind of weird to first read key/value "memory", and then > getting -ENOTSUP for maps that don't support lookup/update. We should > error out sooner. it's all over the place. Probably better to hack bpf_map_value_size() to never return 0.