From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD060E7717D for ; Thu, 12 Dec 2024 02:54:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24F176B0096; Wed, 11 Dec 2024 21:54:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FF336B0098; Wed, 11 Dec 2024 21:54:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C7426B0099; Wed, 11 Dec 2024 21:54:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E205F6B0096 for ; Wed, 11 Dec 2024 21:54:23 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 931311218BB for ; Thu, 12 Dec 2024 02:54:23 +0000 (UTC) X-FDA: 82884787608.21.31BC645 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf06.hostedemail.com (Postfix) with ESMTP id F20B418000C for ; Thu, 12 Dec 2024 02:54:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=byrFPT6H; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733972039; a=rsa-sha256; cv=none; b=ZkZjGmc8Y1pz3q85Kf/RztG6wQbjOiHQiKnEGWmBxq4ZCno4x/k4H6Tlit1K61SGN0FBpd k+6UcXwwPZyxCAO44YaBUBKnqacjWqi3qb2ZVOVrqd1OIiGDm9s3BrWMvw21nLDfnMcQ2L XC/v3W46Gic3rv93IMn7Vvip1pniPRE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=byrFPT6H; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733972039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GuUpultjiUdSGlOAoGGhf3Vwl8gCSGudmc5zGD/Ot3c=; b=2uFjEwk9Sl8pUznh6glQ82qOX/AzMSVbhEjXb5WGjnH3yV4uJyyewnFmp0yq8oqnR+caHz eUDmUMnsEN4syoZQe50eK7h6+v+R+3Yx2CG9KMgjSZWywfFfeJTZS3BegokyG/cwBARAvY LeT5jWTrfkH56xXX0YeTDHyk5XWWBYo= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3862d6d5765so43133f8f.3 for ; Wed, 11 Dec 2024 18:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733972060; x=1734576860; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GuUpultjiUdSGlOAoGGhf3Vwl8gCSGudmc5zGD/Ot3c=; b=byrFPT6H9ZQRzzFWJyqMcyEJYmK94jdZnhQ54TmTEnBgoAaEmYviuIaS9z0SjB+XTm L0OsYMHtaZ00EVPkze7sXRocJhCxDMuG4skFvfmTSRkypZ8hBw9VU3BtksHijhZ8CYEV 7a/uyJt+GFt1qT5OHYzJX9rOfpPcmFA+8B+TCNlvpMR3NrC8PyB0e9hEfoyyixGFkZg/ QfbLtJDTzLCdMDp60Ox1JeV1ILkICjYLoChu074TZcq8Stn47ZIlR6H5Yp4jMQ+MsEjj oq6JMpUXCzsmlGEv+FM5tAENGPxBXgPxkdFfcwxtGZdCEQhDYlZH5Il9tRn4TLuA15fh dpXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733972060; x=1734576860; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GuUpultjiUdSGlOAoGGhf3Vwl8gCSGudmc5zGD/Ot3c=; b=n4xIZcaxDCm55KW5GIT23IArG61RtxAGfHNe01wix9M3OovnAioSLMR4afKNXqhGUW 6vUPq78IKBBOQFHWKcsSAe3/vaxJhM3at7CySlNV6XglTeInAkSHBDSW4Yc71mghMik8 FM1CGeH24fLqp1uPvoFw+Chn67YEuukkLN6BZOyRrReUc0Mz7tkVXOIIAadVpx9ehWVa a97xjjSfzPJrDv0/G7JNmX1GJ5xjpe1dSDj2aUZPrU+RJuFFSl7Tl//kZ0/IxudE5JR4 Lm74KLKX8z5XAk6j7mT44EQGaW3ZnfVzdLe5ED/19HGc23tKKdZmiDBXTlaJpti89Oc4 8+vg== X-Forwarded-Encrypted: i=1; AJvYcCWgzjZ5yjURltwWs4XYyA1LibXjgZFR6MRsOd5FGzHZx1wAuqVT9jjGDK9StJJN4KoONwW2sGW9qg==@kvack.org X-Gm-Message-State: AOJu0YzNXqxkVomT5tKJhC7g8/s7m2/J6kCCq5MNwxv4YsEHE5BDe3k2 383aRmA6xaJ2vLZGKpJkOj9xMmqgiL+7l9a+N9aU2dMgD80YEuzq3xG9yojOEX869hXe9IA+O4z tMNiJ65V6PwRhSXR2a3nsAHjaycg= X-Gm-Gg: ASbGncuKedl2YGCOx4aE3H8BAG6MaWaaavwqbCQy6ug/bNNyYbBruFNKe39zTmy+EWK KlKHVpkj86LHXsMnaCN3PVLQ36BcATUGglTfqoEnoB68/ZcS/hJktBQ== X-Google-Smtp-Source: AGHT+IGuPbV8RFNbEtoMp5mGkiWjLLghcjXRYcNsjqQuwwA9kDP5s2oQrYo0LDLuWqojHpATwgHtSG8qbjW5lC77hHk= X-Received: by 2002:a5d:6c64:0:b0:385:f47a:e9d1 with SMTP id ffacd0b85a97d-3864ce541f5mr3934608f8f.17.1733972060348; Wed, 11 Dec 2024 18:54:20 -0800 (PST) MIME-Version: 1.0 References: <20241210023936.46871-1-alexei.starovoitov@gmail.com> <20241210023936.46871-6-alexei.starovoitov@gmail.com> <4233d087-4610-475e-bc79-14feaf2f7cfd@suse.cz> In-Reply-To: <4233d087-4610-475e-bc79-14feaf2f7cfd@suse.cz> From: Alexei Starovoitov Date: Wed, 11 Dec 2024 18:54:09 -0800 Message-ID: Subject: Re: [PATCH bpf-next v2 5/6] mm, bpf: Use __GFP_ACCOUNT in try_alloc_pages(). To: Vlastimil Babka Cc: bpf , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Sebastian Sewior , Steven Rostedt , Hou Tao , Johannes Weiner , shakeel.butt@linux.dev, Michal Hocko , Matthew Wilcox , Thomas Gleixner , Tejun Heo , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F20B418000C X-Stat-Signature: tuyt36iurrek6pwascq6jeithy1ibui8 X-Rspam-User: X-HE-Tag: 1733972044-308403 X-HE-Meta: U2FsdGVkX18i+z9vrjhoM/x3HFdsBABVhHZvOn6+dvMUU50J5kHKlr1JfoobL4SLtNQjRkw5H08c1UtxNlM+AY9n0DAgxsg11zuB6yo9cEV/fr49LS0kFO3MhLi82Pf85lb+0wsHMRYr7aICt5MaWRBEqgENnuIU6Ie0Nv/Up4D+BQ+C7bUcgRC89mVE7RqIxaW2+g1DQ6fzAuqzrtmwujnGAgxPpmxjCcgyEM+Ew498D2dwaI7vww6T2h+62u8n6r2WF3qibqIlKlinYqEHHKWO29mov/xDdbfkyiPYvFlNnjcK4O39ePT++skprXwYJlk64HO08NUeFuATsSZm/c9XL6bL+bO8tnMs3f7IpH2UlSsB6/TY+4w6+2xtyQQcPBkpEOSX8EunHykEOt2ZzP+D263OIcUsR0/bSdsf5DA0LAmpDtl6GbuDuimnkljnlS2zNAflWux+l04FldQPlQKvt1402E+36hNHBG+JTePEyvhCt3LOavSRYtfPgVz259dDCuXkPeUr+e4NSQo5c4zD9YFX9/hcLHK00wYop2neAN/z3HP5CZoG3I8129tcTn7OyNHzm3CsCzUX0zEQZKdCcY+myBdHRXUfwJLngpxLDXSzrmfMEaBo1rCdn9LxRkCsttswBJvz4vAqpRFZrg592//JvVU9a0uV/bh2on4KbQr5pin92ws4hFC980I872pEURmj2nznCm02AZ0SnskKqpsVjzlGerZj/Wnwmy6BMAXET296IEw9fiQk9F7qqOix2EVRQOYaFB/PjY6B2NANDIJPT4XeJ103MGelwzN5u9PRbBJ/9x1w6ZcLUMbArapP1KBYD3QggLu/igdM8feypW1UT3QW1FSaQc2rPSPUBAXGmIXB/ekPrqGKxtFzuVBqML2zy6XwBYLpvGiCA9Avzg8s3zSfbW4fpmxYEURiZPF+B5aVqPyfhg9sVvomKYWucSAI6hrL7nvzfJm z3yX9lWc /ASpSxQs4RWJRkseRuxa31ouCWsHAmWTbLutHinCQ3eYBBXQHZpkGBS0y2A/vU9GFHHAP8y+FOTYnpJisaMtxel8nRqK4me5XdFY3f3WvbNPSuCAIGeioD8zWvkxJ2wi3/Hf2brtyWonlb2mTk6HrzUu0w0x+Th9e/cgim45Ee5ClOQrMrlPKiJgfPO7VB9/x9z3n/ESj7M1UnTdffPRpSFPiS0zkl/+R4BMtvrH2iP17I6/oMqLr8mKXBeqCeyXE2Uwoi++MP56txQ+HlYljja+hwiWOR1IcrD1qryCSqUwB3/8n7Mss51KGCfamWvPIAMS58Mb/DcP26+BvhP7LiVb/y36bpzPgcOUDUxOR8u4UTKS+GV3g/8jAwLJRQ0igLKxPdl9WefDs8E/OtPiY+AO/+49CE9TuEKUtILKgZMyH3UzoRcHJaPNKN6P5S8Wf17yG X-Bogosity: Ham, tests=bogofilter, spamicity=0.024992, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 4:05=E2=80=AFAM Vlastimil Babka wr= ote: > > On 12/10/24 03:39, Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > > > Unconditionally use __GFP_ACCOUNT in try_alloc_pages(). > > The caller is responsible to setup memcg correctly. > > All BPF memory accounting is memcg based. > > Hm I guess if there was later another user besides bpf that didn't want > memcg for some reason, a variant of the function (or a bool param, to avo= id > passing full gfp param which would be thrown away besides __GFP_ACCOUNT) > could be easily created. Let's cross that bridge when we get there. tbh the code that doesn't play nice with memcg should be shamed. I think CONFIG_MEMCG should disappear and become a default.