From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Harry Yoo <harry.yoo@oracle.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] slab: fix slab accounting imbalance due to defer_deactivate_slab()
Date: Fri, 24 Oct 2025 11:08:51 -0700 [thread overview]
Message-ID: <CAADnVQ+H+VLFROjJJYkbaT6ED_ecFzu4eLci1oP9C0kDp7Aa9Q@mail.gmail.com> (raw)
In-Reply-To: <aPtIqm3LaRfCVQ8L@hyeyoo>
On Fri, Oct 24, 2025 at 2:36 AM Harry Yoo <harry.yoo@oracle.com> wrote:
>
> >
> > Note that deactivate_slab() contains VM_BUG_ON(!old.frozen);
> > we would have seen this triggered if we were passing unfrozen slabs to
> > (defer_)deactivate_slab(). I assume it's also why the "unlucky, discard"
> > code marks it frozen before calling defer_deactivate_slab() (and this patch
> > removes that).
Yes, exactly, since that's what deactivate_slab() wants to see.
> > So I think we're fine?
>
> Yes.
All my concerns were answered. I guess I understand it enough now to:
Acked-by: Alexei Starovoitov <ast@kernel.org>
prev parent reply other threads:[~2025-10-24 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 12:01 Vlastimil Babka
2025-10-23 12:56 ` Harry Yoo
2025-10-23 23:13 ` Alexei Starovoitov
2025-10-24 0:00 ` Harry Yoo
2025-10-24 1:17 ` Alexei Starovoitov
2025-10-24 2:03 ` Harry Yoo
2025-10-24 8:55 ` Vlastimil Babka
2025-10-24 9:36 ` Harry Yoo
2025-10-24 18:08 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQ+H+VLFROjJJYkbaT6ED_ecFzu4eLci1oP9C0kDp7Aa9Q@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox