From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD30C5AD49 for ; Fri, 6 Jun 2025 16:39:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C731A6B0089; Fri, 6 Jun 2025 12:39:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFC906B008C; Fri, 6 Jun 2025 12:39:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AED876B0092; Fri, 6 Jun 2025 12:39:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8CF2A6B0089 for ; Fri, 6 Jun 2025 12:39:29 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 295DE80381 for ; Fri, 6 Jun 2025 16:39:29 +0000 (UTC) X-FDA: 83525536458.12.3575A5B Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf27.hostedemail.com (Postfix) with ESMTP id 344DC40002 for ; Fri, 6 Jun 2025 16:39:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nznu3Wdr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749227967; a=rsa-sha256; cv=none; b=fvzLk3ebcG9+2jl0l374Xw+gwh7zW6TO/qKW+SHzLUqZITvEJBv6W3OLN26u5d+OjfnMh7 CWF9mRCcQabWlQRxn4TrjF28p8g8gwNcVXTTc0YzRTlGtikv8Sr59cKCtccSWSp32IMN9g 9NDf3XRfNt1k00awwRL1hJ8V2HpJkbw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nznu3Wdr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749227967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xG9ePX+hhlM2ioCU4Dn4OhL+GFgr0KjnNhY43k95Q7M=; b=O3KtZHec0rQCHRTQUaysU39GmUb95zrINiH4eTU1qmXsAjAaii4YZWPBGNtGgEsnYApg2T wF14hhvKwz3sZe6YH+q8DsVOeJQd23AkNZfnDZQ/Gzf/f9lYDnJPDAnC095BmXkbZVx4K6 1OC0jDB6Vqicux/QIsOQp+fKlSJYWnA= Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3a4f379662cso1977608f8f.0 for ; Fri, 06 Jun 2025 09:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749227966; x=1749832766; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xG9ePX+hhlM2ioCU4Dn4OhL+GFgr0KjnNhY43k95Q7M=; b=Nznu3WdrC0avfP9hTknIKaKjx7lJptcovoi9GjUx3Z2a6XXZR4uCpNeyPPasLkxz27 UER5lfh6kGSWGfnueUdxl7jmksBfChWNAZjYtC+5UBs2qCVNujSOjWQDx31I6vSSj0SZ 0nEJ/YlP6OhlRY3lIkhjyyWqcPjCf249iDPGrFulwnUlqA1HbuwRoHhhYb8HFX6BX5vb 0bgBQzzODlJfgbo/kcVb5eRzsgM2VpqteXhpfhkgBHNzoTpsN//I0y0nBSA7HaP7NcnE /2W+N//QEX7FXwodltpg24IPeLnuwGxzxAyRAfCPRn9TTod3wmmY/mW0S6WyaaAtzSrA +i/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749227966; x=1749832766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xG9ePX+hhlM2ioCU4Dn4OhL+GFgr0KjnNhY43k95Q7M=; b=oIhj0ABjGQwE9VLaXllX4/VUbWDkUtuCYSz2jUgWsnCf3DUTBmTwM4BHjFWzZ2uItT 0Nrar7Vid+J2tNFZ/fqkmOS3CGSRuS80I0ISyfotdCWQbEBd2199/7e/E9BJcJUkH7w4 3r3aSHASDfKaGwH9EFXOrapeCnmsdydNRjI7EbB+3InThnKkOvIzkN+UXaJkBGaHlWq7 A0/Tz8dkuQisUA04K3uQZ8XRXMcc0nX7SQbQPof52SZvIodqJeJfHWE+yssg9Ut5hlGd jwg1ICfCDvJXZrY/l44i21HnANoJOGgf1hLxtESETQHwpWWrsTpuT5TcsLZPkMHn3uOg DNBQ== X-Forwarded-Encrypted: i=1; AJvYcCUknFg+mTQVne+wSXCvMQb/aTbV53MTIw1uVZ6wuMCemmiFCAMlsnyC4CIl3wcAADGORfoJY6FMjw==@kvack.org X-Gm-Message-State: AOJu0Yxrs/arHtMD9UVvYtbqsGJnum9qPm2bwOnSXg+NQnhmKME2JX/P QgLKeBwXEx7PbqJWS8A6FeAmfksLrQ89QnTaeRVuhpWgISunrwP8/zYilU+CBJ7/zqsM/U7Gx7s +Ap3pA8X71uXVLkU6Qbdz4Eh3K1GzZ/A= X-Gm-Gg: ASbGncveA216tzqkL6mpjo7g3g34pMRUbDlfGwKU+LJxS+oi6W4ys6ZLWHwKkPosOhm y7CwQxfH6CLwlJQLpkokwZtmlj+B6VfVg0wDYYhoJpNou5VXlh6ORbEdgoUt8HcKCCnJjpWHMe4 eujGR3+9uHN1gRQBw8vG2Vm2SOaqd1sUO6LXEZNfD6HxRtG/+PHA71FT6OqNVm0vCQv5OOLMx4 X-Google-Smtp-Source: AGHT+IHq3315Dn9d+hwBUjw+Kg7LXaNHoxU48aZvD/S6yAkrZn0JTcP080HQQ7KB6Kt2s68Ve/l1xGCfwKScVzLRx+U= X-Received: by 2002:a05:6000:250f:b0:3a4:e7b7:3851 with SMTP id ffacd0b85a97d-3a531cf3622mr3440431f8f.58.1749227965553; Fri, 06 Jun 2025 09:39:25 -0700 (PDT) MIME-Version: 1.0 References: <20250127160709.80604-1-ubizjak@gmail.com> <20250127160709.80604-7-ubizjak@gmail.com> <02c00acd-9518-4371-be2c-eb63e5d11d9c@kernel.org> <9767d411-81dc-491b-b6da-419240065ffe@kernel.org> In-Reply-To: From: Alexei Starovoitov Date: Fri, 6 Jun 2025 09:39:13 -0700 X-Gm-Features: AX0GCFvJ_YDCqF1cB2ZxZ3E0i0bq9e0VCZSctUZEDeWlAKAIlg-aO97Jeml91Fg Message-ID: Subject: Re: Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers] To: Uros Bizjak Cc: Jiri Slaby , Dave Hansen , X86 ML , linux-mm , LKML , linux-bcachefs@vger.kernel.org, linux-arch , Network Development , Nadav Amit , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Brian Gerst , Peter Zijlstra , Shung-Hsi Yu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 344DC40002 X-Stat-Signature: sf6k4capws4hmmogt4kz3kohj96ipi66 X-Rspam-User: X-HE-Tag: 1749227966-113541 X-HE-Meta: U2FsdGVkX1+9nffyVKPhDJzdr3sHSkIo3fAFEpjdWeqHwR0Vz+XisL1dWjZEvbuewFWKa8PserYq04xRRGhuTTlRQPV8lriK/NsQ4MvCVkoqA4zx2vsXzeoWXT6ku1SfPdwi1/e0linn/SFlP4J9f/w/mM9PTxv5pf7wzQnQBU/V+AJGo72ncRExWLtL/zWYXkH/bb3LLUkWGYKpDtyd/yD2IaN8qDlAl9iImOdSHzLRLN9gGIKHkTwsX0bEvnZfmzBAc1IXplw4Y9xeDkK/dZcQuiJHt0OSJBIVkIHULGy3hjLj3eA9fXxFH7w5U98UJGOkzMbFB5F8JiQAkc2hj9obcaQuFGt0/3OeSWHZ186ih0PRz2Fz4IaRfb7WkDJ2oM/XRnZY7n6iT9gGfWwK/UTbmZlTUEc77BdcqMOtZqOh1M+gFQUxRFLokwPWAIpZ/PGoqCpJLqA35wURvyfJvpB26kAAMJEuyTAqNRjI3ic7keODs1ZnT+T+hdvTr+5MAPjf/YeS8JX9U/Kzz+MRw8DECJLRnLL+q+VVS4gxQ+VPPcPiH2jGN/kZfqelZTYsxjqJWxrMylq3IoPjgbrTk2VOl+QTW6v4KtoL77gzaI4h+yYuHUiH/Gox/6DQEhaXcaB8jufTu51deRANxJz64rR7WwrB3n+jlAK3nvlyZ2C27IjvrJ9MPul/LQsOEI0FLG6Tz3CQxgbv1jeiG3jTKXIhUE0S2hhT8h5aETsksQrkrEeoLoWUYS9guh88+UJsn8ErQWWHnHPu1daPbCzKSvzyOirGZDhdFArqoHDLx8KpObCli0V10JTaxk7/nuLsmAYLHoT/Au1ll0XTj1Df9O82AzUx6hSOIjjSzsNgN2c6/dwsBf5RS2EhTasVkqCSD3tXoUaUPtyZq6c9dMK49lcF5je8+LIqhe6xhii7wAS+I7PALdxysGHFmRD/gOS3BYqDSZ65/1jkyq+2z/W FDtXWatY 7lAqpSM9ytyxeNCWAXMXwCKoK3se7jloM2q5SZVHeCYUns71CF/tSVZGYtEJOrKvJ+HvdJ1+gF5s491/0X4x5MFlkdkyvfi91iOpZmYpkVfE5BfipW2I7eDE1nyASFxbi8NV8NUioaJk2mgkPpID4llyZrIduQghtKTd76qlNem4ZnecHmGlX5wK8VIxWvvGJybvStytz0gXIwLaWlJziPAE3XAZWb4Vyi1LWmcBLKB3teKhP2j4LoCvBAC7ESevDSch3mMUYEpBGPsnIIy15yNybtsz1e4/xwCjsMA90uKgZJkysp+jEQQrhCGHBt2juVRPl6Yi0703mj+c9K/gTmaXI4vXIGOiCZ33f1NsfEoG211cMKN/zCGF2E74Z6t6IgAowY6tAArI+pI0V1zF5vpKrzHiBwINmFoZIZF13FpWrU84ObCOKxw3jVUN+sIAAy2OR4UL+Dwuw7ehNWHvBU3XcMyqZSmQhFkpGnf6YVH2ZDJ7oql2plshtbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 6, 2025 at 2:27=E2=80=AFAM Uros Bizjak wrot= e: > > On Fri, Jun 6, 2025 at 11:17=E2=80=AFAM Jiri Slaby = wrote: > > > > On 05. 06. 25, 19:31, Uros Bizjak wrote: > > > On Thu, Jun 5, 2025 at 7:15=E2=80=AFPM Dave Hansen wrote: > > >> > > >> On 6/5/25 07:27, Jiri Slaby wrote: > > >>> Reverting this gives me back to normal sizes. > > >>> > > >>> Any ideas? > > >> > > >> I don't see any reason not to revert it. The benefits weren't exactl= y > > >> clear from the changelogs or cover letter. Enabling "various compile= r > > >> checks" doesn't exactly scream that this is critical to end users in > > >> some way. > > >> > > >> The only question is if we revert just this last patch or the whole = series. > > >> > > >> Uros, is there an alternative to reverting? > > > > > > This functionality can easily be disabled in include/linux/compiler.h > > > by not defining USE_TYPEOF_UNQUAL: > > > > > > #if CC_HAS_TYPEOF_UNQUAL && !defined(__CHECKER__) > > > # define USE_TYPEOF_UNQUAL 1 > > > #endif > > > > > > (support for typeof_unqual keyword is required to handle __seg_gs > > > qualifiers), but ... > > > > > > ... the issue is reportedly fixed, please see [1], and ... > > > > Confirmed, I need a patched userspace (libbpf). > > > > > ... you will disable much sought of feature, just ask tglx (and pleas= e > > > read his rant at [2]): > > > > Given this is the second time I hit a bug with this, perhaps introduce > > an EXPERIMENTAL CONFIG option, so that random users can simply disable > > it if an issue occurs? Without the need of patching random userspace an= d > > changing random kernel headers? > > In both cases, the patch *exposed* a bug in a related utility > software, it is not that the patch itself is buggy. IMO, waving off > the issue by disabling the feature you just risk the bug in the > related software to hit even harder in some not too distant future. The typeof_unqual exposed the issue in the way GCC generates dwarf. The libbpf/pahole is a workaround for incorrect dwarf. The compiler shouldn't emit two identical dwarf definition for one underlying type within one compilation unit. In this case typeof_unqual somehow confused gcc.