From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A73C433E0 for ; Mon, 28 Dec 2020 00:59:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91D67229C4 for ; Mon, 28 Dec 2020 00:59:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91D67229C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 822086B0068; Sun, 27 Dec 2020 19:59:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D3236B00B5; Sun, 27 Dec 2020 19:59:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C27F6B0102; Sun, 27 Dec 2020 19:59:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 522596B0068 for ; Sun, 27 Dec 2020 19:59:38 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 15E5B362B for ; Mon, 28 Dec 2020 00:59:38 +0000 (UTC) X-FDA: 77640883236.28.ship56_320f1702748f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id E9EC66C2F for ; Mon, 28 Dec 2020 00:59:37 +0000 (UTC) X-HE-Tag: ship56_320f1702748f X-Filterd-Recvd-Size: 3812 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 28 Dec 2020 00:59:37 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id x20so20615567lfe.12 for ; Sun, 27 Dec 2020 16:59:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tDSu4XiZkV5gMDS1Vs4PuARPMnz7fqtwxfLIjwQCyCo=; b=pcKgIrQxu7UxjxzewMy3ISbe2VVkkRYf2zXO/968JrWoCLQw4nt42HaoVbCjM7qSV1 gu0ttuRdR1QAvTWjF4QpLtMFuQbH0qVKxPAmXvcVCWvDI6Tm9C9VU3VCJqy5Bz4hQP5q pC5C11cSS7sq6SXbYSAqI4wi9l7M5ZAyRboR0m4bMq5p60bjtuH0FaphUpWrdNeDbUnu fUEjrfnkDLYOCbrHyCi3OrLRrSSLyy/JtJkRh1kCA85UpxRN2IBIK02OTR7qfgRCLYV1 jctFI62OkUMBViwwPi90SbQ272eWhCi0tQrGZlBqtO2/kfUxstcrt60VsELuBckD6RSY du2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tDSu4XiZkV5gMDS1Vs4PuARPMnz7fqtwxfLIjwQCyCo=; b=nlyzfVjmnsy823P1PuKgb+CuyNTNPUsvnj7tG6W7+7neOKz0XQ1T8rUv+ZaOQxPpEQ sAuThhZLqKKlBf5AzMjz6n2T4CF4qWRiHEjP/tYOdPMVnSOZLxZbFTakKAS+exCxpE8w Caa/h72Fedd1mHJdP0lu+pY397rSFHl0+ZHLBaEB5FPqpnVNXy3o69r3qseeGCArIxaI vw3ABr6JW+JHd8lrBL0UFyO7jYT1sdYQ/87nLdRz8n15r83f5/snt4u2PEbiAMEZ9wKL Tv2nPHgu+VpxcNl+DMEg2xVGgF1fU0GOWj+IaWQOSuL9vgsXA4vsGuHp5NBrCqXn9gvc gjFA== X-Gm-Message-State: AOAM533Dgk8PerxOFZzgnBxbYLflLkIMhyf1RLcmF2EhRFBt4Aj1arxS RsCs/qY2fhUoGT4OO5y3tfJBEALfWiAPCzjN1tU= X-Google-Smtp-Source: ABdhPJxnMfJxwsQx9ZSg/2PiO93a8sjwBWOBiRgIB7xtZ/vYMPFXsbSeRZ44g4I9BAeBH+RyDSFvmc6Zxjz7bFCXfLY= X-Received: by 2002:ac2:43c1:: with SMTP id u1mr18693298lfl.38.1609117175998; Sun, 27 Dec 2020 16:59:35 -0800 (PST) MIME-Version: 1.0 References: <1608646792-29073-1-git-send-email-jrdr.linux@gmail.com> <20201222204000.GN874@casper.infradead.org> <20201222155345.e7086ad37967c9b7feae29e4@linux-foundation.org> <20201223083126.GA27049@infradead.org> <20201223121136.GP874@casper.infradead.org> <20201223155254.GA6138@infradead.org> In-Reply-To: <20201223155254.GA6138@infradead.org> From: Alexei Starovoitov Date: Sun, 27 Dec 2020 16:59:24 -0800 Message-ID: Subject: Re: [PATCH] mm: add prototype for __add_to_page_cache_locked() To: Christoph Hellwig Cc: Matthew Wilcox , Andrew Morton , Souptick Joarder , linux-mm , LKML , Alex Shi Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 23, 2020 at 7:54 AM Christoph Hellwig wrote: > > On Wed, Dec 23, 2020 at 12:11:36PM +0000, Matthew Wilcox wrote: > > On Wed, Dec 23, 2020 at 08:31:26AM +0000, Christoph Hellwig wrote: > > > Can we please make the eBPF code stop referencing this function instead > > > of papering over this crap? It has no business poking into page cache > > > internals. > > > > The reference from the BPF code is simply "you can inject errors here". > > And I think we want to be able to inject errors to test the error paths, > > no? > > Something that expects a symbol to be global is just pretty broken. > I think it need to change so that whatever instrumentation is done can > coexist with a static function. Pls read commit description that made it global. It has nothing to do with bpf.