From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DF2C25B74 for ; Sun, 2 Jun 2024 19:12:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70AEA6B00BB; Sun, 2 Jun 2024 15:12:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BB296B00BC; Sun, 2 Jun 2024 15:12:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55C116B00BD; Sun, 2 Jun 2024 15:12:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35F2E6B00BB for ; Sun, 2 Jun 2024 15:12:45 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9AD471C1535 for ; Sun, 2 Jun 2024 19:12:44 +0000 (UTC) X-FDA: 82186895448.16.AF31FCD Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf07.hostedemail.com (Postfix) with ESMTP id C888640008 for ; Sun, 2 Jun 2024 19:12:42 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TIL5hjK3; spf=pass (imf07.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717355562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PuI3t+WrtTWNm+6l5EAvTGHIgvRSvsmXgaFgYPKJXa0=; b=nSkIWjb6Wix103WLpD78cTuuP+5PiqsBkUvgdCh+gLhD3PigkannGOBGHlS6VRD7hS9bOJ JP/VYw1u/kT81X2OqdJz5rVtZ+7CFUcTRCPrNWa2+TWXKoU4Cp+ZSjnnXG9XgP3AS+tGQT 4oZqGKcNHnyJGiOiycm1s3wBhuIHyZw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TIL5hjK3; spf=pass (imf07.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717355562; a=rsa-sha256; cv=none; b=SId6AGfUJCJ1a/R62p/BC4nMWaCMI0kTPSgHp91yax+8bKlFSiGnKeY60PeJT5FcsYa5xx 70Wud83VKG6aGKZnUVn/MHJ9pEBW8Dh0eLKtgXL+R9G0zOznMSpPIO5UBoWzqQO6us8YLh b83pWKH8pHiS0v3Dk/C3Li5wcG1GLUk= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-35e0eb3efd0so1700230f8f.0 for ; Sun, 02 Jun 2024 12:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717355561; x=1717960361; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PuI3t+WrtTWNm+6l5EAvTGHIgvRSvsmXgaFgYPKJXa0=; b=TIL5hjK3NIq9EbGMwp/QywSSn5qa7Hgv0DAuirlflnl5P5/OUYH6ZZJoAM95OZWIMb 2/dyqTcu/tRMrT+gqUqFvP/IQcJT2K+KahaCaB5gy0njU18tNXwO/5Wp3xXzgM3Wb3my f3vkxav6r1lScKdVGD8mRGuC5AMKAk3KCPikQ7fyDipiRSXQGew6fHYQLD3zVmhi5Oqw Z7D1wcCJ3Okhdy43eSGCBEDBrXgmkKziOAHYHHtsd1JXveBC3NV9KrweRwhgIYME8P8H dJKWJ/ubeozhuLxs6K1Z6WdpOe8PNvdbbjAdytwgRR8vax03fvRGhW/L8gL+bor2+FT3 LpWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717355561; x=1717960361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PuI3t+WrtTWNm+6l5EAvTGHIgvRSvsmXgaFgYPKJXa0=; b=ppD3DZJfI0CQdStn+8YNURO8c6A+1C7amWmRgOI+0gJPigXPNUm4f/A3UKpF9PN+FB J0dWSdOD01T3AOONDB8hqzIw1Dvy8ZEIvhAfFk1bplXdWkGw+JpfM3wvu7zJHWbl87Nh Gj4vT3EitDkL2vsGdoI2wuOpt242/mURmWbvUikPJr0apmhqSriSpx57Q8en8A7H2Gg3 kbfexfMp4Rxmwo7XS5X1aRzCSNc5o+46diz5b3J3g2mYJvJkuEG/SQ5QdypwuH9h+RAq CiqIeWr3ydvgFFw2ZK7aJNKTDu/12NaRyaYocG3gRm8KclMmZgCBWqfGE1FOleVfBERG ZW8A== X-Forwarded-Encrypted: i=1; AJvYcCVCyB4KqflB5ruL45TV2A0S3JXzMvT1BOZHmrUno1W65umGKdFw5xq6qRD01sfU15kMqGicOQmpG1YyOwBNky4tVAA= X-Gm-Message-State: AOJu0YxxsjiokiEMCZZVZ7n68OqQp2D0CGg4q1YU99geXYkzJu5kzm6D QNnNIQ3W3spRtcPTFzBRcbLZQlqrl1VSzGlk1IZ38/lJ4zr2KFzjfpPIV+gPBsHVUPpmB4ngPuI Hxjojoj/wSK1TUJm2Oxl82wH2nGQ= X-Google-Smtp-Source: AGHT+IFiy+Aq8rpwIXmxDOwPQr1QKSTA4FIutEelVYoty2l83FpwAbV8qqzqWM9bFCW6U2zGoJG7p6ue910tqwHWFlM= X-Received: by 2002:adf:f7cd:0:b0:355:2ae:d88d with SMTP id ffacd0b85a97d-35e0f285b12mr5495442f8f.34.1717355561135; Sun, 02 Jun 2024 12:12:41 -0700 (PDT) MIME-Version: 1.0 References: <20240531-fault-injection-statickeys-v1-0-a513fd0a9614@suse.cz> <20240531-fault-injection-statickeys-v1-3-a513fd0a9614@suse.cz> In-Reply-To: From: Alexei Starovoitov Date: Sun, 2 Jun 2024 12:12:29 -0700 Message-ID: Subject: Re: [PATCH RFC 3/4] mm, slab: add static key for should_failslab() To: Vlastimil Babka Cc: Akinobu Mita , Christoph Lameter , David Rientjes , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Steven Rostedt , Mark Rutland , Jiri Olsa , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, LKML , linux-mm , bpf , linux-trace-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C888640008 X-Stat-Signature: gk3phmhmsygdyud4ozib5u5a93o6tchr X-Rspam-User: X-HE-Tag: 1717355562-789077 X-HE-Meta: U2FsdGVkX18IYJVcv4BjikCukY7EImdme7d7AIykMsykxKdnT9m8p6gkKZvnOdssXa5qjq3K4JduiUOK0hT4iedRgBLsruh+M9Tuhxt7qpMfdNc3RdoKByz436x0YILXJ3gvrLCmO0fVpBt+eHHkQtvU+4zMmot7VnBPvdUdxXRxh+cocMb71eXgbMOGlW6wTliWyVhgld4vNP1eO1LXDWx2fbuG5j7NGK+bDgd+/1zSAtBJnSTPihNjqzxuSLK7UADJ4LKkcwCEEgNEONNpU7CNDdpHWIhWFf8m0sN/JKt4d8C7BxMzKm/ywbWj49LG5VMVi648WslxxU4TDu4Ode/31dnT9FoyN8nSx2qjz/51PqNW+5RXcOqpjB9eOFupF8KP7Kxa+ihcnR/CLUKarZCJO34+ffVgTEze5/JLClpdVNCCRtO68u4/2ZHZfH1q4FVfObuxL9CrvW/fgY06TKt+TAeOaseX/ryqkR0CNOLuERL7JZ0bp6M7l6jyDF33txb88ACySHqPW+b4iIxErM0efq1jcPqE2AIUACUZkvB9JM/OXOcQ0cieKs0VXveNR891AFCrk3eTZrwnKDPVW3FFbkt/vWdAWpou0OsPbk18rlhGrbkYiq7KHFEWgGdy9dY0En5xKxfczYq8jRzlCHosKtym8i5YAtMTHhWEbkfw7ghqQcE2CrQywRsl1avxXkhLgVpniIP7chEoHNTh/Z0XDc37mj1l0ZCaK7lXcL6f+MQXkRFsO2/18lJPJHl7wKC4W9PT5x3m23RBcnXAn1z8pcq4Ym+g6X6Go3z9rMP2aaPNw+KJXzYYqMrHMLJx16B7u/rbmA64Qre3YQqpT4zXO2svn7/5ZO2ZNfn3FnIyg5oJbnYjeDjEiGbyVMtVJVMV0bL7HqZbQ254FLWZeB8rBlqNo/mmmQ6eCdNeBOqNsS1/jqMrCxxjLxuxDWKISLqNiGTPwYPayR+S5so rP8F9G5b OPNXVx8ru1jHds6EbcsEMMd0F49GVVdz3YY4GrqWhnLT00yqphAXX0hjrfyNDFbsjdhPWCD6KewLg//hq0d4EaetWvFHBWRjp9+wxtd/IIQSEKUMsS0pY7sqpAupyxMXfSDzCe493nfkfj8NcBTcF7Fz4J1/EuR8XDiFfviRmjXaaF8f7czcWQbdy4Rafj6r0FVhSiJdY3VPycVtvzrJ+Gj5r//vYABABjQ+ayrGvZiuVGU22PdpqhL6F+vfcJmVJseTVvmaSZusS4q71keuUHquTzm6FNbpzHEcFopb03kWX8wWBrN87c26K+9vA/vozhpC7Hr5kyPCM9Dt40XmDTPZ1wKkFfJHXEHonPIy7pNf8381ETExTiJeVH3roJwEHLGC1NBNi2zW+b16VsCXeLegLgx7Fygc8Vwg2vg0hkLbrok6bBCFI45kRTYo3zufB4FVZgAYJ6aBaTQV9fQ3F2T5lRBKlqLz+C6MTamYwfyn4LtkxZ+uR4wJvlbVolXQgyy9NG8D4XIxfuZ44Hzxlvl4vVP4T41wFzwttdzpAUZOaGCf+XUjiX/K2xw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000079, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 1, 2024 at 1:57=E2=80=AFPM Vlastimil Babka wro= te: > > On 5/31/24 6:43 PM, Alexei Starovoitov wrote: > > On Fri, May 31, 2024 at 2:33=E2=80=AFAM Vlastimil Babka wrote: > >> might_alloc(flags); > >> > >> - if (unlikely(should_failslab(s, flags))) > >> - return NULL; > >> + if (static_branch_unlikely(&should_failslab_active)) { > >> + if (should_failslab(s, flags)) > >> + return NULL; > >> + } > > > > makes sense. > > Acked-by: Alexei Starovoitov > > Thanks :) but please note the cover letter where I explain how I need hel= p > with the bpftrace side (and ftrace, but that seems sorted). Without that > part, bpftrace will silently stop doing the injection as the static key w= ill > remain disabled. Right. That part was clear. Once this set lands we can add static key on/off logic either in the kernel directly, or in libbpf. In the kernel is certainly cleaner. How will ftrace handle it? I couldn't figure it out from this set. Ideally key toggle should be a part of generic kprobe attach logic and not bpf specific, then both bpf and kprobe will work.