From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB59D0EE20 for ; Fri, 11 Oct 2024 18:33:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C7836B00A8; Fri, 11 Oct 2024 14:33:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 24FEF6B00A9; Fri, 11 Oct 2024 14:33:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F1A66B00AA; Fri, 11 Oct 2024 14:33:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DEDAD6B00A8 for ; Fri, 11 Oct 2024 14:33:46 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 23A2C1A13A3 for ; Fri, 11 Oct 2024 18:33:38 +0000 (UTC) X-FDA: 82662169968.24.52F7236 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf02.hostedemail.com (Postfix) with ESMTP id 605EE80012 for ; Fri, 11 Oct 2024 18:33:39 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NmGbhzYC; spf=pass (imf02.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728671554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zqw+eRG2MYmG15ACoCDgCZaSTwDwa5xCdf5S5ibxmN0=; b=UY8PKtI162HX9MiTNEU76UeU6IxqR8VwpjE2dfr/pkv5Be1iKu33KIgevL/bULPy3Saxx8 5+h9nn09zJ9DJ3Vd/jrJeTXSoB5TdG6FzoJ60uNi+zjzpzG494HhXsOqU0RvpUhfmmj74+ Hh/+zLdAyhJcuWrfXvnZYgN2yd20Bnc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NmGbhzYC; spf=pass (imf02.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728671554; a=rsa-sha256; cv=none; b=O6XJ38MK4iJzkKI3CLkEvLoL+0vhUkVS868omh9cVFrO0uXG5qqhl0yFLqni6IAwoWFrgS l3FZui71Jmh7FvadOC2SqUotWcv2+/moGaePo4U2/EIkiZzDygQGpppInYN54Z3Q9YaoOi 0CYy0t9Pl9bNrnoZu/hBiO6CpzxiWXA= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-37d461162b8so1457683f8f.1 for ; Fri, 11 Oct 2024 11:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728671623; x=1729276423; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zqw+eRG2MYmG15ACoCDgCZaSTwDwa5xCdf5S5ibxmN0=; b=NmGbhzYCUHHRO1mOBnXPqcJN2bKVbyfgLnI05aOIYyJLPegkksL3fIb2U6a7rkSg0+ SH+lutTHUS3cAgw2icZsaIyHtgppYti++4saE9CWVz/COsZs8kdwZvr5w7Eo2218b4N3 QaIEHJgahynRtmQu8yZhGwZLJ7QM/v9JeGMSFqKM4wEvYq0YkO1474bKlQbk21jAzLqb DXMwhOXy6Bi1fJRPHrssDEQU1ChbA6ibqWdyfroC6OLckRf3UWg9FX4I+abrXGQk5jHy X7nDWodwGYLrYo9XCEcPNObKhM0saPYGxDkznaxJCSJEWQRLksk/6MCsYW6DBZoZcTWI QhgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728671623; x=1729276423; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zqw+eRG2MYmG15ACoCDgCZaSTwDwa5xCdf5S5ibxmN0=; b=Jwz3z5bLMeTa0QiT76Vr2rhsHZxY5GsieIV84b1KX+DGUDmGCqTvl7Cxelp++BbrzQ wqyq8s/BFSozzmcWnWWVO5isZy2WN+sE+pCszY18ULpz/+fVVOriXQdhNAWxa0z/lWuk kh31QdY5QtkGxgsH8gG1PJqjEDCEPsLhF5E3BHBa8zo8La/dFniKhnFXcJQFFW/rxszM QzozbisCDLTBY2USwJKOqXFfnCWez5Ib3DyQUoOj3Teht3eruInuvZAJBkZxiegIRYSQ cQD7qGFrTxjZw6GBCfBleehsqRT6/87cUJkuOa0dgeiaUhHKToVe0XZWGviqzhC9/JAO FZVQ== X-Forwarded-Encrypted: i=1; AJvYcCVx9hj0CVJqYbZAPFlKkfl3MM7SHyBmoDuHnyfxq/ATA2jc7qLpQIFrpONTJqH2SDI4yDUQWiB2+g==@kvack.org X-Gm-Message-State: AOJu0Yyfr7g4Mbn4BvRZJdXtRW7ss/PDbY63EESguO+sea2Di6sbBMv9 tCrSwOI4rgSawcPvsC2FSIt1N1DMg23h6KB2OvEwiM93Zhm7VU623UV1/nXp18wifXMQ6dTDaOo Ng2J+3PyjCOZzjr1uk10vV0MgmwA= X-Google-Smtp-Source: AGHT+IGAj/SGj+TtqfRfGd2P3lWGKqlm+1DElS1k2FoqBelgBt3R6bLLn+m/l+x2AOLBP39wrsRkToxZgrWVZPQClGI= X-Received: by 2002:a05:6000:18a:b0:37d:41c5:a527 with SMTP id ffacd0b85a97d-37d5feaa088mr342022f8f.13.1728671622794; Fri, 11 Oct 2024 11:33:42 -0700 (PDT) MIME-Version: 1.0 References: <20241010232505.1339892-1-namhyung@kernel.org> <20241010232505.1339892-2-namhyung@kernel.org> In-Reply-To: <20241010232505.1339892-2-namhyung@kernel.org> From: Alexei Starovoitov Date: Fri, 11 Oct 2024 11:33:31 -0700 Message-ID: Subject: Re: [PATCH v5 bpf-next 1/3] bpf: Add kmem_cache iterator To: Namhyung Kim Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Arnaldo Carvalho de Melo , Kees Cook , "Paul E. McKenney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 605EE80012 X-Stat-Signature: b8kbadufgnt4843hjfr64p166ssj5oob X-HE-Tag: 1728671619-234718 X-HE-Meta: U2FsdGVkX1/rAaWxMarM9oiQm9NrPtBejq9sw1Brg166hEOhZi8cGHAAbDVD+eVvnpFi+b4H4oN4YlV6nhBIYEe5JpRlALVFusFSbjx1XDYxeSawUxg4E7aOPyMR5TVMEXZNcgIjkAw6vTjp2LkOEdVpxECUz5KzWpYVkKbbK85pwVri9aczHhwNQlhpz5TKL2ijBdaSOdE1M1UdPWbD7h6yhOCo1xPGru/gkCDlmqx8dv/JW3MGcftxZ6R1/XAkFGqh17mhDSX38nk/3lrW7HsVJ34lc8QNa5UHdu7Jg8iwjXdR0ec/gvcY271Dz5Ke/Ug4D9HRkctz3DzY7fJwnFYG67o1P6RifBV4l2UrPvLZde8aNl4unqDQf2dLd4oKfwk3HrKrhpX8fghw4LMVA/8fSywNiwMIeMM9rMsP38JwPG7Io33CjUfKDMgsghLlAK8AsUfEvfINS4QmnrlFk8JLt9Kw5cxV6xCdDcsbVLSp6cIXrujjRx0zM0hEWYV5zAtxWmoTDfg7qZXef4ktyR1okOV1hNls4c9gAPOz0AAsEcfqk3JhFisaHXD/htVPdLbHA8d5C6VdZ5yucBz94ECixp1cnjhYV3vySgZHedfyM0riy9rSklM7o7kNBIVihTiU03lfNKxAtECKLR6Dpjm38A/YE04kM1JKK0MFdZkLsIRTM+ypZv+ro94DDCPODC8sQTp/rQcZMK176+9pH1mcZO1JeYqZT5BD4bqQfRxuzRUuFAOBUJkCRXtM5JtCQwZGN+F9PMTgrs8sAhjjy8m9t0rXDT84qvtz673UsCGPjvZgxjfdhXg1xd7PxuGj/v9qkbdP0lQQamhyommGi8OPtV41hgtDP/NznVVXiJSKKF3lnHD0eutwoCy3K7t4RNpylXbOF0VDQyX9airB9+9+0Hx4JZPEgnlsggwJ42QfqHjQ5RleeLaQpIqvlckQMUKKB83pgnutcv0cYhE 9INCwgRI hseh23EN8Ti1bEEqUepweDm9zW0CaMOUdefXipN/nbWZeYmdiRk49m2OI3dDx49IE0hz96XidPNnYs2dGQ29Bthi/WByqipphh4qWCEXkW/9Kd0P+mKcTD56KlRmELMDHc5xGx3lP0bmqbylxzqL2VGlz4u+9zBSwvwE/nP4u82bjTvOXQU4v6Iei204b8+MyuAW8IpbmGO1KEMToq1zaS6f+byB5ydB9iIvoSBsW98HDvlA1DWg3C1h8WthUui1K13jEKXKH0UJAvY5YtmfHGuLAG016kRHvFlHTQqRdrAY/8EwSy6mK/SP6n/+1dfhjdhpeJMvgLciUJocMJhHq3AAe9f5coochXtGnIoDDS4GS30SX07K0Trq+g2cHALADF7KfkXadm23GRucwRqJNpJ14JVDf8oGtFbGBVD8p56zGBjraLTXJ47KZLBRc1iOWVE5YXnyISvWC6gjzefIMqKOK+gbl4S/2nKAdtYpWHjcJrrxSXqSDpuI6RvrfIIf3jWtCSJGdwCR4WEk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 10, 2024 at 4:25=E2=80=AFPM Namhyung Kim = wrote: > > The new "kmem_cache" iterator will traverse the list of slab caches > and call attached BPF programs for each entry. It should check the > argument (ctx.s) if it's NULL before using it. > > Now the iteration grabs the slab_mutex only if it traverse the list and traverses > releases the mutex when it runs the BPF program. The kmem_cache entry > is protected by a refcount during the execution. > > It includes the internal "mm/slab.h" header to access kmem_cache, > slab_caches and slab_mutex. Hope it's ok to mm folks. What was the reason you dropped Vlastimil's and Roman's acks from this patch while keeping them in patch 2 ? Folks pls Ack again if it looks ok. I'm ready to apply, but would like the acks first. Also I'd like to remove the above paragraph from mm/slab.h from the commit log. It was good to ask during v1, but looks odd at v5.