From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888C7C36010 for ; Tue, 1 Apr 2025 20:56:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8420280005; Tue, 1 Apr 2025 16:56:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E31EB280001; Tue, 1 Apr 2025 16:56:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF95D280005; Tue, 1 Apr 2025 16:56:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AAA65280001 for ; Tue, 1 Apr 2025 16:56:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 45C621601DE for ; Tue, 1 Apr 2025 20:56:03 +0000 (UTC) X-FDA: 83286682206.21.5A3EA35 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf27.hostedemail.com (Postfix) with ESMTP id 5C8F840005 for ; Tue, 1 Apr 2025 20:56:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jD5Z6iSd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743540961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o2NSR4UNAnB47pTdmCuqKUyvdzUoswTXZia5FOSskRM=; b=dxXw/kubvYT24tW87MCigCfOhT0tXiybDaaFbz5VxJhUu6FmzfsTSdGy+OtnhvMFNdiEWA u3RVsoCqtHNBatTznV9dLfM7neMF7BvHs8OC414O3Y5LDgNmc3iHmF5Ny8pF7y7oF2jbH1 jVfi0witCH5tJ8INQ45ycxHHl9mFReM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jD5Z6iSd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743540961; a=rsa-sha256; cv=none; b=LnL7iS39QJm3C4LNN6Zpj0l0Ysbz79zP7quzXtXIt/XUr76EUFY+6PCM7/e+MsiBfdvYnb BqIphjc9Vmb8bPgVuqcYj5UFY8MhFkJhPtJfyFBxlKZ5+L1cgQ5v+/dPInEpjMcmlx+x0W jHQi+7Nv5RP72dIoOldwCqUOKDQwsvY= Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so1280285e9.1 for ; Tue, 01 Apr 2025 13:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743540960; x=1744145760; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=o2NSR4UNAnB47pTdmCuqKUyvdzUoswTXZia5FOSskRM=; b=jD5Z6iSdROhW1rCssFQDOyHixv+fowEM3LMg4+EBG9XuCOBpih5hcFhHC3qiBuaeWN cfO9Fq4VdofYN4HHdpekYGeQ+GKAMViEVtAgshlIyI5dPB3tljOCvqHnuue2+t4znNuH Lmbd4+iXO8K7ehceGY+D4GtYhuSV6KkfZ/URZNy+1xnqmOh7T0cAPHMm+fA2QfsAe2on 0DBDvJ/xLulIWBNi9+vhTQabj6hDeKj+JRzpBfuGKfGtzrIkSR+oofuJHYbGe8W8Dcyx Rf9H1XnrZBlfBO/niCY27nm9cxqoJRZnE1aeJuTt8DN19cIkJwZPzX/y5FHNJZuJl0uk 29lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743540960; x=1744145760; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2NSR4UNAnB47pTdmCuqKUyvdzUoswTXZia5FOSskRM=; b=EFHsm+vb0HJ8mky5Jl8L+sfDyM3YQjalcradxD98DWiKM+Kvc8GMIEcwPL6lH5FS/T soCYim5P2zywUr6WaIl8rjmrsQ67sp17OSIVrWInqnhNJqYndX6vNNkSqCTQeGRsfpv5 ilvmiIE57QOg/bu24wL0Xo63WRJrazc8iRNo9YbJ3P0DmWYdObT/tF241tJO/YWrHRPA dHI6xNYIthIyHY3aaeEQ3uK1q8OGdxvaecRT6BjL/16p5bVTYHVlVDapb9+9jykOBy9N xkwFvX6x+ljHZiFmRGilhdJl9Qi027UHtfk/HhUrh2crbntxTNJOWl3xyzX1u3lSi8vy 7DuQ== X-Forwarded-Encrypted: i=1; AJvYcCWO2mSPyfFdJ6bg/CL/70cc6qt7LIwx4+a5YYwdbDfbVez61eNPbZ9W42OteExLXhcNiUBY1BSEMA==@kvack.org X-Gm-Message-State: AOJu0YybVm0Kxt/4oJhSWbs4tYst0+pLKBXTOqYj4R04X4ztqCkrvY13 N9gmr66p9bngZ71fKNvgi+Sdss29Ep8s2mbvknKF3+aOJDlPE0OUFqPS3ZRDTj1lno30Jb3j8yV fY14wPtOgG97afxb5nCh5hV6YK5Y= X-Gm-Gg: ASbGncvU/qtnlROPyf1vOUf/Jq4ofjcUcHxXSHzuLBhaDa53+aotwxC28y2yZ2+VZrw nyi7xsaPmutubacbkXMpWL2jdL15wPj3wdabD2Mul98V+frEKWUHCEFrt5XZ0KGPWJBb9v7FbHR IBa0KwjnLwWD8PFxf0MAh2QZIpj+D0s4ay0YbSg6RSHARYgNpE2+Dy X-Google-Smtp-Source: AGHT+IGWteUsIVF3s2AwO2YVJcKGPh17tVztW/b9zgcwXsBDEyFHs48WWvXAg9YnsBcUlm7ACPNG03OiX26srIw/ShY= X-Received: by 2002:a05:6000:2281:b0:38d:dc03:a3d6 with SMTP id ffacd0b85a97d-39c27ee3659mr1375732f8f.4.1743540959557; Tue, 01 Apr 2025 13:55:59 -0700 (PDT) MIME-Version: 1.0 References: <20250401005134.14433-1-alexei.starovoitov@gmail.com> <84d7adee-fa83-4a8b-8476-820212dc929e@suse.cz> In-Reply-To: <84d7adee-fa83-4a8b-8476-820212dc929e@suse.cz> From: Alexei Starovoitov Date: Tue, 1 Apr 2025 13:55:48 -0700 X-Gm-Features: AQ5f1JoPlciPWKp7Yyn3YMwfDEkIxze3Y9_VXpZscRqAW1B-ZQ_8oAVtAbF70Do Message-ID: Subject: Re: [PATCH] locking/local_lock, mm: Replace localtry_ helpers with local_trylock_t type To: Vlastimil Babka Cc: Linus Torvalds , bpf , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Andrew Morton , Peter Zijlstra , Sebastian Sewior , Steven Rostedt , Shakeel Butt , Michal Hocko , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Stat-Signature: tahbek1spbcj6o6bzkromhdbjpfqtz96 X-Rspam-User: X-Rspamd-Queue-Id: 5C8F840005 X-HE-Tag: 1743540961-575427 X-HE-Meta: U2FsdGVkX19M6BRnOlLB/FKPp1kjQM5REyxiqnXkv78sxN/5IFSK38JMgOWm2CHSqI6GeQpeKjIgZWEtc9Kc69r1gKWWMxBi0O0b8YO/K9L+yVf0ACRparHgfPHIk5wUs8tFBUMY2R1p0kLCcQlr3mw4ez6lDfYAacJx0P//AYaVo9r+oeHTDGPvhOcGxo3XINyE0rNdyrCMPqYnhgHYugggfewhGfoKDXNc3wFI0yJ/m1OPUxbOzD3dZg595TZ2MjIhA2f6A5h9oHa1cXyggQEGXm1Y3kZawzVd4JSDzFfQIbCOw9gSO49lGg9limTSbvVL9Yfk6052yPrLFbO/ATFnlcaRowMXk4MmjAesbWQcjfxQ5CBj/M4y8snNweBy3zKYoAiJHYIYTYf4VJhHaH4745d24IKK+UdUv7RGofuG33RYZ2sJLEZSQ/ObJRjGu0aO7OaJQd1F3bCepj9ylZwpjvpQCjkZGYCOS2gmTeCRkHrBTnV2neg74ZmT878IAhN9GQODXwPJg8Nb7LAEclp1PhRZvOjURnYB6IA83J1NIWEoV1sQOUlO1JC8Dcx+Wv7dBwHKSySFTmpQNrjN5puv5wHDrAR9weXf3tkoIOKjIDPzmv3VTdT658RiBv07BJQaOaEGDJfxdKg70HLga5EXbUkJmkhwd2qMzsYWgSHgKGN0hIaXhOfI6g0tMVwQBNkUVKgQpU+2bCfQObzhAiH3xEtMU+6n8osbJExVoxVZUB5iFFphelQKCc/KO1lcnGMoDmjIQPNq2iVZAf3EMupxfq9Qe5Ur/wJlWXzlVzGDUEAUxqVU1hzdqBPgv7+TlNf7Q8Q9ACaZGAc2qccGuhSi9jdOFBEm3WC8dyj4BZORf/gX8OY6pmV2tzkNgtcbL4mqOU+uFmBeHr5Ql1fTFS+grfcANQPg9x+4ac1NOB2lN6W+exqcfVDI4TsGUIzt3EAGWqprcHJKMGgndU2 FaSxCM9w Ti0FYaIYZCD172VJ8u8C4AdG2eb4ALsbRT7oBK9lUuP46C/K4cyfhDwxdCmw2a32u8p3+CT5YSovVDUnRqQNGTZFxPAWDEl/M56JwKEkR7hrpLAT+yYo2pbZkFDKPzgP1wNrnv/oVhpNrX7JRuudYBWlCqYL2/hxvIkhk1M0/mryS9hNKSAFoWrV10jBpojdf+PKxj2kRE6OufwbzKykefhLOqfUbp639ypsLI+XFQl/wm0lKWXPNhkGvzjNOrjxPtk8vSYhSt6K4FPoME/H6NMfvsEEorRktDB1WBDJOPtvCp7iPWzZH6GWJJnKmXPuSNHzKVnnzPoL2bce68shpicRehqoWeHfEWJNNEOFL8NCZD4XpzGpyT+fc9Aqzm7YjNg853CkBblbBTlnR58OElP6oRY6QUKGbWqeezA2voYrYyMB7CTzmkfoE1hOBQ5Br/PhDvznbFklmrexAJLbnfVF9z0L/d3Ap78NqMikJ4CIDg4gGL99oFIbE8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002869, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 1, 2025 at 7:18=E2=80=AFAM Vlastimil Babka wro= te: > > > with newly introduced local_trylock_t type. > > Note that attempt to use local_trylock_irqsave() with local_lock_t > > will cause compilation failure. > > > > Usage and behavior in !PREEMPT_RT: > > > > local_lock_t lock; // sizeof(lock) =3D=3D 0 > > local_lock(&lock, ...); // preempt disable changed to local_lock(&lock); > > Acked-by: Vlastimil Babka > > Is there a chance this refactoring will make it to -rc1? It would make > basing the further usage of the lock in mm and slab trees much easier. +1 > But squash in the following fixups please: Thanks a bunch. Folded. And sent v2: https://lore.kernel.org/bpf/20250401205245.70838-1-alexei.starovoitov@gmail= .com/ As soon as Sebastian acks it, I can send bpf PR with these 3 fixes and other bpf fixes.