From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
bpf <bpf@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Sebastian Sewior <bigeasy@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Michal Hocko <mhocko@suse.com>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] locking/local_lock, mm: Replace localtry_ helpers with local_trylock_t type
Date: Tue, 1 Apr 2025 13:55:48 -0700 [thread overview]
Message-ID: <CAADnVQ+5Mv7Pjb7qQxovKuiuuwYFZ+vgEWEzJuHy63BJwPY74Q@mail.gmail.com> (raw)
In-Reply-To: <84d7adee-fa83-4a8b-8476-820212dc929e@suse.cz>
On Tue, Apr 1, 2025 at 7:18 AM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> > with newly introduced local_trylock_t type.
> > Note that attempt to use local_trylock_irqsave() with local_lock_t
> > will cause compilation failure.
> >
> > Usage and behavior in !PREEMPT_RT:
> >
> > local_lock_t lock; // sizeof(lock) == 0
>
> local_lock(&lock, ...); // preempt disable
changed to local_lock(&lock);
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
> Is there a chance this refactoring will make it to -rc1? It would make
> basing the further usage of the lock in mm and slab trees much easier.
+1
> But squash in the following fixups please:
Thanks a bunch. Folded.
And sent v2:
https://lore.kernel.org/bpf/20250401205245.70838-1-alexei.starovoitov@gmail.com/
As soon as Sebastian acks it, I can send bpf PR with these 3 fixes
and other bpf fixes.
next prev parent reply other threads:[~2025-04-01 20:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 0:51 Alexei Starovoitov
2025-04-01 14:18 ` Vlastimil Babka
2025-04-01 20:55 ` Alexei Starovoitov [this message]
2025-04-02 7:30 ` Sebastian Andrzej Siewior
2025-04-02 9:02 ` Vlastimil Babka
2025-04-02 21:35 ` Alexei Starovoitov
2025-04-03 0:22 ` Alexei Starovoitov
2025-04-03 9:09 ` Vlastimil Babka
2025-04-03 14:44 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQ+5Mv7Pjb7qQxovKuiuuwYFZ+vgEWEzJuHy63BJwPY74Q@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.lau@kernel.org \
--cc=mhocko@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shakeel.butt@linux.dev \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox