From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849DFC3ABC3 for ; Mon, 12 May 2025 16:46:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C6866B0189; Mon, 12 May 2025 12:46:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 974E26B018A; Mon, 12 May 2025 12:46:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 861DF6B018B; Mon, 12 May 2025 12:46:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 679856B0189 for ; Mon, 12 May 2025 12:46:32 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 340191A045A for ; Mon, 12 May 2025 16:46:33 +0000 (UTC) X-FDA: 83434834266.13.C261925 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf07.hostedemail.com (Postfix) with ESMTP id 4DA5A4000C for ; Mon, 12 May 2025 16:46:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O5G4wKgT; spf=pass (imf07.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747068391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oX6B+3os2H1hrlDtdqIsj8ZH39Q6D7xnbdhYaLSgq6Y=; b=02cBSeLlgG3QAfbikHv08P1SoEWdmeL6C7eA+avpDfXTbPEXE9/evOkVKbMM42D4RjheWq Ir0tBpWVPXkUj7vhiQgFZus8cljGlkq8wa6avxgQUz/MVoAAjoW1i4DX9cvYJU04jAGv9o lJ3dYJqP+WpM+tReXHOoDHQyW+tmm5s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747068391; a=rsa-sha256; cv=none; b=e0j0H/WedPO8JPnHmn+AqDRXQAlC6NSP4g4ckXNRS3IaGu04FydI6ndh6wM0AjH1j5H0IF 8y/AwSQb82UdCqAUx4l2SOmVMIRz+XnrD7lfCWA8/RLU1despdvrPkBH2ulWTmKGdY1J7F IGUO0AZ0ZiPnj+vmicQ9pG1ys5BCBcc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O5G4wKgT; spf=pass (imf07.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43cfe574976so33897015e9.1 for ; Mon, 12 May 2025 09:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747068390; x=1747673190; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oX6B+3os2H1hrlDtdqIsj8ZH39Q6D7xnbdhYaLSgq6Y=; b=O5G4wKgTwkTq3UcYD1MuF2ywCiSqMqErPEhlSHehIbEoUuqlxRSrghuS7iqVa3B1VQ TWlO2SETk4/enyAIHZPpYGVtA7yI+1halfNZVhDLuYOuAZQ0O9RUDG7hnxz7VcTwBIBT buhw72+4lVwi9eoivoV23Oy2CTU2HY57dQ1aAbnKlRuTuBfN1/WTCM5CJJdWF0at6MZI XgNMTsYCFWdYTbuSnNOKnAfcqHvkp7ebahLtnE7ORvWmt+K0LxoxLXarYp4ljO826+uf kFMt42dvHYaYHWiLVnC0Kd9dc99xOOTXPZExAi4zQhTskua4vN5wKzPdgHUbYLieIyVt 7dVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747068390; x=1747673190; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oX6B+3os2H1hrlDtdqIsj8ZH39Q6D7xnbdhYaLSgq6Y=; b=YcQ0+q3TofvnsaWMEblVw4ifWxqxoAJHMw02tBu74KTI4cEiiNgeJ6QtNk/RDaZeqF KOm+hxB0ftQHNJWZ7C+IEDOCWJnv4vGYLBVLKWC8KccR1HBph7Qv9+4+9R6D0M3AgBPj /9pYHsCOKGNOjcXt7diOsC0NwxmfVMgVZxZrdA+mSA3aaVoHzNUai7e/y0bFFKMdLQXx NC45n+4HZ1QxiUUWzDMziEslIFNDtWktRSu3p+XQLD5J/6kBEIPvdSh+bIhvxnw8Us9E JsU29aayDsPDtwckkZzB7CWQKghTSyVIGafpuJ/VhUwxywVB/ZJH2Gl3+X6RWkKs6kyI hsvg== X-Forwarded-Encrypted: i=1; AJvYcCVYh+MyJlvtzanpXE4rMkyPuZzULWP0MTqD/CFRRZ+BjP5vdeG+c9CqgE74au3ZMSQ19EBau5Q+5A==@kvack.org X-Gm-Message-State: AOJu0YzYkELH7qgIwnllNKhn+XAglI7wOErt9++RHyp6PxzUgFChGT/7 L4gjPKbh+pG/Gu07Qe3YGH48wtdTADbsMqJd3FMLRyBTf4uhiGOtUOKhnT5IoNrRySOls1cfrpv cz0VjBX71HPiKumMNTmDVixKdWrU= X-Gm-Gg: ASbGncsYmDNlzqmX3vpcy0H9CiTK/bsNuac2heBTPW8Zcbo2X71QfJv2PwSnfJOSnWE f+U0BZVmzymu/ttH1H9Jn31SoFbDQlWZPunK2nYvMBZ5hyIx6E6/Z+MAo/o2lSKdoHqRhBqkhfL 0H3IkR0pRU+ufxygojBdVeZ/cgYOKlOcgrvcJdAJ9NMtShZ7ho X-Google-Smtp-Source: AGHT+IFM5nT873/utvA++/Y7NVoK0iS7GvPOeDGmqobCWQ8UTq0xILkGccvcH0VKOkoa1yWs0+PYeRg87TlNXsB7lro= X-Received: by 2002:a05:6000:290f:b0:39a:c9c1:5453 with SMTP id ffacd0b85a97d-3a1f64b5e7amr10997886f8f.49.1747068389443; Mon, 12 May 2025 09:46:29 -0700 (PDT) MIME-Version: 1.0 References: <20250501032718.65476-1-alexei.starovoitov@gmail.com> <20250501032718.65476-3-alexei.starovoitov@gmail.com> <20250512132654.4MCqyeG6@linutronix.de> In-Reply-To: <20250512132654.4MCqyeG6@linutronix.de> From: Alexei Starovoitov Date: Mon, 12 May 2025 09:46:18 -0700 X-Gm-Features: AX0GCFvMkQZi7JNk52ueFN8_-In0Mlpxv3ktsW4FzqyRjYnhPo4dZRQqyYc1Eto Message-ID: Subject: Re: [PATCH 2/6] locking/local_lock: Expose dep_map in local_trylock_t. To: Sebastian Andrzej Siewior Cc: bpf , linux-mm , Vlastimil Babka , Harry Yoo , Shakeel Butt , Michal Hocko , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Steven Rostedt , Johannes Weiner , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: g6gtg3tqiunjhq8hih34ffsxgrzubzgr X-Rspamd-Queue-Id: 4DA5A4000C X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747068391-975244 X-HE-Meta: U2FsdGVkX1/bBA9PvnAvLq3ytxQ2ooE1AcEbc3VJLk34efdavQxJ4paHWc6voDyE5oqAz4TQszqhHkjKTgbMl7aJygukbDHESRac5CZyo//UNDtuwVszObN6aIJSk4p6ql5K7Wx5dOSSfQN71NaqbWVvSqC5jmDVoE2aj7FecLxcqjbZhz2PDsbYkmb+8b4yI74F+J99iJb4yXiYsyhULuOChPg+1GXyJSNEandE6K24xRJGR23T1Hq12k67JvBbgkzhk8bSDQgvkn90pgC35l46VKkzWZLIUgTTNRCcmOToQw7M2dyqmdzISR+ZwVIqQ61YoM9vDfIdZcM6vALMyoEuJX2UiDE8YIah3+W7cO8EhgGiXiEeX32a9KVU+1lml2TImfAS60uV9JYY5qGKtdZRqCIP1XbCO4jVX+k/Qi3LnMiVXLb9biXGhVXWQeltVg6OKRftotVynDyh9B+Z/9+/NfGK54hPQDGeL8qBtGQcwpCvaDy+XsiwXSrFRqwVrVc5Aws8jvVm+oxRrUp5Q+/6DPFA4zjmikQp8EsrwpdSD6pM8+kpAeN/x+ymiwDiUxu8/QIZMn2MU42+XoTL2GwVoj3cgVZG8NJy7r6cr0Scih7lsb3o7GK/gYyo0ty4tFi9wkd2lsonDoq0xG/qDhpV/O+uGoAIh7WmTyBZHwQFs2dueq/qxi+5Q+FWbSYV+PsFgwCpYd3ugJmDJvHgMjx1Qj+C2/6kS3Mw3sI7UrSxs7uNxhpKEyBrkVMfUR/GbSYUUWeoWiPZhyxcDrl6mLMA9dlXXblhuMzZ5Js+TrkBCGpHfXjUAiyz4c/L4fQDGa3GvjbQYrPMbNOovX85AUpgy+yANY+SxGl1XjN7LIAxadw0DaXFtXonbx/TTroY1lnKjCBlfU44YDZ6uUt9qvoHGUeJ/fLlDx2lQpDF4go7b5mmXArqI8rRVwPsRmWnOY8RvxmYGWhmUmT+dFM W6AweIHV qLGVh6Fz7+oQdbj4gOcK/i6P0izJktUhw2nvvBoDr1JyoCB/UNWTJGnutQDaxnDAiAUuDszSsyTFpH2Pqt4U56KJQyy4erVoZPAVQcJll23lspvElWIrnp2PlssgqknHKnu3P1NS3spNUj+5I7TL2P4Wwo5XNt6/+BcihDGQRN0tdKoeT//n1hrkYa+r44afFx+qlTopm8vJrpQSzxW/I0DHloUsdKMQYtyDIgcsR2R8QM5mrWc9EhlqmvALOUXLYcpldrLWOSfkER1UEurW1iGOPn8DUX2xcLAuYB07us2SqPb/dm0V6U38nm2SOvafIXvG/r29NKxt6mzmm4Hzi7IWtYgo6z/HxU+WWKqwq0eXK02L0Ss662UU6RwkIQPOiCKDOjOXuaUvepK95qHunv0GpWL5S3O9KHkQvGbr4OlVsDDo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 12, 2025 at 6:26=E2=80=AFAM Sebastian Andrzej Siewior wrote: > > On 2025-04-30 20:27:14 [-0700], Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > > > lockdep_is_held() macro assumes that "struct lockdep_map dep_map;" > > is a top level field of any lock that participates in LOCKDEP. > > Make it so for local_trylock_t. > > > > Signed-off-by: Alexei Starovoitov > > --- > > include/linux/local_lock_internal.h | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/local_lock_internal.h b/include/linux/local_= lock_internal.h > > index bf2bf40d7b18..29df45f95843 100644 > > --- a/include/linux/local_lock_internal.h > > +++ b/include/linux/local_lock_internal.h > > @@ -17,7 +17,10 @@ typedef struct { > > > > /* local_trylock() and local_trylock_irqsave() only work with local_tr= ylock_t */ > > typedef struct { > > - local_lock_t llock; > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > + struct lockdep_map dep_map; > > + struct task_struct *owner; > > +#endif > > u8 acquired; > > } local_trylock_t; > > So this trick should make it work. I am not sure it is worth it. It > would avoid the cast down the road=E2=80=A6 > > diff --git a/include/linux/local_lock_internal.h b/include/linux/local_lo= ck_internal.h > --- a/include/linux/local_lock_internal.h > +++ b/include/linux/local_lock_internal.h > @@ -17,10 +17,17 @@ typedef struct { > > /* local_trylock() and local_trylock_irqsave() only work with local_tryl= ock_t */ > typedef struct { > + union { > + local_lock_t llock; > #ifdef CONFIG_DEBUG_LOCK_ALLOC > - struct lockdep_map dep_map; > - struct task_struct *owner; > +# define LOCK_PAD_SIZE (offsetof(local_lock_t, dep_map)) > + struct { > + u8 __padding[LOCK_PAD_SIZE]; > + struct lockdep_map dep_map; > + }; > +#undef LOCK_PAD_SIZE I don't like it. It obfuscates the layout.