From: Trond Myklebust <trondmy@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: Jeff Layton <jlayton@poochiereds.net>,
Ben Greear <greearb@candelatech.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: Killing process in D state on mount to dead NFS server. (when process is in fsync)
Date: Fri, 1 Aug 2014 23:44:32 -0400 [thread overview]
Message-ID: <CAABAsM6dNYMus3GrrHiT82-kEb_hAftXnuhSx6SXeuq-E1+JLg@mail.gmail.com> (raw)
In-Reply-To: <20140802131946.207c597c@notabene.brown>
On Fri, Aug 1, 2014 at 11:19 PM, NeilBrown <neilb@suse.de> wrote:
> On Fri, 1 Aug 2014 22:55:42 -0400 Trond Myklebust <trondmy@gmail.com> wrote:
>
>> > That still leaves some open questions though...
>> >
>> > Is that enough to fix it? You'd still have the dirty pages lingering
>> > around, right? Would a umount -f presumably work at that point?
>>
>> 'umount -f' will kill any outstanding RPC calls that are causing the
>> mount to hang, but doesn't do anything to change page states or NFS
>> file/lock states.
>
> Should it though?
>
> MNT_FORCE (since Linux 2.1.116)
> Force unmount even if busy. This can cause data loss. (Only
> for NFS mounts.)
>
> Given that data loss is explicitly permitted, I suspect it should.
>
> Can we make MNT_FORCE on NFS not only abort outstanding RPC calls, but
> fail all subsequent RPC calls? That might make it really useful. You
> wouldn't even need to "kill -9" then.
Yes, but if the umount fails due to other conditions (for example an
application happens to still have a file open on that volume) then
that could leave you with a persistent messy situation on your hands.
Cheers
Trond
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-08-02 3:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53DA8443.407@candelatech.com>
[not found] ` <20140801064217.01852788@notabene.brown>
[not found] ` <53DAB307.2000206@candelatech.com>
2014-07-31 21:50 ` NeilBrown
2014-08-01 12:47 ` Jan Kara
2014-08-02 1:21 ` Jeff Layton
2014-08-02 1:50 ` Roger Heflin
2014-08-02 2:07 ` Jeff Layton
2014-08-02 2:55 ` Trond Myklebust
2014-08-02 3:19 ` NeilBrown
2014-08-02 3:44 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAABAsM6dNYMus3GrrHiT82-kEb_hAftXnuhSx6SXeuq-E1+JLg@mail.gmail.com \
--to=trondmy@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=greearb@candelatech.com \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox