From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f199.google.com (mail-io0-f199.google.com [209.85.223.199]) by kanga.kvack.org (Postfix) with ESMTP id 818F26B0006 for ; Sat, 7 Jul 2018 17:13:00 -0400 (EDT) Received: by mail-io0-f199.google.com with SMTP id s24-v6so12814365iob.5 for ; Sat, 07 Jul 2018 14:13:00 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id d5-v6sor634406iok.167.2018.07.07.14.12.59 for (Google Transport Security); Sat, 07 Jul 2018 14:12:59 -0700 (PDT) MIME-Version: 1.0 References: <20180622035151.6676-1-ying.huang@intel.com> <20180622035151.6676-3-ying.huang@intel.com> In-Reply-To: <20180622035151.6676-3-ying.huang@intel.com> From: Dan Williams Date: Sat, 7 Jul 2018 14:12:48 -0700 Message-ID: Subject: Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: ying.huang@intel.com Cc: Andrew Morton , linux-mm , Linux Kernel Mailing List , "Kirill A. Shutemov" , Andrea Arcangeli , Michal Hocko , Johannes Weiner , Shaohua Li , hughd@google.com, Minchan Kim , Rik van Riel , Dave Hansen , n-horiguchi@ah.jp.nec.com, zi.yan@cs.rutgers.edu, daniel.m.jordan@oracle.com On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: > > From: Huang Ying > > It's unreasonable to optimize swapping for THP without basic swapping > support. And this will cause build errors when THP_SWAP functions are > defined in swapfile.c and called elsewhere. > > The comments are fixed too to reflect the latest progress. Looks good to me: Reviewed-by: Dan Williams