From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E635C77B73 for ; Sat, 6 May 2023 11:50:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDB8E6B0072; Sat, 6 May 2023 07:50:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8B586B0078; Sat, 6 May 2023 07:50:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7A356B007B; Sat, 6 May 2023 07:50:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by kanga.kvack.org (Postfix) with ESMTP id ABCF56B0072 for ; Sat, 6 May 2023 07:50:04 -0400 (EDT) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-55a8019379fso25336197b3.0 for ; Sat, 06 May 2023 04:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683373804; x=1685965804; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W0CQW1o+U6+NILna+LXJ6vdvZ0BkUTno5y+llmnMQyo=; b=dPe2CSLoV7+FcVOrSoBizhbLXI/ZLBJ7RTaokfwOtGBTZeSTeYLGxR5uo9fELcry5s LjhkhKLm24iZteGxoktGLRgmELDQgh5dNlcPeyGuk5sDq1G+uRRCrDjHus72ClJr/jlN Ygj8wwQxJkpI0NiUvyWR8zSEsmn7rI8HLRq7PX54EoRwn1p+A3gFgHEi+yB4uztdr1JV /96WWH4Ph/4/DsPGZSncbenn9NXikntnF6iXN69jEyqz0Zn+JG/vxusicCalOspcWmzA pyHRt+NJNNIdW6RHALL/qgR/rI2RWyrjE1x52v0lj5qHj31p4GSzyvfrDe74ngZyKJ/8 RRdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683373804; x=1685965804; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W0CQW1o+U6+NILna+LXJ6vdvZ0BkUTno5y+llmnMQyo=; b=LBcyC7hlYGSK9UNl7fCucLQ6o/gOR5uZ4o+ygR1KPppv7vYbvn2ChQiaO0ds/miOVp EpJPBWt/NiDZEJoIN3YITIZzFXZlJmkbncoBChmNbXoNpWL3HJWWn6ltJ3H6UiF4jH4Y FGfgRyiaY0jmLMx6BsNg82LLDnKbgHTs7ev6NJQZpKwjr/zmN2Ic9xyK/wcEhjtbJL+2 TUMG0cM9/GYEP22HUvkOYogl9Cc9nHYxv5UBwXnCOOvZf5IQBCM3E1Its5zxj7NlPcyu bwvBIEtGPKPUEmLgGibYPVtfIHL+CG/gB+/1XEt3IjhKNpszvh4oxUwN2Iw+qK/wKfvz KKhA== X-Gm-Message-State: AC+VfDy57IZ7f1A3Du/MDFrnoIxidzSTdgtKjhhaaVrtZHj6ebLGBNhD dpmGvhAsRbHlndiRcJl8h9Jwvg43jF4l5GkbMeln0A== X-Google-Smtp-Source: ACHHUZ4FLSZFOD5iz4AdA7hPnjx4FpdcbO5UyUNag9PEgw0B19CDn88OXA+iOtElC4PtdoFYeYS+cG2LAV28KYiPCHE= X-Received: by 2002:a81:6d04:0:b0:55a:abf7:636e with SMTP id i4-20020a816d04000000b0055aabf7636emr4510017ywc.24.1683373804150; Sat, 06 May 2023 04:50:04 -0700 (PDT) MIME-Version: 1.0 References: <20230506111628.712316-1-bhe@redhat.com> <20230506111628.712316-3-bhe@redhat.com> In-Reply-To: <20230506111628.712316-3-bhe@redhat.com> From: Dmitry Baryshkov Date: Sat, 6 May 2023 14:49:53 +0300 Message-ID: Subject: Re: [PATCH RESEND 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 6 May 2023 at 14:17, Baoquan He wrote: > > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=n, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. > > Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to > cause below compiling error if PCI is unset. > > -------------------------------------------------------- > ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': > hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' > ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' > make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 > make: *** [Makefile:1264: vmlinux] Error 2 > > Signed-off-by: Baoquan He > Reviewed-by: Niklas Schnelle > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Konrad Dybcio > Cc: Vinod Koul > Cc: linux-arm-msm@vger.kernel.org > Cc: dmaengine@vger.kernel.org > --- > drivers/dma/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry