From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f71.google.com (mail-lf0-f71.google.com [209.85.215.71]) by kanga.kvack.org (Postfix) with ESMTP id 54FF36B0038 for ; Fri, 6 Jan 2017 02:09:59 -0500 (EST) Received: by mail-lf0-f71.google.com with SMTP id d16so158934539lfb.7 for ; Thu, 05 Jan 2017 23:09:59 -0800 (PST) Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com. [2a00:1450:4010:c07::243]) by mx.google.com with ESMTPS id d5si46369951lfk.8.2017.01.05.23.09.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 23:09:57 -0800 (PST) Received: by mail-lf0-x243.google.com with SMTP id x140so34933141lfa.2 for ; Thu, 05 Jan 2017 23:09:57 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20161101194337.24015-1-lstoakes@gmail.com> From: Lorenzo Stoakes Date: Fri, 6 Jan 2017 07:09:36 +0000 Message-ID: Subject: Re: [PATCH] drm/via: use get_user_pages_unlocked() Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm Cc: Linux Kernel Mailing List , Paolo Bonzini , Michal Hocko , David Airlie , dri-devel@lists.freedesktop.org, Andrew Morton On 3 January 2017 at 20:23, Lorenzo Stoakes wrote: > Hi All, > > Just a gentle ping on this one :) > > Cheers, Lorenzo > > On 1 November 2016 at 19:43, Lorenzo Stoakes wrote: >> Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code >> and takes advantage of VM_FAULT_RETRY functionality when faulting in pages. >> >> Signed-off-by: Lorenzo Stoakes >> --- >> drivers/gpu/drm/via/via_dmablit.c | 10 +++------- >> 1 file changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c >> index 1a3ad76..98aae98 100644 >> --- a/drivers/gpu/drm/via/via_dmablit.c >> +++ b/drivers/gpu/drm/via/via_dmablit.c >> @@ -238,13 +238,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer) >> vsg->pages = vzalloc(sizeof(struct page *) * vsg->num_pages); >> if (NULL == vsg->pages) >> return -ENOMEM; >> - down_read(¤t->mm->mmap_sem); >> - ret = get_user_pages((unsigned long)xfer->mem_addr, >> - vsg->num_pages, >> - (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0, >> - vsg->pages, NULL); >> - >> - up_read(¤t->mm->mmap_sem); >> + ret = get_user_pages_unlocked((unsigned long)xfer->mem_addr, >> + vsg->num_pages, vsg->pages, >> + (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0); >> if (ret != vsg->num_pages) { >> if (ret < 0) >> return ret; >> -- >> 2.10.2 >> Adding Andrew, as this may be another less active corner of the corner, thanks! -- Lorenzo Stoakes https://ljs.io -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org