From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
bugzilla-daemon@bugzilla.kernel.org, vladi@aresgate.net,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [Bug 210075] New: [Thu Nov 5 13:14:27 2020] WARNING: CPU: 4 PID: 133 at mm/page_counter.c:57 page_counter_uncharge+0x34/0x40
Date: Sun, 8 Nov 2020 17:49:27 +0000 [thread overview]
Message-ID: <CAA5enKauk_xoTvq+8iGREsmpmPw6m_eKQg8E42Hc6d6oD4hbzQ@mail.gmail.com> (raw)
In-Reply-To: <20201106211300.23179b5680fd8c83a07a095b@linux-foundation.org>
Looking to jump back into some kernel hacking again so thought I'd
take a quick rusty look.
Pattern matching a bit but I wonder whether f2fe7b09 (mm: memcg/slab:
charge individual slab objects instead of pages) may have had a role
in this bug as it adds an obj_cgroup_uncharge() invocation to
memcg_slab_free_hook() invoked from kmem_cache_free(). sk_prot_free()
also invokes mem_cgroup_sk_free() before kmem_cache_free() so perhaps
an uncharge is getting doubled up here? I traced through
mem_cgroup_sk_free() (which invokes css_put()) but couldn't see where
it would result in an additional uncharge so I may be barking up the
wrong tree here.
I'd be more than happy to have a deeper look at this if vladi has some
code that repro's this + a .config, if that'd be helpful.
Best, Lorenzo
next prev parent reply other threads:[~2020-11-08 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-210075-27@https.bugzilla.kernel.org/>
2020-11-07 5:13 ` Andrew Morton
2020-11-08 17:49 ` Lorenzo Stoakes [this message]
2020-11-09 8:16 ` Michal Hocko
2020-11-09 17:39 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA5enKauk_xoTvq+8iGREsmpmPw6m_eKQg8E42Hc6d6oD4hbzQ@mail.gmail.com \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vladi@aresgate.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox