From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF727EB64D9 for ; Sat, 17 Jun 2023 19:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 378758E0001; Sat, 17 Jun 2023 15:29:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 327D86B0075; Sat, 17 Jun 2023 15:29:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EF7E8E0001; Sat, 17 Jun 2023 15:29:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C3136B0072 for ; Sat, 17 Jun 2023 15:29:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C921EC022D for ; Sat, 17 Jun 2023 19:29:40 +0000 (UTC) X-FDA: 80913229320.28.5A5F72B Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 1610D100005 for ; Sat, 17 Jun 2023 19:29:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Tu683Aj7; spf=pass (imf14.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687030179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q3Flr21//mrp/R+bLKaAiuQMbZXMngPcVO43D7NaF+M=; b=lRpCk3XTbXeh9aZgdUi7CLI1AXquEqYXMUKJngTTstE6GdBvS4SDACJ+ObnmwRdr8Zf8X1 AQvupFU0vIyrpiaLNmdx9BIXXRzMezhB53tPZtsSR+Hrob172FnAFQ4WZWUWN/w8hKI0Pj 6nJu/MgjS/8YDvYBRDd4F/lcvqA3wMQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687030179; a=rsa-sha256; cv=none; b=D7xpO+gbN224qADwGU/CykbyEAtrKsv41bVcjxZuIL5AUPyL6cQ9WcZxkgRGFNxThbSGfF KmwcvxvWPcOImjjl1WprJB5EQfoxj8Iy7HCZvJEyrCKmD33S118pyEIFUe3cBh7D1tKOEE VldvYTASvRlTDKZegIpKSiCPx2Ve4hY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Tu683Aj7; spf=pass (imf14.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6664a9f0b10so1348372b3a.0 for ; Sat, 17 Jun 2023 12:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687030178; x=1689622178; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=q3Flr21//mrp/R+bLKaAiuQMbZXMngPcVO43D7NaF+M=; b=Tu683Aj7ojr67shcehcZOuv0zMZ5G5zTgT3Ar0HoUhoax3QZ4FabOpOAe11bA+f2Qo bT88qKtinROKN9CuI594FuNiNb2DosR4fugziuZLB6FoF3iIUjDPx8Rtc5tzVjunKvT1 okxLfH2bU0mAsIWChdbbtRLRTPTnJTTi257K1xhVGU+V70EKDn/dyEwwQPnR0W2tOezR qpeH+4Icbeo9w7uA9GwR+x5zsY8eS/RUTFa0Ne4aRg6cpuAEJ8VZhL+eqia1N1Jvuza2 3RaLFvVA/R3QhYXt3VhIO9zeP7gBHCiNPTLxV/nygq8kuy0LlDEuyuZ1vx2WG3wNZxW2 3rEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687030178; x=1689622178; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q3Flr21//mrp/R+bLKaAiuQMbZXMngPcVO43D7NaF+M=; b=JcyawwnRHFIjzQ1rPfcahvWhy84MemTjNcBHzXm3h3XF3H8azwPY9UGIMeh3afuoYA tzxaP9VlFVhHXUkm83yvduwoIyX42COMoCNZDgg0M0mtxm7sMsGsGrk+wcRgyMzUR88O QdX9y41v38WUPQRVpB5JJ7+Gj2wYuz30Wshqktdir6TFLtEXZGWzMh9Y4DAsocGrd2dV wLm5mwZlZwadPI1NN6QBxXrhsEFBrzltQsGoMU6GX/6RB5pswdbm7WODmU3L1AIlKzzZ Ak9Y+BKHoNEiL3/KawEYSMZ7h8kRs96CQnGVgsqRNiBfgB+qowQLO/Tw9rCNw+tL/II5 Q8GQ== X-Gm-Message-State: AC+VfDytcQQbHd9ylD6E9QPgfn0pVpFDO7uYUxiafvcT6A4UfGCYekpV uULVcjw+sg9vwLGrp8KogAMDlH94SvP878W1+8U= X-Google-Smtp-Source: ACHHUZ7Va0w7lbIrBj7ScFe81i5qqdhtkTbboLSWIKCteUrVIg4takHgRIqNqGvPuRuS7gl8P9ibxXLfO1qiLm1fCng= X-Received: by 2002:a05:6a00:134c:b0:65a:cbf3:4687 with SMTP id k12-20020a056a00134c00b0065acbf34687mr5743238pfu.0.1687030177819; Sat, 17 Jun 2023 12:29:37 -0700 (PDT) MIME-Version: 1.0 References: <20230613201827.9441-1-vishal.moola@gmail.com> <20230613201827.9441-4-vishal.moola@gmail.com> In-Reply-To: <20230613201827.9441-4-vishal.moola@gmail.com> From: Lorenzo Stoakes Date: Sat, 17 Jun 2023 20:29:26 +0100 Message-ID: Subject: Re: [PATCH 3/5] mm/gup_test.c: Convert verify_dma_pinned() to us folios To: "Vishal Moola (Oracle)" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: g6wr9g7s7szo1qb3mmo6k8nw7n87uoob X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1610D100005 X-Rspam-User: X-HE-Tag: 1687030178-572176 X-HE-Meta: U2FsdGVkX1/KTbGcWAYvlpqoLAN/mm1ZPKVK+zWqkQoq4QxJZftpD6/x1tBPVXiYJGxG3/fq3Xmr9UOR+zGIBTBdwPw47ZIlqQgN3YYACtSZsMKmJC2X47s8ljYBDV4Kv9f4b7ru0H2Y1jiml9amVZ45eXTau4iYEagIGG+cuFhkBv64mcx7Dc0zB45q94LIFXF08bWVsz619GZpMgpw7Iw0dWH34Og7URTUFc8aOyQ3dZxcMtWZNpITW8hjEr+mbmpuATD4Xogz2MnwRsgM92Of6v9sMvGVHwc33KW34p/v1PF3L981IYRk+K2E2zBSv39A3wfku2gUjFK/L6FigZgYMbsFTYiuEPR2ToNXhDnqiZF8atSJIMDOmHAmezw+27giTJuEbwGLADfqTiEy3SfHT2YkpMw00rvPNbLEbgGk+CAHjVWyPl4QUclyLHTk2LdSolY3fb+N3wBUx8tt3zVT0Ap1aPgBfkRcGvLAf7p05itbwT+vz/I9yCO/SCvhPYTq+HN0ib5nFnfVX07kabHrDI5Ig/RWW+wKqqMLUIfCIijMFJJB674+Fnbdp2tVErtv/z5l2DsYe54uH/68zlweSE7CPCoKpX2e5YNOJRc1Mv9bymfe1U31hsi7AjiwgSLDrmVKP8nxraIY8y4CgfADqdSdIPSOi0qsSx0mq3YmifSe2EW9TF2VSQ7I8PP1Dmyddj3UD7JN4Dp1r58D9h+Y1uzsitjsP0S9/2je95u8RWIVavPrOetDxMtEyyOC160Ev77V3IkzKNNJTSRHHHOb+hzjBOfygLUe21oGY7k+irUpdvIJ4W8FlFcLyN16yEX/RYqIKDOro9pmQFgxHqIVYstSvnecCqsf+wdWZf1MaOmQ/XNBYMuZI1Dg4u+vsfaPqawM5m/PiBNLCyZH4Ia/Ps35K0oBZh4OUA9G9HR9NknNvgyf2UpSLcckM8nMy4QNPQe98Y4eO4HUlCo R6V3fMNh 61qX6YbhNj87a5qPD/+FhGYCL6gvYRML9gh1Wu9FFtEiH2qlBzzg80/bpVwdOA1HSutknp65aALPqAazBmdbBVANA4KLVosHuDKWJj1krDmCKAmPDI7qL8lrUXb7WY+jzcKtLepjNjQl29m55LZCxIIRq4P+JYnkhdFTPXYN52yCx3RRrjulFdk435M1BaXcsXvt+BfYp65RWYbM+UHcItaBR8+gIqTRO7JV/Fxt13IwxhTYZTNA0aTKoMtGATCchyRBVmIvDPGWrnExCrkjo4hW+OL/DXTjVkpBQuGDY1+VOFFWbK3O5xSIcxkcUCHpuZPEiBjua26ZdveX/AGxQ1EonLOQh5seCq5/pGxR9Q1D7T248+pmLDy4d+MtROHDOIiNS5AWg2cf4eTc01CVwBOoEnDZe4rIRoHycBudOCbKUFl2tLLZZVydqyvL9GQclf6Pz8p+4nLRSHA5mg0KCJkgCbdcXPly+Q07jwwqTKcNEipIEKrP/A3aQ0CECsav0I9+XeIrMyu72yHCdce9hhsQFnA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Jun 2023 at 21:18, Vishal Moola (Oracle) wrote: > > verify_dma_pinned() checks that pages are dma-pinned. We can convert > this to use folios. > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/gup_test.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/gup_test.c b/mm/gup_test.c > index 8ae7307a1bb6..860b093b4b3e 100644 > --- a/mm/gup_test.c > +++ b/mm/gup_test.c > @@ -40,24 +40,25 @@ static void verify_dma_pinned(unsigned int cmd, struct page **pages, > unsigned long nr_pages) > { > unsigned long i; > - struct page *page; > + struct folio *folio; > > switch (cmd) { > case PIN_FAST_BENCHMARK: > case PIN_BASIC_TEST: > case PIN_LONGTERM_BENCHMARK: > for (i = 0; i < nr_pages; i++) { > - page = pages[i]; > - if (WARN(!page_maybe_dma_pinned(page), > + folio = page_folio(pages[i]); > + > + if (WARN(!folio_maybe_dma_pinned(folio), > "pages[%lu] is NOT dma-pinned\n", i)) { > > - dump_page(page, "gup_test failure"); > + dump_page(&folio->page, "gup_test failure"); > break; > } else if (cmd == PIN_LONGTERM_BENCHMARK && > - WARN(!is_longterm_pinnable_page(page), > + WARN(!folio_is_longterm_pinnable(folio), > "pages[%lu] is NOT pinnable but pinned\n", > i)) { > - dump_page(page, "gup_test failure"); > + dump_page(&folio->page, "gup_test failure"); > break; > } > } > -- > 2.40.1 > > (Hope you don't mind me taking a look, GUP is of interest to me :) Reviewed-by: Lorenzo Stoakes