From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE06DC56202 for ; Tue, 24 Nov 2020 18:00:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 127B9206D5 for ; Tue, 24 Nov 2020 18:00:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pbLj5BGU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 127B9206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25F836B006E; Tue, 24 Nov 2020 13:00:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 235366B0070; Tue, 24 Nov 2020 13:00:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14BB36B0071; Tue, 24 Nov 2020 13:00:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id EF7146B006E for ; Tue, 24 Nov 2020 13:00:05 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A73BA181AC9CB for ; Tue, 24 Nov 2020 18:00:05 +0000 (UTC) X-FDA: 77520075570.05.uncle87_29065cd27370 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 8BFB61801AB69 for ; Tue, 24 Nov 2020 18:00:05 +0000 (UTC) X-HE-Tag: uncle87_29065cd27370 X-Filterd-Recvd-Size: 4308 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Nov 2020 18:00:04 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id f23so29817382ejk.2 for ; Tue, 24 Nov 2020 10:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=fYTyE7YpkG8eViy0lwW5bZitqUnf4fUSbez6ArVNXAw=; b=pbLj5BGU/dqkfXQIHy6HfoGjaX15oM1/061dheT47kPyNOsa0z5PtGYVJaEm0NxquS fI4NC6EKWB676TY01x9UU7ENbdnaHipM9oWNbaq32aCImBphnni+gPQgNCj/ryzdefUj 3+75FDrayagP9EDPPp7HchzRZbbSwba5AyE6BsU1Nl50Koco8I9jz0jCOhMPKLx5PBZR 9X3++ezXlxd4FQGCNjDTGoEWnR3Rkwy9cafScXHyWwyovhomyw6W/h2CvxEx4SCE37Hi xOA9DTFPh5keL/8puE6HUMWMX8l32XQllpINeF4SyRMWLalQM4p2BMph+e4v2c4XM30/ 6xZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=fYTyE7YpkG8eViy0lwW5bZitqUnf4fUSbez6ArVNXAw=; b=aXNm5zqsm2MqeqOEANbcq+7Kzp3w6QDXBefv+3nQQFg9iI/x6FUNWAXUbVG94Xw4DS TdypFyjtFnHBMcn6eZ9iPCBetYicHEXzm9b25acCaZX7Y5JGiGcdDhKy3nSNqZCrxuCP iRbewiWV1i8vVEkxDAYCji1EC36DoipYyWXs23z6lnhieJ8hi+t4VeuniIdf0585Ww4G IUD4RM5D1jmHIKXo3/nbHNSWz+wHrcDr9dO0YgIGyy/ninKeCzw4ULSbfZMalJmrPp09 DZ/dhk0DFW7+B5f5Qe4St/v55mg5WFwNhxc6mYsBiHg/xkafMvoNFdWY75322mTHx37t uQOQ== X-Gm-Message-State: AOAM533iVA+M1DXJe+uYTmrJs3OOCXj1lwkz6SdBcRPt/ke9DSa6A+UB LhMcSxKAq8XvQgMwI/BCe66fJ6kNWanFTaA0m1E= X-Google-Smtp-Source: ABdhPJwQGfORuDlBQl+ZZrOy026YB7QsNi2Ci3nzxGJRF1RVqSyBu95jEul/If6B8z/862XgVAaaTRFzLZluul20QH4= X-Received: by 2002:a17:906:17d0:: with SMTP id u16mr5097893eje.452.1606240803015; Tue, 24 Nov 2020 10:00:03 -0800 (PST) MIME-Version: 1.0 References: <00000000000054aea005b4d59e71@google.com> In-Reply-To: <00000000000054aea005b4d59e71@google.com> From: Lorenzo Stoakes Date: Tue, 24 Nov 2020 17:59:52 +0000 Message-ID: Subject: Re: linux-next boot error: WARNING in prepare_kswapd_sleep To: syzbot , Andrew Morton , Linux Kernel Mailing List , linux-mm , Linux-Next Mailing List , Stephen Rothwell , syzkaller-bugs , Alex Shi , Hui Su Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.002372, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 24 Nov 2020 at 07:54, syzbot wrote: > syzbot found the following issue on: > > HEAD commit: d9137320 Add linux-next specific files for 20201124 This appears to be a product of 4b2904f3 ("mm/memcg: add missed warning in mem_cgroup_lruvec") adding a VM_WARN_ON_ONCE() to mem_cgroup_lruvec, which when invoked from a function other than mem_cgroup_page_lruvec() can in fact be called with the condition false. If we move the check back into mem_cgroup_page_lruvec() it resolves the issue. I enclose a simple version of this below, happy to submit as a proper patch if this is the right approach: diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 87ed56dc75f9..27cc40a490b2 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -618,7 +618,6 @@ static inline struct lruvec *mem_cgroup_lruvec(struct mem_cgroup *memcg, goto out; } - VM_WARN_ON_ONCE(!memcg); if (!memcg) memcg = root_mem_cgroup; @@ -645,6 +644,7 @@ static inline struct lruvec *mem_cgroup_lruvec(struct mem_cgroup *memcg, static inline struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgdat) { + VM_WARN_ON_ONCE_PAGE(!page_memcg(page), page); return mem_cgroup_lruvec(page_memcg(page), pgdat); }