From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [LSF/MM/BPF TOPIC] mm documentation
Date: Thu, 11 May 2023 18:39:50 -0700 [thread overview]
Message-ID: <CAA5enKY+cGjA53B4iVtKtib2=SVWNij80j+gi5U_qDN7Qf9AAA@mail.gmail.com> (raw)
In-Reply-To: <YfmD9Pa92xousy5b@kernel.org>
On Tue, 1 Feb 2022 at 11:03, Mike Rapoport <rppt@kernel.org> wrote:
>
> Hi all,
>
> I'm suggesting this topic for a while now, maybe if we finally get to talk
> about it in person something will improve :)
>
> The mm documentation is, well, not entirely up to date. We can opt for
> dropping the outdated parts, which would generate a nice negative
> diffstat, but identifying the outdated documentation requires nearly
> as much effort as updating it, so I think that making and keeping
> the docs up to date would be a better option.
>
> I'd like to discuss what can be done process-wise to improve the
> situation.
>
> Some points I had in mind:
>
> * Pay more attention to docs during review
> * Set an expectation level for docs accompanying a changeset
> * Spend some cycles to review and update the existing docs
> * Spend some more cycles to add new documentation
> * Participate in programs like Google Season of Docs
>
> I'd appreciate a discussion about how we can improve the existing memory
> management documentation so that a reader can get a coherent view of it,
> what are the gaps (although they are too many), and what would be the best
> way to close these gaps.
>
I've been thinking about this since the lsf/mm discussion and wonder
whether there might be some way I can contribute portions of the book
that _do_ overlap the aims of the mm documentation? Specifically those
parts which are descriptive, rather than the parts that are code
commentary (which I still consider to be inappropriate for, and
orthogonal to, the docs).
An example, as Mike pointed out on the relevant thread, is the diagram
I made for the vma merge cases [1]. I feel this is quite handy for
looking at this code and have used it a lot for my work in this area.
There are a number of parts of the book that seem relevant like this.
HOWEVER, there are some issues here:-
1. The book is pure LaTeX. Not sure how easy it would be to port any
part of it to the mm codebase.
2. I explicitly target v6 out of necessity. Therefore some
explanations are simply incorrect for $curr kernel, and others which
are accurate right now will be inaccurate as soon as Willy decides to
change them :)
3. I don't have the time to put in the effort to port changes to $curr
kernel, nor can I stand too much nitpicky review because that'll just
hold up the remaining book work.
So I wonder whether it would be helpful to provide parts of this work
'as is'? I am sure there are some diagrams at the very least I can
provide. I am happy to do so (and accept a GPL/whatever license for
those bits).
Also, as always, I am happy to send the current WIP book to anybody in
MAINTAINERS if they would like to take a look!
Relatedly, I am shortly going to be working on the page cache chapter,
Willy - I wondered if you would like to take a look when I am done
with that?
Cheers, Lorenzo
[1]:https://ljs.io/merge_cases.png
> --
> Sincerely yours,
> Mike.
>
next prev parent reply other threads:[~2023-05-12 1:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 19:03 Mike Rapoport
2023-05-12 1:39 ` Lorenzo Stoakes [this message]
2023-05-12 17:37 ` Mike Rapoport
2023-05-13 11:21 ` Lorenzo Stoakes
2023-05-15 6:07 ` Mike Rapoport
2023-05-16 15:10 ` Jonathan Corbet
2023-05-21 23:50 ` David Rientjes
2023-05-22 7:47 ` Lorenzo Stoakes
2023-05-23 8:50 ` Mike Rapoport
-- strict thread matches above, loose matches on Subject: below --
2020-02-06 16:53 [LSF/MM/BPF TOPIC]: MM documentation Mike Rapoport
2020-02-17 1:10 ` Ira Weiny
2020-02-22 2:15 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA5enKY+cGjA53B4iVtKtib2=SVWNij80j+gi5U_qDN7Qf9AAA@mail.gmail.com' \
--to=lstoakes@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox