From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68B53C28CC2 for ; Fri, 31 May 2019 18:27:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2606F24DF9 for ; Fri, 31 May 2019 18:27:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q3mAGvJt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2606F24DF9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B08EE6B026E; Fri, 31 May 2019 14:27:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADEA56B026F; Fri, 31 May 2019 14:27:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F52B6B0272; Fri, 31 May 2019 14:27:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by kanga.kvack.org (Postfix) with ESMTP id 6AB186B026E for ; Fri, 31 May 2019 14:27:34 -0400 (EDT) Received: by mail-pf1-f200.google.com with SMTP id 77so8038359pfu.1 for ; Fri, 31 May 2019 11:27:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=1bbOqnbmTGXv/6/haJB5JLsDUylGaUzhOYgszuwARoI=; b=YAy0HwnTaD9+MjC4lsJAQ2IAan1nuO5w3HtPoDKMPfKXYpYn7E+JMctsmAmENLa36F gfk2QD2hcmtsOxYoNtWsKabwGGm+OEzl/3QHD5sJOMeriia6BAw5kTy+JQnPrcfobpD3 uctTQxrE9V1tXZE3y8bn5TLJqhQrebMrDjDNgiUCYZQ1UAp/efPOKLvqQodGBZxz9KPF bJZp2/nPHvsVLOUOXd9z6sVWOGGKt5d4CRI6Sb2NY09JoWo1QB2t8HmWJqibgQIuz1Jf IbaNMinXtUZXMm1B/lj3bol0auA0LSYjslm4w5Phq2Fx+u5LEjwtjDIcL1zAKOQaS8Ss 7ETg== X-Gm-Message-State: APjAAAXWtPg64Y8WuVSgN5lHKc7R9jL56u3ycM0yy6KIUvJScEcPPLdN 5yPupc5iyKjMFiOb8H4kaEPsxhnGkwaPDk1irQWHiAeGlUMzTvDdVZa/qLPqtrcqKLrnU/pN2Ex v4zKRSqvoUwWhMIzwSkVcrq3k73Pa1tEndkkU6UDLtV6I15xSYTFNVwpaNW0m1XdVOA== X-Received: by 2002:a65:56cc:: with SMTP id w12mr10845886pgs.415.1559327253905; Fri, 31 May 2019 11:27:33 -0700 (PDT) X-Received: by 2002:a65:56cc:: with SMTP id w12mr10845789pgs.415.1559327252821; Fri, 31 May 2019 11:27:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559327252; cv=none; d=google.com; s=arc-20160816; b=FGPtHb2VfGQ63gBBfsNQ7a7DK4Zs8A25C1X9W0l3sltP9CZWLuHnZTmlsy3cYG4QS6 GTEsRAySIiXnCyVgHfu3dMbxoEQus3Ys0xAhEfpHwpzbo8p6Ni87PD2hCgF4pbVf5RGE 1IvBP3LJ7SHfswcLi/w3dquKOd95ocjYKtCj4u4P5fQid4pCQ1iVSykRUPatlnl2R+DE X6ke0Yuaa8GVrcjjGVQDGlYQonP6MLWdVDrmv3Bb3T8TH7hyEZjnkCt735JZLAvazHoM FGP7OJ5nxzvEeDjG8tjuAeg1bIYZUbxqFJ+DPcOUYM1gSteXiEYnzvtJNyrVnzrpomxQ Zx/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=1bbOqnbmTGXv/6/haJB5JLsDUylGaUzhOYgszuwARoI=; b=doPwq749AkNYxxk6sJJPov0VXbcEf9rrVCyS8ITPh5/ePr85B2mSln+E/jg5C48oja QmWvPbReAW84lJFDYrl6yqEbzybrD/sC86+aQTZLT5LvEDCPgvqJv57QaQvNRL+u3YqD h6O44oxJNWUECHRwIFFPPTAd/cGz6D+YmbAyYsyGEmU+4UG4TkT7qS8nxSIL50Ib7K/k Fb0b+f83sUkyiDCfqiINzXfKmXBGZoTcssPJSOoUGiQjrQeqsA7YdsH5++A9qrm+N7VY MwrDdJN//2qo/WEToCZFxb/PhEgjzs1oCQhy3Edf8Ggr4ehBz69kkFlW/R0VeZUK14MI bwqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=q3mAGvJt; spf=pass (google.com: domain of dexuan.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dexuan.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b4sor6700077pff.16.2019.05.31.11.27.32 for (Google Transport Security); Fri, 31 May 2019 11:27:32 -0700 (PDT) Received-SPF: pass (google.com: domain of dexuan.linux@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=q3mAGvJt; spf=pass (google.com: domain of dexuan.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=dexuan.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1bbOqnbmTGXv/6/haJB5JLsDUylGaUzhOYgszuwARoI=; b=q3mAGvJtn/FGfV5nqwCBNUkHV2yfFVW/ZH8teze3YIS4vx/yz/KQVsxWIOgvan37n+ 9aaMX2KNuiMUxYhFH6kCLdCQ3lqWNoMxLoxYJqIhqtF48CAR70F2hCzaMzru8Ue2eNY1 OITa4PMxjQsb6BVOdunQQK3xduHsxEp2ycL0+7h7q7pA8UuF40TYB490dwb5KADwoPQs dxZiMKY4WMl5pSPIJOUaN9hqKQw2Sp7woWaQCcEgj3IaOi+F37mktiz05ih+QSihJ1YW SQKn7HlK4ZZtKEGBtiweqZuqbFCtqwR+7dOYJCovF+W2YnHoLetG00/2f7hP9XNt1Mgs JTbg== X-Google-Smtp-Source: APXvYqwQMcr1qn0FkaYD3DdOVIWXjRV6sg40ZSZOHCBykJYBOaDa1v/PIa0HksZ5+N2GYPqKhF22NlekYme7g+TIHug= X-Received: by 2002:aa7:8dc3:: with SMTP id j3mr12239577pfr.141.1559327251853; Fri, 31 May 2019 11:27:31 -0700 (PDT) MIME-Version: 1.0 References: <20190531024102.21723-1-ying.huang@intel.com> <2d8e1195-e0f1-4fa8-b0bd-b9ea69032b51@oracle.com> In-Reply-To: <2d8e1195-e0f1-4fa8-b0bd-b9ea69032b51@oracle.com> From: Dexuan-Linux Cui Date: Fri, 31 May 2019 11:27:20 -0700 Message-ID: Subject: Re: [PATCH -mm] mm, swap: Fix bad swap file entry warning To: Mike Kravetz Cc: "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, Linux Kernel Mailing List , Andrea Parri , "Paul E . McKenney" , Michal Hocko , Minchan Kim , Hugh Dickins , Dexuan Cui , v-lide@microsoft.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 31, 2019 at 10:00 AM Mike Kravetz wrote: > > On 5/30/19 7:41 PM, Huang, Ying wrote: > > From: Huang Ying > > > > Mike reported the following warning messages > > > > get_swap_device: Bad swap file entry 1400000000000001 > > > > This is produced by > > > > - total_swapcache_pages() > > - get_swap_device() > > > > Where get_swap_device() is used to check whether the swap device is > > valid and prevent it from being swapoff if so. But get_swap_device() > > may produce warning message as above for some invalid swap devices. > > This is fixed via calling swp_swap_info() before get_swap_device() to > > filter out the swap devices that may cause warning messages. > > > > Fixes: 6a946753dbe6 ("mm/swap_state.c: simplify total_swapcache_pages() with get_swap_device()") > > Signed-off-by: "Huang, Ying" > > Thank you, this eliminates the messages for me: > > Tested-by: Mike Kravetz > > -- > Mike Kravetz Hi, Did you know about the panic reported here: https://marc.info/?t=155930773000003&r=1&w=2 "Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: write_irq_affinity.isra" This panic is reported on PowerPC and x86. In the case of x86, we see a lot of "get_swap_device: Bad swap file entry" errors before the panic: ... [ 24.404693] get_swap_device: Bad swap file entry 5800000000000001 [ 24.408702] get_swap_device: Bad swap file entry 5c00000000000001 [ 24.412510] get_swap_device: Bad swap file entry 6000000000000001 [ 24.416519] get_swap_device: Bad swap file entry 6400000000000001 [ 24.420217] get_swap_device: Bad swap file entry 6800000000000001 [ 24.423921] get_swap_device: Bad swap file entry 6c00000000000001 [ 24.427685] get_swap_device: Bad swap file entry 7000000000000001 [ 24.760678] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: write_irq_affinity.isra.7+0xe5/0xf0 [ 24.760975] CPU: 25 PID: 1773 Comm: irqbalance Not tainted 5.2.0-rc2-2fefea438dac #1 [ 24.760975] Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine, BIOS 090007 06/02/2017 [ 24.760975] Call Trace: [ 24.760975] dump_stack+0x46/0x5b [ 24.760975] panic+0xf8/0x2d2 [ 24.760975] ? write_irq_affinity.isra.7+0xe5/0xf0 [ 24.760975] __stack_chk_fail+0x15/0x20 [ 24.760975] write_irq_affinity.isra.7+0xe5/0xf0 [ 24.760975] proc_reg_write+0x40/0x60 [ 24.760975] vfs_write+0xb3/0x1a0 [ 24.760975] ? _cond_resched+0x16/0x40 [ 24.760975] ksys_write+0x5c/0xe0 [ 24.760975] do_syscall_64+0x4f/0x120 [ 24.760975] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 24.760975] RIP: 0033:0x7f93bcdde187 [ 24.760975] Code: c3 66 90 41 54 55 49 89 d4 53 48 89 f5 89 fb 48 83 ec 10 e8 6b 05 02 00 4c 89 e2 41 89 c0 48 89 ee 89 df b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 35 44 89 c7 48 89 44 24 08 e8 a4 05 02 00 48 [ 24.760975] RSP: 002b:00007ffc4600d900 EFLAGS: 00000293 ORIG_RAX: 0000000000000001 [ 24.760975] RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007f93bcdde187 [ 24.760975] RDX: 0000000000000008 RSI: 00005595ad515540 RDI: 0000000000000006 [ 24.760975] RBP: 00005595ad515540 R08: 0000000000000000 R09: 00005595ab381820 [ 24.760975] R10: 0000000000000008 R11: 0000000000000293 R12: 0000000000000008 [ 24.760975] R13: 0000000000000008 R14: 00007f93bd0b62a0 R15: 00007f93bd0b5760 [ 24.760975] Kernel Offset: 0x3a000000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) [ 24.760975] ---[ end Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: write_irq_affinity.isra.7+0xe5/0xf0 ]--- Thanks, -- Dexuan