From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 274CEC021A9 for ; Mon, 17 Feb 2025 21:33:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB069280074; Mon, 17 Feb 2025 16:33:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5F86280075; Mon, 17 Feb 2025 16:33:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A270E280074; Mon, 17 Feb 2025 16:33:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 85BED28006F for ; Mon, 17 Feb 2025 16:33:00 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 05F43A112B for ; Mon, 17 Feb 2025 21:33:00 +0000 (UTC) X-FDA: 83130736920.30.AD440BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id BB8624000F for ; Mon, 17 Feb 2025 21:32:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZbWICnnx; spf=pass (imf17.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739827977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wjr6J6DOeZeSoS3UpK+LIJot/A4kSVDwCJKjvWd8g2s=; b=lgQP3wsXPpixKyuTVXCqaccyd8n9jq/lcMYnPuKmFUq4RdwB1LBEBdBOJWj6MTlCNOujcL xOlMlNjLIrasiKtocOQ//v94TdLmfJPuZMaNVMqr8pTH64tjdm/UoQNUznpF525fC9zDnk 6kcZ0Og4h2lzF/F1UBpGkwh2OPCB/bg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZbWICnnx; spf=pass (imf17.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739827977; a=rsa-sha256; cv=none; b=FzahinaGfDo7/yTSGPV+aruVR+Ue/LA+EOAp3ZcDBNmkD9GAP7VwSmKDwJpWbONnTRF0Qs UvAcE+19Vy6kIs8h0U2u7eT/3jzJSjZ1S9XqZUgGJ7FCRxIAy/L/0RuAP/WxVNRj9N8qNR c7epUAauj65bjF879E0JuGDSw20AcZs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739827977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wjr6J6DOeZeSoS3UpK+LIJot/A4kSVDwCJKjvWd8g2s=; b=ZbWICnnxxESrpvcSzQmZPtUxUBiBVoHBmr18ldAxk1xNQepSGrGPshmNbSYItkMwFJrtIR 2A+QrpvCOfmO4GRjqObwo8wG0GPDC7DFfTOqwTWVQ5M73rTLXLYtQtVfbbuZz+AIHyTJa2 3KjNdVnZBAF7zjm4B7HpvJC7vN2Tyyc= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-TNIr6wqIOTOOIGlHKPhs-w-1; Mon, 17 Feb 2025 16:32:56 -0500 X-MC-Unique: TNIr6wqIOTOOIGlHKPhs-w-1 X-Mimecast-MFC-AGG-ID: TNIr6wqIOTOOIGlHKPhs-w_1739827975 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-6ef85037f3bso81729937b3.1 for ; Mon, 17 Feb 2025 13:32:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739827975; x=1740432775; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wjr6J6DOeZeSoS3UpK+LIJot/A4kSVDwCJKjvWd8g2s=; b=LIJ9YYeodlqA6r5zIuMVldHfdj8H2lk8JHEmf0RvJ46/QzjhuefiEuDULltJo28Qmh G6fiKfyolaIOU7jYFFZkPt6TitQCIYkUT5X/Ex8CNBqhuTSkT3ReXMyAYKQNaYWwRzMp Av5tB4Hf/6OmC6wT2NavqM4A+YHQ/4w/wQwHBzzolOICQqjyQhs7W2Ylr54vUHQT1QMR 5OqS6uQ53Ej0EvCvQMtseJW/TvyUw2DcTUhLyhXsB+qm30Jd+HUzAq16ZR5Ifwl/pouw vRKGMy91OqTURR1uJE0rolVen9IdmGAYC/WXKgwyazJe+zcJn957tIEe/GuRyu4e0jdS W8Ig== X-Forwarded-Encrypted: i=1; AJvYcCXLq4Odcj3R4ryf+QzmPbdmSm4+ct4O17SwZ+ss3iSmWtDhqv2V46KQSaebiIG8/SJP9xvLPMWp5Q==@kvack.org X-Gm-Message-State: AOJu0YxB65cSiZmJGl0ufKggQfD4so5g8VNkrIaojItz4U/PnlRg2F9E XaxvDUpPiSS17kq+5dZruIXA2xxsgP/3ipzNYxGxDOxD9rtFNDD0u1OubBQ/NpUlwM0WEhabb1N xFg3QSJMfXDlcGiprC2nBA0lCAY10JT20bGRUT82x6BlHzsAJAEN0EoU55snFuhRbRMzAb3uVKM mwVXTwSG3sxDWheG5Iek9sPwk= X-Gm-Gg: ASbGncsY9I4RePx2dImSNEExXX9oMEXyQ/ZrOvhgl0OmTFLdfA8ukwEVCSmCsMsiYAF uDTclUUPVtRIQYOjazI2/R+WzlFawrVO6mUWsplg9ZMGDUHHLaOPq15qYNwIMUiazSYlXkQYJ4X Q= X-Received: by 2002:a05:6902:2102:b0:e5b:45eb:dbfd with SMTP id 3f1490d57ef6-e5daa4c6821mr16623487276.11.1739827975044; Mon, 17 Feb 2025 13:32:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOkZYdxA7+HLOKnLODZz3B+t380yGAD+5tVKQqEu4d65LXrhAQ59NLa24+U3g/GCY/e81Og/sTryAx1QenBGY= X-Received: by 2002:a05:6902:2102:b0:e5b:45eb:dbfd with SMTP id 3f1490d57ef6-e5daa4c6821mr16623479276.11.1739827974804; Mon, 17 Feb 2025 13:32:54 -0800 (PST) MIME-Version: 1.0 References: <20250212-kselftest-mm-no-hugepages-v1-0-44702f538522@kernel.org> <20250212-kselftest-mm-no-hugepages-v1-1-44702f538522@kernel.org> In-Reply-To: <20250212-kselftest-mm-no-hugepages-v1-1-44702f538522@kernel.org> From: Nico Pache Date: Mon, 17 Feb 2025 14:32:29 -0700 X-Gm-Features: AWEUYZmwEXuqxVjY66-BVM_Ib4FZYHb37Giao24vLwf7Z76BXTlSrlgRvS3mTD8 Message-ID: Subject: Re: [PATCH 1/2] selftests/mm: Fix check for running THP tests To: Mark Brown Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HpOvdEK2hXoi7PCL-9UbQVEuDopTmYngnmCplTOg83Q_1739827975 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BB8624000F X-Stat-Signature: wu95doy13iaw7ohpae5ifykkwciptpkj X-Rspam-User: X-HE-Tag: 1739827977-290254 X-HE-Meta: U2FsdGVkX182maZ2X9fOEdYYd1KoL0rm9ixqi08ywM81I0Yt/gLGrBxvStoxhNp++FLm6ukM/PzV3AWkSpH5FffOIsnUr6YF+kX5hoa7PbQ7yd6YdILEZeiWO/V8HGaIJn6Ch0EuqoLPeZMudnw6AY2XIMG1DXHZzxdDwle4zcbZFRwDSf4S9l4/Z2wJulJ1sCH1zngF62E70EYZwBJoXmQusCVNfLnYAnyEe0pQ/f6vf/J7DVnlTZbVHBAb1tp0PAL/t7bHx9jGP3KJejNHJpiVFol/zgNYIb6HVvsD7Kp1Z/TSjPBxnoo7jS8Wh62h0uomwumFfPZCYY0r3wnI0Sd8yk0WTCiV2fZRslME2ae36qssMU5+Rl3keY6E/C2zuM9c3FKXd299ok53CKsOsyRt35wwrFVrQdBAiEW+RruNB0S5JddIxSkDhPkUNzQ/xiRUEentFwLwqEKBO+AqHjYHfZ/BfV5C9N6QcFP5nELZdRFg99uBMifTQggTj3pV4pHur5Wh0ceRqwcDDVmgTOxLT5noYkeidBBmGRCxVbx9TQ6QMGDR15l4G/s7LdEM3L3uOBC90NyeztDFhufp3+0HXyGc6T0AHbbcv663up8vQwSTycb3ExljvjIbg1OWCCAjtzuaOEoBJzyen7aWaG9YVKWv8wQE9Ub81a29O5ecQUhTA9Y14+5iYsdI7UFBNIChUgZ3Wg70f63NKD3fZU+Awq0hcRfip82zuHlkzAsGnaBxoLkLebWCXFV1FXysmHJU5gRgTzRLpgx//Wz2Y1R/PrQrt/hH1gm5Bu1vSvE3Q35FMOLLDsrxQOJTxMq0obD+JeOT/l5U4e+u606E+gtb7F6qC0fJsZd/ZLgs6lhK7iD/vFaV45x3kEE8sLjzcFxayygF+1DC3U16w5z2DRJrrmw9oTf/2M9w5lPp96Y2f4ZwcEPqFPZrFjbBp3fAPE8619mvmOwFI4TmIIu 18JQ6pRs USuJqyzTW+kEAVBYyrQUvq+6PgVWaYgFWLHi7wYArtV/g15foJf/QcxjjJNkAEuJM6FcCSF5HmvJF+dadRe3usjKrh3VMjTufplcOqPADrsqOII8TP4L1MiRQuyYya6dSGGEltumvAT0Ph5HRW7cRV0GUnqSRikZUGotUEd4jRe9DPJ8nYzwMWwzNHx6opGsh3/7IPqqKwyBgx9QGePdiffI8eSjo1qo9hpzUzqo0T4zX8bysbXYjSe9psUvewYIJ7ZaO2iUEDF9ALVMnSRGvMZotY9hsa5ekvaNA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 10:52=E2=80=AFAM Mark Brown wr= ote: > > When testing if we should try to compact memory or drop caches before we > run the THP or HugeTLB tests we use | as an or operator. This doesn't wor= k > since run_vmtests.sh is written in shell where this is used to pipe the > output of the first argument into the second. Instead use the shell's -o > operator. > > Fixes: b433ffa8dbac ("selftests: mm: perform some system cleanup before u= sing hugepages") > Signed-off-by: Mark Brown Ah I meant to use || which i believe also works in shell. Thanks for the fi= x! Reviewed-by: Nico Pache > --- > tools/testing/selftests/mm/run_vmtests.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/se= lftests/mm/run_vmtests.sh > index 333c468c26991421cd8f9ce6d995f9b64b0643c7..da7e266681031d2772fb0c413= 9648904a18e0bf9 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -220,7 +220,7 @@ run_test() { > if test_selected ${CATEGORY}; then > # On memory constrainted systems some tests can fail to a= llocate hugepages. > # perform some cleanup before the test for a higher succe= ss rate. > - if [ ${CATEGORY} =3D=3D "thp" ] | [ ${CATEGORY} =3D=3D "h= ugetlb" ]; then > + if [ ${CATEGORY} =3D=3D "thp" -o ${CATEGORY} =3D=3D "huge= tlb" ]; then > echo 3 > /proc/sys/vm/drop_caches > sleep 2 > echo 1 > /proc/sys/vm/compact_memory > > -- > 2.39.5 >