From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD94C28B28 for ; Wed, 12 Mar 2025 20:15:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11C7D280002; Wed, 12 Mar 2025 16:15:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CD38280001; Wed, 12 Mar 2025 16:15:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAF83280002; Wed, 12 Mar 2025 16:15:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AF376280001 for ; Wed, 12 Mar 2025 16:15:30 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 16FDD1CC677 for ; Wed, 12 Mar 2025 20:15:32 +0000 (UTC) X-FDA: 83214004104.14.81474BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 8231E180009 for ; Wed, 12 Mar 2025 20:15:29 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NNSKy2FN; spf=pass (imf24.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741810529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qLkIeO0MCQT7MR4XxoTZC2Dt6fLNdFPHwBMGedp21e8=; b=fua8S9C/Vt62p0/9dvudu6nMlYmG042YIbA6AInG6yUx/olqSy+fSKWw71FCB8i2hYHjQb BYge5PwLg4WUk9BlF/wjTFZtE/z1JsZIJ3lzOPVVSKOL2OFCSwWZJiCi9MrXRs0v8ZakDt XmlEWkNZ+Li1mnP76sLGR0ukZxDLR8M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741810529; a=rsa-sha256; cv=none; b=12d+WFYvZam8eWYxVHzH3RTZUYUyhhHrysviIh77kaf2A5k8xbrzCTRLaTNn4NVSIa6KcH dcoR8bqk2MEDGqYNcSxjHFAtTA8/4da4fMnh9JyyN01aCaB4sk4HJ5HIX+15pz7S1M3RM6 GANqAFXNXGkyeQz3yeQN9CkbgGNdzWU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NNSKy2FN; spf=pass (imf24.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741810528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qLkIeO0MCQT7MR4XxoTZC2Dt6fLNdFPHwBMGedp21e8=; b=NNSKy2FNCLPNnDQHZISUFAEyFC3JJ/fEsdltxdNWRz8M/tA3su0TIn/wmCgAhETxIF71Tv T2D7YDs7llt2SSX1GQWahlCGajnlmBhwoo9Fh08SFZSF1z4ba2VXA36BYLjLEpxG6vzUBb 1LRgbLE42aaRzhG+HG181z45a1Fikg0= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-Wc_fe57HMD-ZoHiIuUmZmg-1; Wed, 12 Mar 2025 16:15:27 -0400 X-MC-Unique: Wc_fe57HMD-ZoHiIuUmZmg-1 X-Mimecast-MFC-AGG-ID: Wc_fe57HMD-ZoHiIuUmZmg_1741810527 Received: by mail-yb1-f199.google.com with SMTP id 3f1490d57ef6-e6345bc7bd7so1892421276.0 for ; Wed, 12 Mar 2025 13:15:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741810527; x=1742415327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qLkIeO0MCQT7MR4XxoTZC2Dt6fLNdFPHwBMGedp21e8=; b=ivg/GldObYTZSanAexvvVlrJKMC5HYkw27Q6Q1xObZ1xO7jpkNVtS7wIomAlaqLDFY KFxQCh8dnlVqw4UQSHbwMxvJ3yoXfYgbdFvm4Th4NPo7/WeISzciME8GeUakS1STVdUo fBH3o/una8Kb08dxkenJevJm5xFRktPt7LiHp9SRykRnEnplsTwq6mPr6zpeJGmWlaa4 tl2UCx1fn3YaYaqq7lxyfcfHtsDWoD5oRh4Fn5xqqg4G6TZ1NzFhgegdEGOtKaBCHKM3 IsB30XgUYOL2xoZKUkfn+R2Udy/bHRr0LGFH/TYUfd9DE3lE1lOCs3KlC3mvGnOSRla+ KHPQ== X-Forwarded-Encrypted: i=1; AJvYcCUu1QujO9bqZODJ/DGrxt+EsneWlfcPg4mtOC4msIcSMffKaJ1VtX+QPILRWRtfuB/g4Fbmvcl90Q==@kvack.org X-Gm-Message-State: AOJu0YwNxMxwCq3NFrqdKXvKkTEyFlgkGqRjEb7Nva64OYQeF3OYOhqq Dbq2YhqtcZDpYd+KBmJRUw9DLkmojnqPlfVKTTW9KNR46YQTThvmR1GrRdP7O6B+W3FZyckMf6D +3sU/1l/0iFl/4QVOwdu1nZSmTzEkj/oZvNZ59dMpB8aU38gTsBZyVeMt/8swPxPnKVP5KVHH3f SNtxqEHebZ720k5z3hKCNsyyE= X-Gm-Gg: ASbGnctfzV+NfFQRJY3Le4gQSi+5uyu/3J2Tbs+O1xk9SS59oDtHdt8NEpLQT8f4HXN dlxs/SwU8VUUdcTp5twnOPSIsVSkdoUtG2ZFWy2plXOuta6XOkXTK6a0udzMt4+OvYTfz5h+bLJ /5eJZVtjvOfAI= X-Received: by 2002:a05:6902:1b8a:b0:e58:cb:70f0 with SMTP id 3f1490d57ef6-e63dd280e5amr1426495276.6.1741810527116; Wed, 12 Mar 2025 13:15:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRjCueQJTtD1Yip12lTSRS0J2WXsza8uUs7pkqkkc4WEhTu9c6Jn8ZqT/i5u+iVlL2g8+CwS2JOOpWtSQA1o0= X-Received: by 2002:a05:6902:1b8a:b0:e58:cb:70f0 with SMTP id 3f1490d57ef6-e63dd280e5amr1426459276.6.1741810526854; Wed, 12 Mar 2025 13:15:26 -0700 (PDT) MIME-Version: 1.0 References: <20250312000700.184573-1-npache@redhat.com> <20250312000700.184573-2-npache@redhat.com> In-Reply-To: From: Nico Pache Date: Wed, 12 Mar 2025 14:14:59 -0600 X-Gm-Features: AQ5f1Joh0g4Z83aGfjvoE-bfcrPmBotalHWvxVjzooJnUWJwOvfHN9lhNGt-h0o Message-ID: Subject: Re: [RFC 1/5] meminfo: add a per node counter for balloon drivers To: Shakeel Butt Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jerrin.shaji-george@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, mst@redhat.com, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, nphamcs@gmail.com, yosry.ahmed@linux.dev, kanchana.p.sridhar@intel.com, alexander.atanasov@virtuozzo.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: olIgzVrl1zyKVhs2qHVv7xhkTfa611QrCqHgTe1q-Cc_1741810527 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8231E180009 X-Stat-Signature: pmg8g43tmkjkxo4dg6b7e84np7xdxqj5 X-HE-Tag: 1741810529-251977 X-HE-Meta: U2FsdGVkX1+f0AkUiN5xcS1OC9eQyEK9Kne6pUsuFYo9URGD2DcDrveOorvcPlOTRRfbqPSPlpgb2CsfKXQ1cy6HY3fKD1ZPCe2zB2g0DRwOCazbqoA5cr/l9luyoYrU7/sgTf0YKQL1IovFD6bsAd7OxoYPYtUvFi9WFHorg/LOtM25dlYLyvXryPCeKTJx3L32AvZyhNK8sVe33KkAcwUQPXrZhsz7NeAW4lkEToqqvkMmFRoN8O7JxmxWje7pM9IKh/2UbCf1MV3gH8i1M9EpjVFfLv1qwZDg/G2es20WhR1FOU4vma9YPFkDdZyNgVYqphHIHPg5llxQ8aqWy1tJBt5BBWLwU+jU/418OiafatzpjLYK2Jb55taoBB4QydADjkUrwPBBYDWYyCQWkFEs2SIpII6u1RKmyrOKYPAJB/n9ukjf//z4tiS8wCQ6I0ZHE67vX1wGtvQS2BCL25HM9h5iY+LMlpndMZ4gxkEWA/fzvsYv4r4rRVNg5kS39K46nXURm9IvoZfFaaVkrKj6euzI4c4g5MJbOTZjErVVzp2l3FKdrfjmF/wcYuTRQr5MDK9GVfYYf485W4H5tuRLB1zvTrZ1yM3npmsOECdK2vTBheGkEg49ZyPqYXZlkJpLoVsrC8skbdHN4VnSUFyhxK/7xXRrfp0PqyBqPLLFFYF3gBbbBeEHcLZ7/eAmYx8Chthrhm8ixFgVYqTpFUqksl16CBTsCnTPoxkw5HFG/DyHAY7FGvcTlhAXcpcGjHLEj5Dn0hynj/UW2SCkmODyk7/dbtgWA3UMmrRxrmbrjpj3/0oOWzrwtTXT6NxLZxkJ/f5VjlTC+HYPN81XFjKsZi9dl9bTFn/llJ9VsC9vpoGy4Cu9+YxXWreAjbDja5BGqc9dfoerGfnr7U11thcG1GF7CXcMUWrchL9Rkdd/M18l6+u1tUOFigGz6At7zjuAr7H53UJvxJ5QjCq B1Vk81Y6 qrwOgwnM67eYdf+UCNgnnJLQsZcojjxrawjUPlhKU8+H6mFNl49wFJpoS/N4Pv1Lvz/z3PMyP3kMYnFA5gJZ2NFTz6LylfHUJUDoHNmFbahvLgts5Yh1yc+r4IVdBkbRHRXSGbNWsGchMJoQaRNrOLVGu90eaZXpNymp4jFv03F61f/97WqnIzw/hlEI/4LzMW7f88lA51HHhBXzfsrXd/8Un2Cy4+AQGe6FEo/lA5bh2uN7xKEUgX1bQdbYdga+2b1O9gFLe7Kbmjb+sgVRC6uEd8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 10:21=E2=80=AFPM Shakeel Butt wrote: > > On Tue, Mar 11, 2025 at 06:06:56PM -0600, Nico Pache wrote: > > Add NR_BALLOON_PAGES counter to track memory used by balloon drivers an= d > > expose it through /proc/meminfo and other memory reporting interfaces. > > > > Signed-off-by: Nico Pache > > --- > > fs/proc/meminfo.c | 2 ++ > > include/linux/mmzone.h | 1 + > > mm/memcontrol.c | 1 + > > mm/show_mem.c | 4 +++- > > mm/vmstat.c | 1 + > > 5 files changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > > index 8ba9b1472390..83be312159c9 100644 > > --- a/fs/proc/meminfo.c > > +++ b/fs/proc/meminfo.c > > @@ -162,6 +162,8 @@ static int meminfo_proc_show(struct seq_file *m, vo= id *v) > > show_val_kb(m, "Unaccepted: ", > > global_zone_page_state(NR_UNACCEPTED)); > > #endif > > + show_val_kb(m, "Balloon: ", > > + global_node_page_state(NR_BALLOON_PAGES)); > > > > hugetlb_report_meminfo(m); > > > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > > index 9540b41894da..71d3ff19267a 100644 > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -223,6 +223,7 @@ enum node_stat_item { > > #ifdef CONFIG_HUGETLB_PAGE > > NR_HUGETLB, > > #endif > > + NR_BALLOON_PAGES, > > NR_VM_NODE_STAT_ITEMS > > }; > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 4de6acb9b8ec..182b44646bfa 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -1377,6 +1377,7 @@ static const struct memory_stat memory_stats[] = =3D { > > #ifdef CONFIG_HUGETLB_PAGE > > { "hugetlb", NR_HUGETLB }= , > > #endif > > + { "nr_balloon_pages", NR_BALLOON_PAGES }= , > > Please remove the above counter from memcontrol.c as I don't think this > memory is accounted towards memcg. Fixed-- Thank you! >