From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9027AC369D5 for ; Mon, 28 Apr 2025 15:44:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC9756B00A6; Mon, 28 Apr 2025 11:44:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A78336B00A8; Mon, 28 Apr 2025 11:44:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 940D26B00A9; Mon, 28 Apr 2025 11:44:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 760866B00A6 for ; Mon, 28 Apr 2025 11:44:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8BE4D160A40 for ; Mon, 28 Apr 2025 15:44:44 +0000 (UTC) X-FDA: 83383875288.04.4195378 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 343DD180007 for ; Mon, 28 Apr 2025 15:44:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fqSOJYxM; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745855082; a=rsa-sha256; cv=none; b=f7AuX3EDggb6dktF+zIGxhjsEuVISrXo/8dseuO7Udn4YnivC9T66vl0jDb4Xr7TOkr6T1 1fvqi7sUOL77JT9KpPwuFGzmO/T6qvevWpKQMX6Ujtfq7zDSWjzMjH7iTExmUGKtkyOMmP h3Yu7LByCC/xdniKtJbTexAvpFwlWcQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fqSOJYxM; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745855082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pxbbN4qJN6Ru59aJPa/Q4S65KBGqqKkgsmmSWCFTdOU=; b=qQ4ZffrxyAO7BXeLlWfAKw4E5/SmTeOJ41XrAujw8deuHWFAkvMNfP2yU+v0X8BRytUP/S 5xAiGJ5x7nAVRHNY39htiTcFzi9ixfz7UywYz71+nXlMX3ZKwfosTk1cBj1n7/SwlepjwA wGh0Rg5VpN1cxFBAk4l9PM8ERdeyRSM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745855081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pxbbN4qJN6Ru59aJPa/Q4S65KBGqqKkgsmmSWCFTdOU=; b=fqSOJYxM/5BYZZB6N7hxcJHRKxRNBs+Xc2s/iIG6Zfplgm16rvo3//EBXmQtKJ1EvS7ikB vkMBlEL8slQWNkdtTByJQMuUB47/p4iJmDtEk+EocanH17wpzIdTtnWLTG76KtgqYfCMRq aIYScnUtsvt+2Q5+854aJOBbiaTHH+k= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-5pWMsM9aPjmyTyqr6sD1pg-1; Mon, 28 Apr 2025 11:44:37 -0400 X-MC-Unique: 5pWMsM9aPjmyTyqr6sD1pg-1 X-Mimecast-MFC-AGG-ID: 5pWMsM9aPjmyTyqr6sD1pg_1745855076 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-706b9f19d8bso53740817b3.2 for ; Mon, 28 Apr 2025 08:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745855076; x=1746459876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pxbbN4qJN6Ru59aJPa/Q4S65KBGqqKkgsmmSWCFTdOU=; b=Tb1+Zz5+yT2E7JwkpULnRM+r9OBinF+fHd8GSLE2o/dBYxgDdwKJUmyUnM9QheYxta LTmlk6IxhjoE7npwSn+CNxHJNobWlJZSIXKWLfDmbxB1oV41Ny7NKHec40tCwJr5VC2Z udwcSn4U4stzijSU7NGIk+Y4hWkQuDOj+b3LlLsF8ssLzFg3vfDY8Gp59sQl1roEI2VU F6zGx6UYxHJx/0j3f0FbF3iJEQoMtiOkj5qH/7RU37cvlnuYDDHdGENOfDLgJI0kulsy 3Pqi8fjg1zYAs4eweXib6UuMBQsypxIi6gZTQa1QeTbJLpUL6sNmmIjO9SDNwnleP+5R nyqQ== X-Gm-Message-State: AOJu0YyEEqmNNvVsirnxM5pQdZbWYofSjWlhTX20BehHmDs/HVSAj1Gk 3EPiM71L+ZPGwxfC6O1kporI/3NtZ8IMaRvK4CYuLK5PPpFl4dj9WosxDtniCBPrV9yTLmfj14g jaEU/QURIv1zl2Pcm/Hf4wvuQgAWBNf+oELfrqgWiOvUvCxIeliQbiORVs28RgGfvPDkO5Ks+Z4 okQVpGKzlkkvw3twAHMBrURZ4= X-Gm-Gg: ASbGncvmI0Hn25ohJJU0IZOHpuGpWYrd3FQbylO8uNWaf2C7sVUFcdBKN45RbyhSFc1 7sTozSosEVm8UwouRRmI8uQIkpVzEVBwmEXv2rPu/Uygrz794oA7IYn1osHIfp2KbLiCXpifjtG p5uHx0Mmo= X-Received: by 2002:a05:690c:6b87:b0:6ef:5c57:904 with SMTP id 00721157ae682-708540ce38amr156786307b3.7.1745855076629; Mon, 28 Apr 2025 08:44:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6qCK0RP1Osqb6P+Q+6TNekm7P5LWk3+X90KpMgq7ufBwRs3S0yE0ZPxUoRWXjGPRpcWW70ryslqWVN+3xc60= X-Received: by 2002:a05:690c:6b87:b0:6ef:5c57:904 with SMTP id 00721157ae682-708540ce38amr156785937b3.7.1745855076172; Mon, 28 Apr 2025 08:44:36 -0700 (PDT) MIME-Version: 1.0 References: <20250417000238.74567-1-npache@redhat.com> <20250417000238.74567-9-npache@redhat.com> In-Reply-To: From: Nico Pache Date: Mon, 28 Apr 2025 09:44:09 -0600 X-Gm-Features: ATxdqUE76Pjv3zn_HiGc1qM-i1cE-erjrnyMNKG7-H8ENZEIid857QeclmukKN8 Message-ID: Subject: Re: [PATCH v4 08/12] khugepaged: skip collapsing mTHP to smaller orders To: Baolin Wang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, david@redhat.com, baohua@kernel.org, ryan.roberts@arm.com, willy@infradead.org, peterx@redhat.com, ziy@nvidia.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MUVsW4CbPmEnbPVjc6ayNHhpq9jSsS71kwXw9zWQEWU_1745855076 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 343DD180007 X-Rspamd-Server: rspam04 X-Stat-Signature: f5nhc95txgryma9qy9hww7ztf7egb46w X-HE-Tag: 1745855081-418095 X-HE-Meta: U2FsdGVkX1+qEyocIu4ZimKD8fI/ah8Jgb/5QoLFICirjBmb1wzkF5GC66FNsXl7R1Z0Z0dCWYcuRePXpXr9SwpZlMPlnVUpg23YL8oNuVOGwY+gmukvv7Y2EQjgOvRFGVKoMEs4yUWRcvMZI8mefg0vOKD4lKIZ3/0LTfCQxUvxDF6JS2LwmWDyEOsSYIQo27VD8MGwxg96kr8rafRwHlE8ORpAYSXkVqQbpdHaT/xh3Qc22DfRZcaQnfQPmVEonMAvfbVmX64p5r0GicLxNR13r5B4aSpZmv/dZraf82v46Tyiw+DEEt4iM1PhDNoFdaGm/kkMwxNrc6FEWNe3Q9VWiEFzrTOKqhRV7t3KdwATtj5oMe8wyQsx0JRq5Ey1TsoOU5b9+FR/E/3R/6bPmu4cJJ1BnZqx2EX0RUTA9Zr92gSYge2P8rHHf/ogXDBT2gtNdQPj2r8ACfRRn3G5JoH8XpkVr5E/OhVWmFMLu0ENj2yd5Q6VsdAnCWm5gUIzGlpQIlsT/0uq4L+PDMFDcgXJcg4BC+rUzgQIOYf1T8f+B7oq9232wNQ4tDnojMHTS14AUnoDZFoZUzkKMUFv2z/C1emV6w45TnVGSRJfzpVJhgqi9fd/Y+HfVKh72xB29pAncF5+IgELpbhN8GXXODrTLJc7HzXWYIt6DvxaCsAqTIAALx2wcNGRcWJrzWyRVBDEsHVqYU8BjYW3ZUdBhG71GB4McvKEJi6sytEk4XMKtxkZHxoCgjWVvrpvJ+bBsXXSFjMwwIcxYfxLuu4Wp3cNqLmq0oMJ7ccDuV0sRpn8HlD2Puoxp+N/sZEF8gmi7s+fC356mGoL4F7agWVWpoV79GkAdOwFyqpYzXGxeah5i+4Auor6sFqFX/Su8wFOsjbb94c/fl3/aiX6ywmPiA3uT5++Hk6doWx3M2iff1qQFhThZfUB2FEHI+9+yWDv1XHXgxIY4W95+PbwRhq gJi0ra/K tgt7P6ueHrMZFeONT4Ad/YnKlzsktgKu/oOLmAQjn15ccdc2AJv2oHrp95EuPWoWH4C1IQAvhR7wXAQafDYQ2sTgkd9/EpsAALBHDZLWDKX2QxDqZaqy8bWUrI39pZsj2NeBujMpltfgcp6CEV2uqrab1yAmqRAaBR6lxNcpkvzZzjlJxdTc3hXsbpisI3X7iNef+SvdHmEoaTz3nOibPXatkG30G4+iIOBkVV0hUWSW/Iz/XfbHozE3V3iFjkjueTn2hqzyQQTGVHpYuBherW8IM2glXBx5WOCRG1MqVJ/O90ypFVNcaFM+oEaT6hj0XQAU5zCg3C7wmNQY/zL97JCDbzBfvK1IUfX874p3LCYTPQeAEq1t22S9w1HJNA02LsDp+C/VkvIC/GveCNBYp0g+YhQhKdbi66Dg+Zt6Ztzwn/ABTAYdKRtbd4Dv+aBy2S+XXbchUXcijdD8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 1:49=E2=80=AFAM Baolin Wang wrote: > > > > On 2025/4/17 08:02, Nico Pache wrote: > > khugepaged may try to collapse a mTHP to a smaller mTHP, resulting in > > some pages being unmapped. Skip these cases until we have a way to chec= k > > if its ok to collapse to a smaller mTHP size (like in the case of a > > partially mapped folio). > > > > This patch is inspired by Dev Jain's work on khugepaged mTHP support [1= ]. > > > > [1] https://lore.kernel.org/lkml/20241216165105.56185-11-dev.jain@arm.c= om/ > > > > Co-developed-by: Dev Jain > > Signed-off-by: Dev Jain > > Signed-off-by: Nico Pache > > --- > > mm/khugepaged.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index ece39fd71fe6..383aff12cd43 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c > > @@ -625,7 +625,12 @@ static int __collapse_huge_page_isolate(struct vm_= area_struct *vma, > > folio =3D page_folio(page); > > VM_BUG_ON_FOLIO(!folio_test_anon(folio), folio); > > > > - /* See hpage_collapse_scan_pmd(). */ > > + if (order !=3D HPAGE_PMD_ORDER && folio_order(folio) >=3D= order) { > > + result =3D SCAN_PTE_MAPPED_HUGEPAGE; > > + goto out; > > + } > > Should we also add this check in hpage_collapse_scan_pmd() to abort the > scan early? No I dont think so, we can't abort there because we dont know the attempted collapse order, and we dont want to miss potential mTHP collapses (by bailing out early and not populating the bitmap). -- Nico >