From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A78C2D0CD for ; Sat, 17 May 2025 06:48:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76CC26B0082; Sat, 17 May 2025 02:48:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719916B0083; Sat, 17 May 2025 02:48:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BAC46B0085; Sat, 17 May 2025 02:48:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 36F206B0082 for ; Sat, 17 May 2025 02:48:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8FC91C13EF for ; Sat, 17 May 2025 06:48:07 +0000 (UTC) X-FDA: 83451470214.04.6B40566 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 4E6D1C0004 for ; Sat, 17 May 2025 06:48:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dl+WyXLt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747464485; a=rsa-sha256; cv=none; b=hXECwsGm85hc+yfYQFATyjsRDhBmwEpTxwmPTL6o8vJin4ZpF6MEA0ex1x5U84gFOz17zA 3kP+c6cR7kf/yYdVyMNV1WNmEglh72bfCSiOF7P0mehzR/2HEXyxm+s2Pp0rCifciA0vBd Y8oe+AdKHrd4O6nlvIdoHBVTEIUsbfo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dl+WyXLt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747464485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xoefSDHoQ2MJkgHc9vHEmIq4AuLZsAA319tBfQ3WAL0=; b=j/kV1xh14hWU/gjXcuuWlEgZ8yohWi0ikbcDQKwoXJjtYlDyOGhPo1imYNesvdtatuDrgf XUCIHK6e+FP98V+qorowZkUNhGrkug2Lz/Fbyaq6nSckZNUsD24OTfepdGNqbMkxmxa9zl R8Hk2FUx0GAypFhVQw1A+m0+P1X1HiQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747464484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xoefSDHoQ2MJkgHc9vHEmIq4AuLZsAA319tBfQ3WAL0=; b=Dl+WyXLtxx32GZORrm5EDLTlkAXRq8u0OFl5v8sZOh1Ak6+sihX9ehrk6sZAsJ+5evMcX1 +WGHxHPSwhOmT3tRkO0bzkn6RsxS28DSw8tSja8TjLxRVokX7JzbhLIDfRbTINagvnoJRx yST0Ar98MW41yLhuuWL5D2+UF0jPmlA= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-htQb9kl7OZGoxM7UZ9xgMg-1; Sat, 17 May 2025 02:48:02 -0400 X-MC-Unique: htQb9kl7OZGoxM7UZ9xgMg-1 X-Mimecast-MFC-AGG-ID: htQb9kl7OZGoxM7UZ9xgMg_1747464482 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-7082d8db9bcso41091767b3.3 for ; Fri, 16 May 2025 23:48:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747464482; x=1748069282; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoefSDHoQ2MJkgHc9vHEmIq4AuLZsAA319tBfQ3WAL0=; b=wNtgSgUL7zh6Ypa2chLlLoP0uTiFT1K+r7FpecXQ/3yqihs+lj1ZSvbwitvow5KQSW +lIolDrfr1BtQK636uy5eJhQutGN4pLABz+6HrZckHvVioguRykvQsV4FvZXJkwcig1t L+nCXSAN5Re5L9dkV/3OZXTHGQ6LdH4bUC7rsNM1DURatXO6c/IMy7puIFOJGHPinaBk UNQcjhM92c+V0gVV+/viFJtXLMl5vnNmEUSVC5sQfZ3JgUfazNk01IsNeeoEz7B7qIYQ tfoUWAbDTQYpSkA+PN+PurRtTl1EP0PI81ZhMw2tfl51NoNEGKvjcnIlTY/kKxEEE1NO F8PQ== X-Gm-Message-State: AOJu0YzX4Uw2zhz0S0OhnM6Q2mqCL72IoBgzVCWKEI+SZTPP1fNE5eU2 loKrA4qYgAl2YD3Ro/Tr4A7nyBBAs6tMJC35NBr8jUxyIGWswWmnFN8Uastpm+w+gMPe4cXIhM8 bZKmMg6XGzPvbHB6/3Hm+wUJQP/i3/9bNyqyhp7F88whNvo0lnXxSZofKdMuDOTJk/O8KdRZskE oOmwitm11JfyxDi0k4cwHrQaLBK4E= X-Gm-Gg: ASbGncueQuyLINjqOtLpb1jDoSW+gEFSlupaCa1iwBzZR5W2aXzhRGaLAaBDFLWUiV4 hYAU+mie+1/B4l+/EEelmo3fCp2BUiS7bXvquSwsKeRZ4kI7+8WbbQMBxcTnJvP9eDEpeY2g= X-Received: by 2002:a05:690c:3:b0:707:dba5:2e44 with SMTP id 00721157ae682-70ca7ba0d8emr93966577b3.30.1747464482206; Fri, 16 May 2025 23:48:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNMmgN96ppS4R9A56rSKNlS+EhkQE/xJYfY1RrmT+t29R40GTIUMkgVA9ErgvZMyurnYk8q2A+N4SmrSywNXI= X-Received: by 2002:a05:690c:3:b0:707:dba5:2e44 with SMTP id 00721157ae682-70ca7ba0d8emr93966347b3.30.1747464481896; Fri, 16 May 2025 23:48:01 -0700 (PDT) MIME-Version: 1.0 References: <20250515032226.128900-1-npache@redhat.com> <20250515032226.128900-7-npache@redhat.com> <9c54397f-3cbf-4fa2-bf69-ba89613d355f@linux.alibaba.com> In-Reply-To: <9c54397f-3cbf-4fa2-bf69-ba89613d355f@linux.alibaba.com> From: Nico Pache Date: Sat, 17 May 2025 00:47:35 -0600 X-Gm-Features: AX0GCFs8Yc5oWY97Oxpxk79pJ4fpAxS1pc4Oj0m-wPhCk0WUp_t3490TgtutRYc Message-ID: Subject: Re: [PATCH v7 06/12] khugepaged: introduce khugepaged_scan_bitmap for mTHP support To: Baolin Wang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, david@redhat.com, ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 48-Jn-a5kYQVjw5OhCZWaO-D6JgYa4B5rsLbl-ZAhiA_1747464482 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4E6D1C0004 X-Stat-Signature: hh5yj9zfqik9xij6cbxpi9487dcka9qi X-HE-Tag: 1747464485-178824 X-HE-Meta: U2FsdGVkX18slcNIOt24BIPpLLS1LIROnxO86HJrbQed4kpSaiQLuVa0EtASg2SZJOZpuxH6el8GValPEA6ZR0glbRFFZ6Ut7++HuW2L/YsaUSLqWTYBy/qnanD5ZW2Ky2aSCw9biYrWm9pRaQHTByAbRqikS7yLlp7ZbqGsSrai/JdKOrhe5avDFecYLF5mgv5brbRAxjDLa7L/jMDSfHyNE9keXdVYqfCHg0jtlpC/t4BpSeTWAGCawv3Wbs/0/7aQjOtzh7fujuTFrHuZv8KWtu86SkBnh7Wx1Eu/aQDmkXP6nT9/nZX/J9pt6QUD0sk8eJyrzm/ws+WsBCp89aBBbxTK2BcRyA03Hw3XW8ERwTUPv555RzFwaoTsTWlPVOE6VhcMlOjlbPlz0BHRpo3GzcegnsY7y1k/PkD8+Z7/Z5d8tX58A0ZG7w1XE/84OQGd8WH7dQgO0s2wYwl0rt0xG+UrsXKa8Dlzy55nEqxnzhQ0wURV9S9NjSvf9Axg26GGbBVC7TiQuYvv1FP7axz7I/5mtZFsfGpG6MAt4OP5Iebf3J/YTekDUH2G1jhVaGxmFb4QCy9Iy3cs7ivPY8/KEhxz2levzPC3Gjp406GMBmddw4yUjaFujZ1RNfO7D8HvXBhjdRI3GUzckeu6gibxMo9dCQ8V57hV4kLA47WAccgKMClECuniKHo/VELDYovYYgRBb+KulwdnnCJs16GLg0c4v1gLn1oK1LVJ/3YQj5n42+mUwHAf7FUoUqKlcO5JnCwzNbq3DmE10qmWN8fdCkjhykx/0ybq+MLLCjs6/J+jWoF9DFCaBiTBPb7guQlhv1YuI5JTJzzxVll1+gstiKuJpRlIbvxQwuV5hIkvm1V5JYjYx+evk/OmgsYRCoQMbJI54nDFda46gfWYiAotrzTZcgvHjvTBPFpnn5d4HpwYd1AffPIzG1MX484sEFUQl8I6fh8FZmHxwBG c+8gN/2E KqImh0Qf0bEZPrgCRFP06NATewPfIrYnVqdP0AKX76ArJOl+PCZ6uDlBn2RuvZxYKx7OLDH5zDQY7BuT/RA2YRGAXj1paCXQXrprkHSDnG42w2CgDizYb1gq4hhpP+xEK3KT4FIimHtCE7d2ZCGovs5CZxl1Sez7fs0QCiWxWPBHebjV5/qQSKEHyJ6q3oylePg/bUYPIMzOnqt/cfmIw/Nq3aFwEFrmpuaH48csFsb+a5cVnK4Yto34ck4xgbyL28N7DoXi6W1P8F03oeNbWFwB3UhLmd4dp6IRQ9ttrzhf9SB9/j/uX8aPOFPJ2ZUTmZPx3aULX9Ge23/nRRt9KW+f4gsOWjuzG2mZ/iW/7xc6kr3WHnLHdM4cEffNOSi9+iYke9mBLh6sPOWZTa05pR+kAYF0gcf7ZxGgDsllQtjBYjCFmJSYPbV1WnU5L8K8MRaF5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 9:20=E2=80=AFPM Baolin Wang wrote: > > > > On 2025/5/15 11:22, Nico Pache wrote: > > khugepaged scans anons PMD ranges for potential collapse to a hugepage. > > To add mTHP support we use this scan to instead record chunks of utiliz= ed > > sections of the PMD. > > > > khugepaged_scan_bitmap uses a stack struct to recursively scan a bitmap > > that represents chunks of utilized regions. We can then determine what > > mTHP size fits best and in the following patch, we set this bitmap whil= e > > scanning the anon PMD. A minimum collapse order of 2 is used as this is > > the lowest order supported by anon memory. > > > > max_ptes_none is used as a scale to determine how "full" an order must > > be before being considered for collapse. > > > > When attempting to collapse an order that has its order set to "always" > > lets always collapse to that order in a greedy manner without > > considering the number of bits set. > > > > Signed-off-by: Nico Pache > > Sigh. You still haven't addressed or explained the issues I previously > raised [1], so I don't know how to review this patch again... Can you still reproduce this issue? I can no longer reproduce this issue, that's why I posted... although I should have followed up, and looked into what the original issue was. Nothing really sticks out so perhaps something in mm-new was broken and pulled out... not sure. It should now follow the expected behavior, which is that no mTHP collapse occurs because if the PMD size is disabled so is khugepaged collapse. Lmk if you are still experiencing this issue please. Cheers, -- Nico > > [1] > https://lore.kernel.org/all/83a66442-b7c7-42e7-af4e-fd211d8ed6f8@linux.al= ibaba.com/ >