From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80ECFC282DE for ; Thu, 13 Mar 2025 17:36:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 688FF28000F; Thu, 13 Mar 2025 13:36:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 612AB280001; Thu, 13 Mar 2025 13:36:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48C2D28000F; Thu, 13 Mar 2025 13:36:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 26943280001 for ; Thu, 13 Mar 2025 13:36:24 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7C436C03A9 for ; Thu, 13 Mar 2025 17:36:22 +0000 (UTC) X-FDA: 83217231804.03.B102282 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 69A0E4001B for ; Thu, 13 Mar 2025 17:36:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LXD5X0m6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741887379; a=rsa-sha256; cv=none; b=TAiY05LZW83ybw7X386Sal/Tp7zS+gzSAuRjuDJ3X8bSZ7h449c+iGwmRTZV+XNrFh7A8V soqDUE/k7bBlDSvUbLVzGkkSZxAmgKzEbatNDjG386/4iSdy4opSqiZdc1if9r8E10HyA3 GGeyrJ8rwgyYNgdDjssX+nHMKZ+llg4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LXD5X0m6; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741887379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=74LdO3L2papOXx6onu8X7dux3CgaxYMbpnbfEZf5vfs=; b=kamyQZT1SKETTo7FkxnYdKRhZ02+J0Jd0SSLcQnpT1CpunwugmVJ34SFAwlP8ppFN9uTkL VPZ/IdeaJcI2VOU2fgBOO77ZJoosJ27RpHIVEpRso6OFvVP1foZDkpB8xaYXKZUlDqFt4B 4JwAEErCjkGlSZwv08K8xlBZ2Sa+d+I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741887378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=74LdO3L2papOXx6onu8X7dux3CgaxYMbpnbfEZf5vfs=; b=LXD5X0m6c0rLJZ2al+ua8fqKStK4rpcPeKeVQ7sLkrUXXs7etG3TLHLtxhdnGu1nUK006f blzW8N1FuQjcmNZx7n4RYWtupQadBKHx2IJ6ust794i1l+DUHdU1QldptfFmoSLHg7BVIC mqpt8gCVgKcIPlmmC1YXoz6D+5cEjuQ= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-ij-A2BCiOLqe0wfwGki16g-1; Thu, 13 Mar 2025 13:36:17 -0400 X-MC-Unique: ij-A2BCiOLqe0wfwGki16g-1 X-Mimecast-MFC-AGG-ID: ij-A2BCiOLqe0wfwGki16g_1741887377 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-6f2bdb560ecso20156317b3.1 for ; Thu, 13 Mar 2025 10:36:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741887377; x=1742492177; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=74LdO3L2papOXx6onu8X7dux3CgaxYMbpnbfEZf5vfs=; b=Iv3zbQCBz3stL6O9ASXOxHoGSQXkTC1cOT4g2SZg0gKJfscLUQAdhue0Q3wFbI2M6M CxOe6bDnovlWc+ba+AuqENe0IEzGIuT3ZP5pMmMsPLWqbn/kBzgXvPGl1ZJrYGSqKrj4 D495wFNLgPRa1W4Y12fS1ps6RzHIOvamRVRUOvmFe6K0JHpaNITnagqdC8M4wL+e4M+u Xdyxpxbd0EkYI/H/Zu8HgYaVWxq2DfQiKNTs9GHrJDyjt9JzHCxH+sU0Y8+yR7u6nEcA jlq4kLeZ+9lW9REzMiv1knTd4/SOp28IckIarPrupWR5UBs+Jp3G4LJ3hsR0QGicWTCI DuzQ== X-Forwarded-Encrypted: i=1; AJvYcCXdRnbF9xe5IZkWZIf+qWcLnHG+jLVkewCuiit9ynNtWq7nzHeQmnV6exYVZLh6nwjOjM31Z2KtFw==@kvack.org X-Gm-Message-State: AOJu0YzHBzL4bIH5t/o0a7XKZLenR8ucU7gNiKbThRcoi0Yt4Z4AxFYS Lgo/3C8EFmyCn8x7OQodvkVqKGQOaBcKh6laXpoj3acMFDvnOexmLWjt/x1nANadp2/itaHct/y lRJXFuGM9uDqaYU/6sfCk9fbP4URa20TwVQRh9sqhjeteuuWd1ww3mYrgk9IFhgBZ0JQNCR81qM ledLf9F7ltGWWdm77t+UnZX2U= X-Gm-Gg: ASbGncvVynM+ooqTvDjm7jMtoETPb7FDt4ZTgyzOwn1aRAkc1VikEhw+UaXexW0Kiwr 4LxRlhDSRI5TX1isnJq7JYYuPFAo5wr5mU+L0S8ln4XCgNmFtk6RgqLSQeTkhQcpw7hwQ2/Ry0h X8aDlqFbwySw== X-Received: by 2002:a05:6902:11cc:b0:e5d:d6b8:231d with SMTP id 3f1490d57ef6-e63f3c1ab89mr394090276.46.1741887377129; Thu, 13 Mar 2025 10:36:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESNapqN0/McTxEgf1yThn7lvo6wBYo3eRd0NunIcEjHGxMwrpjR53TwIJsg0lBT1jUk9YB7r7WxOStKAHssG0= X-Received: by 2002:a05:6902:11cc:b0:e5d:d6b8:231d with SMTP id 3f1490d57ef6-e63f3c1ab89mr394058276.46.1741887376762; Thu, 13 Mar 2025 10:36:16 -0700 (PDT) MIME-Version: 1.0 References: <20250312000700.184573-1-npache@redhat.com> <20250312000700.184573-2-npache@redhat.com> In-Reply-To: From: Nico Pache Date: Thu, 13 Mar 2025 11:35:49 -0600 X-Gm-Features: AQ5f1JrzcM5gNtNPl-Fo_pToh0DelHZYtUioYU9wKMINK1ALGT_dvw_uu_EmSak Message-ID: Subject: Re: [RFC 1/5] meminfo: add a per node counter for balloon drivers To: David Hildenbrand Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jerrin.shaji-george@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, nphamcs@gmail.com, yosry.ahmed@linux.dev, kanchana.p.sridhar@intel.com, alexander.atanasov@virtuozzo.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: StG1vZf9HCdDVNxXXri_VZUOkI_ev1NTGZ6WEtq3h9U_1741887377 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: zgxxcd9zu8kcerbs6naspxcj6abtof47 X-Rspamd-Queue-Id: 69A0E4001B X-HE-Tag: 1741887379-436690 X-HE-Meta: U2FsdGVkX1+HiHLSQ2XoOD5dNfEeTsdzFyy9iCLkuoKJiiEvfoWy9KzHnb5F9s8jD9aVxzNu9ibDBMGVxutW+sm4aEc4SQMNp6mfW0sUe4h+1Zc7wfZZ8LuXcje/SIa9ijTSx7ES8PvQQsExIzmndDAmzHBRFDOaR13id4FxIwqIRVSR3wjcpai7L683oQp5PFD/djUMfmapGi982ct9cpUVf2W0EpfR9/aklEAFGLWQRwr3rPtCA99ajPwJfpXCkTw7iYTnCweidf/R+TU89xo2mDLpdwKH2T7T4LbJkdvbpG/RWtEI4pDV7hn6RoEFF65o5l5Xjqabrff9lKvaEyf1VxFZFUO19ILv8Y84aO/Klxzp+5s3CNKj0+2gQ+tRv3kNvKEjioae+70yUNvmQcN209rJjzOOpedrw/qfIxzdb54EDnNT2GH/g8pIQUZ9czQWoxIuebpy5NSvtIFiUOEwwuZUXZJ1F5sNpEvnDQW3M/ZLblB0hDYWkbTyNX69qtZ7GQ2jV51pWDwzCaDyUI77bX6WgVPkypmvsWjGPWdZnVh9MX288NZgsy1RvydMWOY+n6GuILaOqpIilC9LABrBdNiMZyxaaNf0BlAkNBoA301pgLXAVurhaNhfnmgvQO1MVa/Eh+UXJrrq8OK0MfxebhtdhTGj0jOSbuBcENCp0rUIrjskGJsoiuMDMRVfaaqwVS4iv9739MuBOre/JEgUNioKU2Up6QkUzYE5Uxje0hpRgNJzJNF0w12pzGSXgA0LNHQC9dLvQH0PLFhXjsM5YQ4qedY6C6Z2GWOv3KzU/rSyU4UgJyfIOdycKUzgF32E3K8LPaCp0prDDeZtSfdlm55asrkqaaOGXQtvFlerpqK1bwg5sBZ9iA5Trumky5+RwrHhx1zgDOWXyw/MCtCa7bbuCEd9v2q7xCZafzkUlzw/fyOah+ncpWowgkgMsumBBuAULRpV7WjH5Tp O3STP+mm 4Zl7EDG3y34h+wE2SFqQmH1X3B6PrtjzGzwpcqETviYVZj3g4fI4znFnXBt1N9fp26PQSaE7X3DW8jQbxughttcBrja46aYVi16sXjZRFF7Wf+kaM1FQ7XPMtPVG3IC6TAnCNOnc9nMFD/g6pmaiexNG+41ek0Qf0aJjEc7wJ4oxMzyagde2sLx4dzIfl9WhSqTluYXi606Tla+6LfA7NVUiTMFKF5CrTO/bB8GJPfCKlz8IobUpMb7+TtgKGw5lMYB2TulLvEkDT8ro3U6CeaamJKg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 2:22=E2=80=AFAM David Hildenbrand wrote: > > On 13.03.25 00:04, Nico Pache wrote: > > On Wed, Mar 12, 2025 at 4:19=E2=80=AFPM David Hildenbrand wrote: > >> > >> On 12.03.25 01:06, Nico Pache wrote: > >>> Add NR_BALLOON_PAGES counter to track memory used by balloon drivers = and > >>> expose it through /proc/meminfo and other memory reporting interfaces= . > >> > >> In balloon_page_enqueue_one(), we perform a > >> > >> __count_vm_event(BALLOON_INFLATE) > >> > >> and in balloon_page_list_dequeue > >> > >> __count_vm_event(BALLOON_DEFLATE); > >> > >> > >> Should we maybe simply do the per-node accounting similarly there? > > > > I think the issue is that some balloon drivers use the > > balloon_compaction interface while others use their own. > > > > This would require unifying all the drivers under a single api which > > may be tricky if they all have different behavior > > Why would that be required? Simply implement it in the balloon > compaction logic, and in addition separately in the ones that don't > implement it. Ah ok that makes sense! > > That's the same as how we handle PageOffline today. > > In summary, we have > > virtio-balloon: balloon compaction > hv-balloon: no balloon compaction > xen-balloon: no balloon compaction > vmx-balloon: balloon compaction > pseries-cmm: balloon compaction I'm having a hard time verifying this... it looks like only vmx-balloon uses the balloon_compaction balloon_page_list_enqueue function that calls balloon_page_enqueue_one. > > So you'd handle 3 balloon drivers in one go. > > (this series didn't touch pseries-cmm) Ah I didn't realize that was a balloon driver. Ill add that one to the todo= . > > -- > Cheers, > > David / dhildenb >