From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C056C369AB for ; Fri, 18 Apr 2025 17:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38AE728014A; Fri, 18 Apr 2025 13:18:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35D84280148; Fri, 18 Apr 2025 13:18:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24C7528014A; Fri, 18 Apr 2025 13:18:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 06759280148 for ; Fri, 18 Apr 2025 13:18:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 65A41C0A1C for ; Fri, 18 Apr 2025 17:18:49 +0000 (UTC) X-FDA: 83347824378.09.0B4A635 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 96F3BC0002 for ; Fri, 18 Apr 2025 17:18:45 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gzkOqciR; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744996727; a=rsa-sha256; cv=none; b=dN0twDtMqDmEkxJCb8F5FTJ2LkbR2xe9pqf6RE3WtFBYRuODo/GdBZFE4f5nz3QXv0NT2p zciUNfEJgM74IVC1Up9VchdGQWUN+uMsKdWy39UscpLDCZcu7r8QvAPBM8G2evKj1wGQD/ xdgXmvVNY69Wc5vyhmqiOnwFPmmvHEM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gzkOqciR; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744996727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gkdw8gsBY7I9in1XRxPqFzuV9M+R9WrhUEzgOn2phl0=; b=qMVlOPpf+uSgb9hmpALRBqTzgNXP+Gb8zR1J5/r3L2YSPdOT1WtsDHajgLmuW0jOR9CXlR 5tj2HaqKBLpboCLypTteDVTL8We2lxOlN/d1OzF4uPVo/Lo5Ie0s6jbuVmr3t3VI0AP18k thtt1T7q21FaumSOb4aCONgKoTMlRho= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744996724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkdw8gsBY7I9in1XRxPqFzuV9M+R9WrhUEzgOn2phl0=; b=gzkOqciRzUh6qLnSC8LE1pbtTKyOG3MPOa/o6q4TRfO6pxeXhR+wVdyxlQCg/7POOjH2Z8 ZyBn1xJ9h+ebxW9fZl9q7LXnARXsTeoIdRbNxdTlr/WrAkwrZBhoOgojxVCO8ueVw8MeW7 GLdWyoTY7WuWiq113bIihfrziIrzZgA= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-rrDYjVZsMg-gG_Hv7VRrAQ-1; Fri, 18 Apr 2025 13:18:43 -0400 X-MC-Unique: rrDYjVZsMg-gG_Hv7VRrAQ-1 X-Mimecast-MFC-AGG-ID: rrDYjVZsMg-gG_Hv7VRrAQ_1744996723 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-e5742f52896so3211177276.3 for ; Fri, 18 Apr 2025 10:18:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744996723; x=1745601523; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gkdw8gsBY7I9in1XRxPqFzuV9M+R9WrhUEzgOn2phl0=; b=STDLJkCoLx/pLai1ejJg81k7XXu3bsmqibsK4vuho6fc3jXc8kqAd1SaEIa6B3dMc0 LgMT2AZMrrZI6jebm2vABl9XSTaSqEJwcuTm8PShkuJVV4e8xaqkb0vxjimD/Pv6qoB1 ppCnH4jwBrSbo42b9io6CZM3sB45OVfC1TN4ax6RMtRTlc7o1RRxSg1ABayiYNOE6ddi 09gxJbr/P0XekqbJXjeUcMKs6NTRnTjtvZgf+A2SoWjaBKieVcAjUZfYaQx/UrZIVGf1 Tzpzb3DXNPkr7D4qRb7yLBCTwq+fhrVjBwTxU0CleCZrxp69n+BrCK0xwCfyHvw9xyb2 YuZQ== X-Forwarded-Encrypted: i=1; AJvYcCVDxVXoIEBrwiRJe8fZGeNHdYIDmXWzSM4ojI7/wtPuV7S10VRVXh/SdfBXoy+CbuwWKPI6Y7Quyw==@kvack.org X-Gm-Message-State: AOJu0YxItGkfBCL78vCQ72qd45gnsPAnSL0tnbeJv1wNdgoa8yCro1O1 7ipmyKaskXaLMuG5tfYnc4I2FN/Q0Rd214++NyeykCEcyx2G2/ziyvMYU4lo/fG5fWlk7kpVOz2 ZH2Jp0b3ebwlnoINdYoqTO622InQR9RpN07zhXDbulQBvBQNoyHQNd71HNhBVDhS6fboVjZETNO PoGyFCysgO988vWqdjdL4iIq0= X-Gm-Gg: ASbGncvR7eStbTl7z1VgP4E5004mSat0tUTZNJPQuBBydEteT+34ounYUcAiQuzQ0TU aYARzbfrHtCpfH6jUdFRIKN4duWhu7brg8xjvAaKEyvhYbAV02vxxcbwHir++0LG5VdRr8Afns/ eCmHTI2YE= X-Received: by 2002:a05:6902:1685:b0:e6d:eea7:35c3 with SMTP id 3f1490d57ef6-e7297dcb74emr4915462276.11.1744996723375; Fri, 18 Apr 2025 10:18:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgO3yGvbKJV4mk2YjiCklYNqNWcRnEs03RKhS2nZ9xH55/2YEz6HN6ctlOeQ69EMUsvvUuE8HxshphvDhfc0s= X-Received: by 2002:a05:6902:1685:b0:e6d:eea7:35c3 with SMTP id 3f1490d57ef6-e7297dcb74emr4915431276.11.1744996723007; Fri, 18 Apr 2025 10:18:43 -0700 (PDT) MIME-Version: 1.0 References: <20250417171758.142745-1-nifan.cxl@gmail.com> In-Reply-To: <20250417171758.142745-1-nifan.cxl@gmail.com> From: Nico Pache Date: Fri, 18 Apr 2025 11:18:17 -0600 X-Gm-Features: ATxdqUHGLN0lFeajQ8s0PmbZ6wgOIx5rwI7HcqHdz6FT6fADQxCAu1ui4DqSWqY Message-ID: Subject: Re: [PATCH] khugepaged: Refactor trace_mm_collapse_huge_page_isolate() to take folio instead of page To: nifan.cxl@gmail.com Cc: rostedt@goodmis.org, mhiramat@kernel.org, willy@infradead.org, akpm@linux-foundation.org, david@redhat.com, fan.ni@samsung.com, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6jQC3oUACBEtGu4yZzi8yDsPpzIFBVT5eWG0FssfpUQ_1744996723 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 96F3BC0002 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: ed918s58d797s53wyeb531jddcto5t7p X-HE-Tag: 1744996725-531476 X-HE-Meta: U2FsdGVkX1+onEiWQ7RS5rVAdzHR7DJMPMi8XsB05GmhjVYo8UC/gAwmLy0AeoEgdIWCEw8J2QA2shJaFJG0CnpIRw6NTBrj0uY+oaFQ1jQla7fwvMoUvqWNmbQmNCd+RZEJ3GLqx7r++QoNQLXk1EdWYB7gTTTqC48iQu0pJUlNr5F2j0JGmLzhzKpIBsHQeSB/jHwDlFcAD/y09syM8SQgCpqze6SltH94sWapGmHxPHZwVHjdAoOktAyn82AMyE/0pPY67SbryY/DXVHaSr9g+NV7XtyzJn36KG8C+My+XC3oR5ta8/RmLvqsCXSHVqk6DgMet3qFUMcSXUnS7vyrYG3V5txB+ULUcu2vpNrINonewH2aEx/SmL7PKHunp3XdIjb9dIK2SotLlebtY3JCdkGHCXsYwMZ1PlUS+7FZoOpwyIg9hh2+XQOM0bt5P47akmFfPUcxjV4u40W3Jedj8PE9zgjlCpeJGwHStWxHsp/mM1ka1oWBdm+DzFyEEmtcOgd08TT/dtgjtsmM+Pn1MscHWqpT7qK8gnoGEK5uC8F2sAi+6Q6jEZ+yMF6TC8ZraBSCVnaRNUyoo5jWLHKEOeVmIJ6qv0A6klmm7w2fYB5ojFaj7KkVq13NJBnD3yYQgEHWEUznHStjm09wWBac6C3lN0jFkERwP1CLI0lVWs4GN5IBGAOOYNP+KyqjkefRjkVqCO4M1A8L+ptNrslWgC1c8xefuEV9WR5YAui7p1IcfMqjPHid7lxo/KcT4GRJ7TP8zHTCU6fAjqVGzexT4OSdv3OcKcNE/KcjxRLk26qW1hvzUvxecZzRxvtxup/qGHFumF1HRdGziVabxpsQ7Ql5gemVgXz8PHbJ31slqh04l+B8M8tvwoyne9xS194PeF7fC/R4W9zUDWfOLbG3gacZ3fnQVeUmIe2smQi5fRSKJbJ+6mKMtGBDexFGOq1HkpTNq3VD8g2u96W ovNM2URV kRk8unree0BevvLVHKTx1oEOuBd7vMOcUdrnIB5ICCbRJnU5KBKYFgEOnDTr7X+Jao3hWdWatskmg0RsbvyNz4S5qH5KUo3TI/qAc3oKDnhQj0IdFImn61qtQ32F+I7P49GryVCUDUy8CaFUSuS0hHe1WlooeS8UaNmdCscuUSlhReKExAm50q+srYsjd4+qDiwZRjgYb+89MmO2+PKm4nHmpyl4+oPuTOPpL3xhylxE2igbaYv6IucE9dij/iwBG7Y9tyAeZVkudKNE3e6OFd1+mQUW+33svgAn2eu8YOzjQxxyUaeqThzq6093fbPiMc1DV0q31atWyWKRJzJcR3Pnf7Fe76LrnjI/V4+SvJGUDfDrVUJ4o2jym7upiktIDpxVubnEwivTUwVXXNqidm/cXJlUzcSklWyNz7+qjdPEux0BPIV+BuzMJPMfkchJ9jTiF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 17, 2025 at 11:18=E2=80=AFAM wrote: > > From: Fan Ni > > trace_mm_collapse_huge_page_isolate() is only used in > __collapse_huge_page_isolate(), which passes in the head page of a > folio, so refactor it to take folio directly. > > Signed-off-by: Fan Ni Looks good! Reviewed-by: Nico Pache > --- > include/trace/events/huge_memory.h | 6 +++--- > mm/khugepaged.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/trace/events/huge_memory.h b/include/trace/events/hu= ge_memory.h > index 9d5c00b0285c..a73699f000de 100644 > --- a/include/trace/events/huge_memory.h > +++ b/include/trace/events/huge_memory.h > @@ -116,10 +116,10 @@ TRACE_EVENT(mm_collapse_huge_page, > > TRACE_EVENT(mm_collapse_huge_page_isolate, > > - TP_PROTO(struct page *page, int none_or_zero, > + TP_PROTO(struct folio *folio, int none_or_zero, > int referenced, bool writable, int status), > > - TP_ARGS(page, none_or_zero, referenced, writable, status), > + TP_ARGS(folio, none_or_zero, referenced, writable, status), > > TP_STRUCT__entry( > __field(unsigned long, pfn) > @@ -130,7 +130,7 @@ TRACE_EVENT(mm_collapse_huge_page_isolate, > ), > > TP_fast_assign( > - __entry->pfn =3D page ? page_to_pfn(page) : -1; > + __entry->pfn =3D folio ? folio_pfn(folio) : -1; > __entry->none_or_zero =3D none_or_zero; > __entry->referenced =3D referenced; > __entry->writable =3D writable; > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index b8838ba8207a..950d147cd95e 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -696,13 +696,13 @@ static int __collapse_huge_page_isolate(struct vm_a= rea_struct *vma, > result =3D SCAN_LACK_REFERENCED_PAGE; > } else { > result =3D SCAN_SUCCEED; > - trace_mm_collapse_huge_page_isolate(&folio->page, none_or= _zero, > + trace_mm_collapse_huge_page_isolate(folio, none_or_zero, > referenced, writable,= result); > return result; > } > out: > release_pte_pages(pte, _pte, compound_pagelist); > - trace_mm_collapse_huge_page_isolate(&folio->page, none_or_zero, > + trace_mm_collapse_huge_page_isolate(folio, none_or_zero, > referenced, writable, result)= ; > return result; > } > -- > 2.47.2 >