From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A85C1C83F3B for ; Thu, 17 Jul 2025 07:22:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 190FF6B0096; Thu, 17 Jul 2025 03:22:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11A976B0098; Thu, 17 Jul 2025 03:22:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 009C16B0099; Thu, 17 Jul 2025 03:22:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E25446B0096 for ; Thu, 17 Jul 2025 03:22:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A27B3BA698 for ; Thu, 17 Jul 2025 07:22:08 +0000 (UTC) X-FDA: 83672912736.01.179C094 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 64406C0009 for ; Thu, 17 Jul 2025 07:22:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VcoO2U6n; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752736926; a=rsa-sha256; cv=none; b=IHdhKXq5pUk4+NyjK5YTwmmYmFXkbn7knJDt8asO2GHZa/W+QuBLmU1EWohmTfvkL4Iru0 lkLbpOJf7/XfMEcsmJvc13sG6nnuCjsHoTqyCq1IUSgaGvxIo2TICwdBFwkxZObQmGeQgi Htk5c4m7yMaMiTO5JCtPelrwNUFHG0A= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VcoO2U6n; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752736926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XQ39Fnx/vbGSljAimxTrmnp3D5hf3R4yTB7vGUtkUcY=; b=0R9dVfcpHjF7YdFQQhe/OcI/PuR+uGc8qzTFy03HXZyhZ4Hh72DmJCD3jrRd7HiBkX8VM/ +WTWpsC6jSGevac5s8Ap9wGmGxtyjT/ZLxJPXCBJpi+DR5kGyyGDTH8vUe2eTko6HIeImZ zhxJhXQmN0WMQsKjaKih8WsJxgz/o5Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752736925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XQ39Fnx/vbGSljAimxTrmnp3D5hf3R4yTB7vGUtkUcY=; b=VcoO2U6nrbF3P6BwrQivz/l+yjiYZJ7Y8AX71XgXSshcSK4CQNKK6yT3jSqC29e29ZG1K/ 804YPCpvbNQ1IxW4DRDzN+ZWomXMrCEsyewG/bzZWPOrC5uVkx4HpEFui4h7L4NjWog/0x rrJf72WVSwUIW/bC1biSyT2XUZ9bEQQ= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436-Zr9PgFapNwmvtAMED51m8Q-1; Thu, 17 Jul 2025 03:22:04 -0400 X-MC-Unique: Zr9PgFapNwmvtAMED51m8Q-1 X-Mimecast-MFC-AGG-ID: Zr9PgFapNwmvtAMED51m8Q_1752736924 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-70e86a2a1b8so9785817b3.1 for ; Thu, 17 Jul 2025 00:22:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752736924; x=1753341724; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XQ39Fnx/vbGSljAimxTrmnp3D5hf3R4yTB7vGUtkUcY=; b=fO+I1r0f6vTG4qy/nHFT+fMWDEPWbWBENkKXJAPmPz2aqSzfahcWfRggZevU4bmPVw VMtaSYz2zVC0ECrTZR6ChlpXKSCq1xICaxtKtNIQOg+3E4/KeVGxqp3ALJN3DXefObkm NutIVbeTdYdOhHR9YX5GaCnTf7iddrRgPExv0ls8Ts3wnDkrPPv76vf/Fr5QZLNYW42k BsQlE1iEqHoCoB8+HT+w82U/vksqIsvLVUvk3g6BkYsQw+NQUd8n+/Rwn3rSDATWYAul iEPfqRdU+qBGXB32cGNLAMZxg93w068vDT8xCIO8WZHTwjTrQyjjT9Alp9NJDMdjX5aM bERw== X-Forwarded-Encrypted: i=1; AJvYcCUoFAE2NpTVefwTahRu01+nFZha4gT6r/KTIBANv5aCQnHrQX2jeTSgW1z8U1RQnjyOSJFQGXzAfw==@kvack.org X-Gm-Message-State: AOJu0Yy+QhSpXpCXOONa5OmUYkahkwXdd0oTsuvmSRcjqhIknl0uDIJ1 nbI1dmtvJSq5ZnOHKXXbiu/jiZkTWL2/xeETd0Y31Xv9LfPKinLx0/2egXfhWW68PTu2IR6JLvC EMyrrCaySf0ANb7AldY0xubF6r5alKsV+vSlWH6lqGTGuTZUP1h97gS02Kbqtv1jyJ3iDre3/89 jY6/H75lJVonwNEai/CsB2aQxWp/U= X-Gm-Gg: ASbGncu+QYH1zIXJ4yPxY5ssg1EfRSTl9kvMAWOACsMPRzfX1HDqq0TDU8IjUcuV27s J/94XUJ7ws0Nxx7gPp1yGIlUZmP0m0VfTKjX5oQNfXmjXw2JJ65a+xtkWufwK8OAZR5WUBmqJ+V PtiIiv5fuTbzNZHHaa5pJLgNo= X-Received: by 2002:a05:690c:7006:b0:70e:82d6:9af2 with SMTP id 00721157ae682-7183519693bmr85546597b3.34.1752736923759; Thu, 17 Jul 2025 00:22:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFulp94zzqufWxgbn/qqUK0u8D80QwhjnNGORTCxK8HgNdkob8Z42M9OX9p9UcMtp5qaidEXGBGcHvo62zvmAU= X-Received: by 2002:a05:690c:7006:b0:70e:82d6:9af2 with SMTP id 00721157ae682-7183519693bmr85546287b3.34.1752736923365; Thu, 17 Jul 2025 00:22:03 -0700 (PDT) MIME-Version: 1.0 References: <20250714003207.113275-1-npache@redhat.com> <20250714003207.113275-2-npache@redhat.com> In-Reply-To: From: Nico Pache Date: Thu, 17 Jul 2025 01:21:37 -0600 X-Gm-Features: Ac12FXxi7mHJAWB-d7W3oMKlvMwZbeUXqKMgcsTZqrDy3LQaENgncw19n5KwkQU Message-ID: Subject: Re: [PATCH v9 01/14] khugepaged: rename hpage_collapse_* to collapse_* To: "Liam R. Howlett" , Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org, hughd@google.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fhINUUdlXqkFU26P2oXz0JDPzZKdYLFwJU_hCfWG5GI_1752736924 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: sdrc7snfmcdydfg8sdhuoizdzn5gfujs X-Rspam-User: X-Rspamd-Queue-Id: 64406C0009 X-Rspamd-Server: rspam02 X-HE-Tag: 1752736926-892376 X-HE-Meta: U2FsdGVkX19o0jzkUvLkDj/5VMIQdjNqv4D95PPXdUKu79N7YIDaeKZQohbZhqmBkuOSYO2PJZDyhR7Sn2ToHyYOq64lVz0+9x62OOejPr2yDkP6BjQStmIROuL0AyDRY/rsNBjWv2FfG40V3kuW88yZ1vGOP2+ZDZyT7JeviCGAjTOg29j5vtHesTcJX8BU08UUvWP/58f55PGhWsiz6OggyFwilXa34Um70od503kfIEE06re6hpZA3kb0Sjj6wLdPLetpk2UIxOtfVPJ+29iUDfJMYas+rs984t2VStx4daZqT1/boI6if+aR6HBXU/vuwAlz53EmM5CLDo8s99arCPWsM6IOh08kI7ICtdSayT0ObMVjVpFdwc7X9rv8mbwJxY4LFEfeaWaaUbFWrCIJg7ly9iy1MJNNT3vUbPdPmRyIVVzZ2+QxNP+S5saiZTapnraDS63Q3gaimt/mRj9XpHCebRt9842F433/peOrMirCksxySL18q8xpULAEPrYxpyI7J7GEBd7BZ8+epq1eqPfAAqQK4+Mw3mb5sd6GEzZ87Vb5MeUwyDwQrqfDb8g9tV4swRpeX93Jiop98Pvij+72dfhTFL7WpWm3OaqdwTQTFVjFAPy2qy4AdU3gFTfoKSZZR24wa+FUEBelOEaOI7e7qlemxWOPbyp0VgkqhWEOcVbEV9bOTWyKtfI8OzM35s74oeHMI9wKxB0/59u0JB1sOI/giOaDWkQKOfGkWPQVT9rSLSCNCpi6vvtAlTOAxUo8yxNatEWQrodFeSBr8z4WBQuNeb5a3U6DwhLOStVdg9NiCqJK0x7sq7aEmNcHxVYZtpUBtgVb760Ya8mSnlGd3oS84kHJpk+YsN7yntbfEVLLeMffYM87ED1M23YxIRmuKgvjuh/86CcGFIEkO3/BeGep3d/J19sFrkmN7fB399fSTCEkNc+TY6euf1QWZIAGTpB1znLdTbf sWFJQuPG Jo7wfag7nNUHaJkNy8DjtfHAZxyO3XOAGQsLm/axxcw3CycEmKOdnfWiAp7gNIWWnhIkMarRt3Zgqw1VVyjKe7NQZgzFLDWztx8tQOFcuQM2wpWTeD2IYIgicpCmmV87nNJwg0fdoBOdbO8arVW0Z48FncAJJ2H0VIA96p2eXPp2PZh7wjBDcu3hWr9+rIQ1ZRYMOjWwohmfLH3YEqKLMdTL8fiQ5jBoq6vdYMf2kjFWRpCS4hoEXQlfYVR1ByuOhNdlXnnEWJ67cnsCWKM3Sr+EFOkXV9Pnhb4XYrnD+hVT43Kr3MUQdQ2+NSwNyrscXHfWbCAYcS96hel6x4YSIxj+0y2IbYBUaLhG2vzSZPfaF0roqaW1mj6zRu29XRknn9tTd36oLhHJusOrhLgbby/jfDtNE7/3EMJ8fnDdwv/EQXLQhMhrtSWvKQmSkbb2DnolzY0wsduUpGYtCkV0JMvKWZn8l32XA1HVCKMqp19K7EN4FMKhuEj/mvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 8:30=E2=80=AFAM Liam R. Howlett wrote: > > * Nico Pache [250713 20:33]: > > The hpage_collapse functions describe functions used by madvise_collaps= e > > and khugepaged. remove the unnecessary hpage prefix to shorten the > > function name. > > > > Reviewed-by: Zi Yan > > Reviewed-by: Baolin Wang > > Signed-off-by: Nico Pache > > > This is funny. I suggested this sort of thing in v7 but you said that > David H. said what to do, but then in v8 there was a discussion where > David said differently.. Haha yes I'm sorry, I honestly misunderstood your request to mean "drop hpage_collapse" not just "hpage". In a meeting with David early on in this work he recommended renaming these. Dev made a good point that renaming these to khugepaged is a revert of previous commit. > > Yes, I much prefer dropping the prefix that is already implied by the > file for static inline functions than anything else from the names. > > Thanks, this looks nicer. I agree, thanks! > > > > --- > > mm/khugepaged.c | 46 +++++++++++++++++++++++----------------------- > > 1 file changed, 23 insertions(+), 23 deletions(-) > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index a55fb1dcd224..eb0babb51868 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c > > @@ -402,14 +402,14 @@ void __init khugepaged_destroy(void) > > kmem_cache_destroy(mm_slot_cache); > > } > > > > -static inline int hpage_collapse_test_exit(struct mm_struct *mm) > > +static inline int collapse_test_exit(struct mm_struct *mm) > > { > > return atomic_read(&mm->mm_users) =3D=3D 0; > > } > > ... > > > -static int hpage_collapse_scan_pmd(struct mm_struct *mm, > > +static int collapse_scan_pmd(struct mm_struct *mm, > > struct vm_area_struct *vma, > > unsigned long address, bool *mmap_lock= ed, > > struct collapse_control *cc) > > One thing I noticed here. > > Usually we try to do two tab indents on arguments because it allows for > less lines and less churn on argument list edits. > > That is, if you have two tabs then it does not line up with the code > below and allows more arguments on the same line. > > It also means that if the name changes, then you don't have to change > the white space of the argument list. > > On that note, the spacing is now off where the names changed, but this > isn't a huge deal and I suspect it changes later anyways? Anyways, this > is more of a nit than anything.. The example above looks like it didn't > line up to begin with. I went through and cleaned these up, both on this patch and future patches that had similar indentation issues. > > ... > > Reviewed-by: Liam R. Howlett Thanks for your review! >