From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D6DC43334 for ; Thu, 9 Jun 2022 21:51:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25C848D004D; Thu, 9 Jun 2022 17:51:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20C238D0034; Thu, 9 Jun 2022 17:51:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AE068D004D; Thu, 9 Jun 2022 17:51:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF7268D0034 for ; Thu, 9 Jun 2022 17:51:13 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B439E35B3F for ; Thu, 9 Jun 2022 21:51:13 +0000 (UTC) X-FDA: 79560043626.15.6FA3F8A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 56628C0058 for ; Thu, 9 Jun 2022 21:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654811472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GmYtaQLv1m6AJWe/7StrNTTypt8bklBHRRA6RHL2h34=; b=enx2xe4hCLcFbRqAEtG/swey6duKvcTY8vA87Y/Z5/ugZ3q376JHo4s73F4aKxHkSsSlEd DRar8W4113+Xjqt2x39USUKdu7zdtOtzBjylO0Bt2IIum4V32IaCRWzii0zs9aIUVX24tn an3vLhzTpmMugP31HB8Ly7VPyPawHs8= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-534-fMmX3azFPki7fOd7HzVxrA-1; Thu, 09 Jun 2022 17:51:11 -0400 X-MC-Unique: fMmX3azFPki7fOd7HzVxrA-1 Received: by mail-ej1-f70.google.com with SMTP id l2-20020a170906078200b006fed42bfeacso11629025ejc.16 for ; Thu, 09 Jun 2022 14:51:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GmYtaQLv1m6AJWe/7StrNTTypt8bklBHRRA6RHL2h34=; b=TNYfTbKMHrkQ7PjBQK6Kk8r0xOy4ElMONiFnlkhMkQ0Cioxg1/jSqfPlqGYQZxkL9Z q7MhkG+8fa+pFPCFhT9TLkQA+dO0dVKg8/mdd1Sc0Kk3+CGrg2dhABRI4Ja/StR30XA7 sj/90H1hTJYhOcqsFHmxcAHomOtKLVDsQWwJms1ytYUGRw1LbUykpo1QBGcuY/xlC1LQ cbhT4I69hka400r13TkrglIlWgBX49JVweCpq42G4JVlmHgQ2eFqFwEC2VQXFSY5524m 5lYKZOwpcdAJOp7szeWcWsSNAcEgnMKmC+t0ykQb7ROHFtBjgpvoGm1thP2xy+b7tblI JkEA== X-Gm-Message-State: AOAM531X22RkShLYeXapWxkr4q4BhytC6mR1X+b6nB9vztJDc6jPE4DV 5HGvQM9G6B3RonlXBzTYFV2HL5kLkCGBF9+Xc0IFy4Mze2RCvsHd0PMH1bzL80JXkXN+hFoaf0P oEiIcDvvCfullpo805m9IPNp3tzQ= X-Received: by 2002:a05:6402:4252:b0:42e:13d4:4f4c with SMTP id g18-20020a056402425200b0042e13d44f4cmr45220218edb.92.1654811470704; Thu, 09 Jun 2022 14:51:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgfohrCsONWHPnjM7ZXVDR6JY0sWZrG3K4u6Txy0MsPzphhqyPqqWjb2xYiQ1ApKHNUv0Q0rpmqtixQooDpvE= X-Received: by 2002:a05:6402:4252:b0:42e:13d4:4f4c with SMTP id g18-20020a056402425200b0042e13d44f4cmr45220193edb.92.1654811470494; Thu, 09 Jun 2022 14:51:10 -0700 (PDT) MIME-Version: 1.0 References: <20220609203217.3206247-1-jsavitz@redhat.com> In-Reply-To: <20220609203217.3206247-1-jsavitz@redhat.com> From: Nico Pache Date: Thu, 9 Jun 2022 17:50:44 -0400 Message-ID: Subject: Re: [PATCH] selftests: make use of GUP_TEST_FILE macro To: Joel Savitz Cc: LKML , Andrew Morton , Shuah Khan , Linux MM , linux-kselftest@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654811473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GmYtaQLv1m6AJWe/7StrNTTypt8bklBHRRA6RHL2h34=; b=CjE1tGgztR2mo/LBNGDzWzz6mkKdouYIctD8tRGly1ZRWPUzNACTmxeEf1Wls6IwI0BAxa qJyhaOdQu7Q2QgwIG8gHoTDtFSi3SgKEOkOAc5dlKhBfNxmhJfyKXC0VQkptkUH8maZ2g8 OYMnEIc7opyWfsetd2Ju6Mj0LAI/oRc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654811473; a=rsa-sha256; cv=none; b=oPWn2VTBRlvfQNzr/sXVoc5COkTYFLk3tdZb+Ouc23X3nesKTKat+9KWi9plpsuaztn0+y p77JXYBDBEqtMqglOwADia6jTlG69F7C+CuErdDzDCh30a8xXKUuSmQ2gUTdma1XimQvda DbObC/4kYZY03C1o4LrNtqEh+N9QUjU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=enx2xe4h; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of npache@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=npache@redhat.com X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=enx2xe4h; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of npache@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=npache@redhat.com X-Rspamd-Server: rspam03 X-Stat-Signature: cqqkpf34pc3o648udukf3e99wjsdqb4d X-Rspamd-Queue-Id: 56628C0058 X-HE-Tag: 1654811473-369086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: LGTM! Good catch :) Acked-by: Nico Pache On Thu, Jun 9, 2022 at 4:37 PM Joel Savitz wrote: > > Commit 17de1e559cf1 ("selftests: clarify common error when running > gup_test") had most of its hunks dropped due to a conflict with another > patch accepted into Linux around the same time that implemented the same > behavior as a subset of other changes. > > However, the remaining hunk defines the GUP_TEST_FILE macro without > making use of it. This patch makes use of the macro in the two relevant > places. > > Furthermore, the above mentioned commit's log message erroneously describes > the changes that were dropped from the patch. > > This patch corrects the record. > > Fixes: 17de1e559cf1 ("selftests: clarify common error when running gup_test") > > Signed-off-by: Joel Savitz > --- > tools/testing/selftests/vm/gup_test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/vm/gup_test.c b/tools/testing/selftests/vm/gup_test.c > index 6bb36ca71cb5..a309876d832f 100644 > --- a/tools/testing/selftests/vm/gup_test.c > +++ b/tools/testing/selftests/vm/gup_test.c > @@ -209,7 +209,7 @@ int main(int argc, char **argv) > if (write) > gup.gup_flags |= FOLL_WRITE; > > - gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR); > + gup_fd = open(GUP_TEST_FILE, O_RDWR); > if (gup_fd == -1) { > switch (errno) { > case EACCES: > @@ -224,7 +224,7 @@ int main(int argc, char **argv) > printf("check if CONFIG_GUP_TEST is enabled in kernel config\n"); > break; > default: > - perror("failed to open /sys/kernel/debug/gup_test"); > + perror("failed to open " GUP_TEST_FILE); > break; > } > exit(KSFT_SKIP); > -- > 2.31.1 >