Re: [PATCH V3 1/5] mm/khugepaged: remove unnecessary goto 'skip' label

[Nico Pache <npache@redhat.com>]

On Sun, Jan 18, 2026 at 12:26 PM Shivank Garg <shivankg@amd.com> wrote:
>
> Replace goto skip with actual logic for better code readability.
>
> No functional change.
>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> Reviewed-by: Zi Yan <ziy@nvidia.com>
> Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
> Reviewed-by: Lance Yang <lance.yang@linux.dev>
> Signed-off-by: Shivank Garg <shivankg@amd.com>

Recently I did a round of testing for khugepaged with regards to my
mTHP changes. This series was part of that testing. Thanks for the
cleanups!

Tested-by: Nico Pache <npache@redhat.com>
Reviewed-by: Nico Pache <npache@redhat.com>
> ---
>  mm/khugepaged.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 16582bdcb6ff..984294a16861 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2442,14 +2442,15 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result,
>                         break;
>                 }
>                 if (!thp_vma_allowable_order(vma, vma->vm_flags, TVA_KHUGEPAGED, PMD_ORDER)) {
> -skip:
>                         progress++;
>                         continue;
>                 }
>                 hstart = round_up(vma->vm_start, HPAGE_PMD_SIZE);
>                 hend = round_down(vma->vm_end, HPAGE_PMD_SIZE);
> -               if (khugepaged_scan.address > hend)
> -                       goto skip;
> +               if (khugepaged_scan.address > hend) {
> +                       progress++;
> +                       continue;
> +               }
>                 if (khugepaged_scan.address < hstart)
>                         khugepaged_scan.address = hstart;
>                 VM_BUG_ON(khugepaged_scan.address & ~HPAGE_PMD_MASK);
> --
> 2.43.0
>