From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF44C5478C for ; Mon, 4 Mar 2024 19:09:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 035836B0092; Mon, 4 Mar 2024 14:09:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F27A56B0093; Mon, 4 Mar 2024 14:09:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEE9A6B0095; Mon, 4 Mar 2024 14:09:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CB5E66B0092 for ; Mon, 4 Mar 2024 14:09:22 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A8681C0C9A for ; Mon, 4 Mar 2024 19:09:22 +0000 (UTC) X-FDA: 81860294964.08.B492666 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 8496614000A for ; Mon, 4 Mar 2024 19:09:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NYVdQg0F; spf=pass (imf09.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709579360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8tiOsoLjDyH9qgATuk9KBE0wMThlXEkQhbl+ACqPams=; b=By7Cv1Zh1I9EqBmPbYxkcYUyhhjo42FxOUVveNhy3WOJ7Etlh+lJBSRVZWjD4ueLSUxsm/ vJPAfEl9mKJV85Ek59ZO2ZBXPGj5twD8Dl7UsQpuIqvQDVrH5q1AwHFb4i5+gH/KJ0hf66 7qnBe01HkEqQrUgUkkzomtpmA9SOS64= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709579360; a=rsa-sha256; cv=none; b=3bVGh4WZ5K7Prcq7j6PX3ZGb+0KTTDzK/XX/PXQQfJ4v2It+5f9gQEIz4ESjojSMwGqYet IpkPtrcht25fXuGP3aWa1DlTcO9pgWas1xvsrfzkKdgYI48WvY7yNlUeqarwHhe+J//3lp ry//VBLQvQD+Ptnw65JrmofFp6QhduQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NYVdQg0F; spf=pass (imf09.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709579359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8tiOsoLjDyH9qgATuk9KBE0wMThlXEkQhbl+ACqPams=; b=NYVdQg0FYylJRw41YMtp7idC9b+4z89bC0b7UgJJCal/w81I4MG/CPneRz0YCuASjStciH 8nx9g8V51kf+bepVAGWETM5YFfwsT+DI0M87R2bIjuWUJnwGqCNVeJBwxPYGXyYilMi76u NEHOTokvjcA1bjVKQKxuMqJeoGbwn3k= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-7A2JR-jrNKGkZgUp7cyeLw-1; Mon, 04 Mar 2024 14:09:16 -0500 X-MC-Unique: 7A2JR-jrNKGkZgUp7cyeLw-1 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-dccc49ef73eso8135485276.2 for ; Mon, 04 Mar 2024 11:09:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709579355; x=1710184155; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8tiOsoLjDyH9qgATuk9KBE0wMThlXEkQhbl+ACqPams=; b=HkHmsEV2oCLJWE05MdF2VzNHFJkQspR/gc09+jh2s38pG8wKpsHXbsard3ZltZrxk1 MSt/xitYASUocQ3UNlZ8kM2+uLVw44GJaNIWluQRaUWqvoznVFv4oZkwKiukkCZiIE7H XQuS2Hb4XgLN6+KoPixMdzuEgmIvCk8wzWH7Mpc6UPEcyAiH8slQF1okBjXGyxl9TJbu P6ytDP1b9ot2pRJ8LhDF4YmlhxqLZUYotbyaPqUmL5GKFoTEANEiFW0BgRBRpGyl726F sWNLGYaaulNfRVUpQBBWbZx2/4Xa4WB2TP0WqfaCmt1PI740vtVE9BazWQmg1JT22G3k 6Tew== X-Gm-Message-State: AOJu0Yw2jElm4OsKG48csGcnfAkiqkAxOoSQ0Ger7s7+oVJwQsYDCBaW vq801T6y9F1sSap6faHvAQ4/F2vybwbifJ0O85Q8azw90tzcZIPR1Kt8aEeoybBO6GmV/YXt35E pHEgJMGWgYkqQgNULXO5UPN6RVTInv9KVAzyc8YSmvFI3Jhtlu6PBEkyYLtPq1bYkRWBfCNiOTf Sn/XYjpjhJ5Ij6wrUqszE8a4rbWz2g6hk= X-Received: by 2002:a25:b204:0:b0:dcf:56c1:5a12 with SMTP id i4-20020a25b204000000b00dcf56c15a12mr7029280ybj.38.1709579355523; Mon, 04 Mar 2024 11:09:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1WcLBSSbX0iebArXcd5CgjCMzw9CJRS+5TVmsdZ4vzbJ9Vng84vACPnWisD9eqfcpWiPGyAnMVIYG0R7e6VQ= X-Received: by 2002:a25:b204:0:b0:dcf:56c1:5a12 with SMTP id i4-20020a25b204000000b00dcf56c15a12mr7029265ybj.38.1709579355051; Mon, 04 Mar 2024 11:09:15 -0800 (PST) MIME-Version: 1.0 References: <20240301073300.287508-1-npache@redhat.com> In-Reply-To: From: Nico Pache Date: Mon, 4 Mar 2024 12:08:49 -0700 Message-ID: Subject: Re: [PATCH] selftests/mm: Dont fail testsuite due to a lack of hugepages To: Muhammad Usama Anjum Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, ben@decadent.org.uk, shuah@kernel.org, akpm@linux-foundation.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8496614000A X-Rspam-User: X-Stat-Signature: nnjnhyiw4qqtxkxyngmn6ybz16mkea8i X-Rspamd-Server: rspam03 X-HE-Tag: 1709579360-561184 X-HE-Meta: U2FsdGVkX19ecsRT3sZ/zvyZ5vEYIa/t/K7yH/D2BsLT/nKThReXQxhToWD54B+8lcgqMSpmtCdACjd/BaWjJOdPNnPaU9gqBxKuwu5F0ehscTkw5+miDF5zOl4dINXbVt6RweYKDI+xGD9BaH1l66xhMnT/jU1Gi9MzZPrCSh8/AQZt5p7CMA2KYSkClOhC73cd5ZY84V7ZarMgxdNQOovfN83kxKJ0zDqu2vAeTuvH9WB5Qk7WDTZfXWy/aa0i7gkCqZb7VOZJm8EC57fybaKwTN2yK73zndsdQgpbuImMTrbdgJb/6oN05ZQFGHTInN7K7omvhrNMMeYKOZ0Ft4f8I0xz2PQyhM0EHLgaUSpuCtoLlU61jMaq2xBraXz87fFbr+490S/416U/o48YYB2BCGAusQe6gioP7z6Lw+YC+AJI1FYA5MY4nyx6Re8/+4dYcZ3jl0eOLDHZsKYum8fMDChXIWr0s3JpLobzjubMJMgFwvPQcW2+fiP6Dp0Scuvv+gNmRqkOgk6MaQOVF3Q7pc1X51JLwEj5PTbaRQ7noAcp1PQFuqPgnHMNjcppybm/3BT7Z4rKYQNcGBTXiCD9XXMUa4sCJcR/6eL2b7tw2Vqy0n9nml7HX2ZmkiO4zhoSSX8E/0c/PrXNRIf836j+EabRQN702AeYYSYk6pik8yNzXzEEC+t9+O9qvTCgGGirW1sCNaW1BzEjdEaGfsyS3CCQH6qv9DK+475To9xHuPK6lowJTeAmH6pOMYgxKBSUThtAd3cQBJk7xZggs0og1RloIYSk/zGkRttQL9Ht286qnl1kH+WmyDynXpIccNgd7CQFTZH/wSvH4yGSnAvrrXQkN8RW8dcj/xw2uVUPcfgACcaCb8DfiVxsGfi95Fbye9CLqnQ/ebLu4nYjMJIExxZDOmW2Wnx8/q3n2pebL+LMmSFX+QoKtiMKDO8RX0pHvK4izq6W5JheXq1 nzl6HyeS LZouCaYxb/SLkn+hx9n7mG3mWJuA5LjW7c9ay1/2LG86EdI+EYxDh0L0FIqS2Fkhw3AFrnFVCuV/U8Y2dxcNMsrbWasSh7pwJhmYLxKCmmNIymPYNlDKQxZyFSEzZqehGpzRL7kGVj8tPujF62UzO8b+EkLCIwU6u72ch52TNj9BqmkW5ICqNOidq8D5gDffhtuJPiFmUplpgcn4cpTvm6XTpmH3m0GNbdfef4MwcvpcGi9tRi+E/AEU8L9qTUv0utFOWyzNfr/8mRjWNbyN9b6EArjgrWS49j0FzpzsEDGLsv8yPc6qbwHsIcS2vuAXgaJ688hXIoLzXT0M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 1, 2024 at 2:35=E2=80=AFAM Muhammad Usama Anjum wrote: > > On 3/1/24 12:33 PM, Nico Pache wrote: > > On systems that have large core counts and large page sizes, but limite= d > > memory, the userfaultfd test hugepage requirement is too large. > > > > Exiting early due to missing one test's requirements is a rather aggres= sive > > strategy, and prevents a lot of other tests from running. Remove the > > early exit to prevent this. > Why don't we only skip that particular test which requires huge number of > pages instead? Thus the behavior of this script would remain same. Hi Muhammad, That would not solve the problem-- The issue is not with the userfaultfd test, but rather this part of the script that tries to allocate the hugepages. If it doesnt succeed at allocating the right amount of hugepages it will exit the run_vmtests.sh script, thus stopping all other tests. With the `exit` removed, the test suite is able to run, and upon running the userfaultfd test will result in a failed test case. If you'd like I can follow up with a patch to skip the test cases (in the actually test) rather than failing. Cheers, -- Nico > > > > > Fixes: ee00479d6702 ("selftests: vm: Try harder to allocate huge pages"= ) > > Signed-off-by: Nico Pache > > --- > > tools/testing/selftests/mm/run_vmtests.sh | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/= selftests/mm/run_vmtests.sh > > index 246d53a5d7f28..727ea22ba408e 100755 > > --- a/tools/testing/selftests/mm/run_vmtests.sh > > +++ b/tools/testing/selftests/mm/run_vmtests.sh > > @@ -173,7 +173,6 @@ if [ -n "$freepgs" ] && [ -n "$hpgsize_KB" ]; then > > if [ "$freepgs" -lt "$needpgs" ]; then > > printf "Not enough huge pages available (%d < %d)\n" \ > > "$freepgs" "$needpgs" > > - exit 1 > > fi > > else > > echo "no hugetlbfs support in kernel?" > > -- > BR, > Muhammad Usama Anjum >