From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45BCC021A9 for ; Mon, 17 Feb 2025 19:24:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D6FC280093; Mon, 17 Feb 2025 14:24:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68878280092; Mon, 17 Feb 2025 14:24:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52794280093; Mon, 17 Feb 2025 14:24:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 347E9280092 for ; Mon, 17 Feb 2025 14:24:16 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D5D10B1C32 for ; Mon, 17 Feb 2025 19:24:15 +0000 (UTC) X-FDA: 83130412470.02.817A364 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 89F222000A for ; Mon, 17 Feb 2025 19:24:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f22ZXOZp; spf=pass (imf03.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739820253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rdbMLJJGNPMZE86U034IIF2tHWWv7Jlyf8ALOn6BLhI=; b=b5zqO6cPn9dl3NLIuE30ohBSfP2VYDwvtCyDnX84+WT0E0ZAQsA2fSfII8WJxnPPuv+UWz 9oR3g+4Y12q/KwlF9ylp5YcBmTB1xt3NB4IqqjXAeSkhRZV0207hEsj7DUOuc95oQz0mGm g3isPNgJ/wBIpubTsp2rIlHwlBwDB3U= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f22ZXOZp; spf=pass (imf03.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739820253; a=rsa-sha256; cv=none; b=R0nbYomBPgRyWTuNQvhfDN8NBnSG62Ji4Iokll98FZztKo09uW/bZRn5DB/TXOEOJY78pl zhb3uAGEcqPz3MCqSePUsC4st4iHuyM+B9YuWpHLDpipEiX8f3Mpidta9W4ClrXsissrcC B7oVEkMnU696xlY6mgH+mWWru2MT82E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739820252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rdbMLJJGNPMZE86U034IIF2tHWWv7Jlyf8ALOn6BLhI=; b=f22ZXOZpI+ROBG2ndapnkzcubOWUqGKdfyQGOmKrS4reftkQOD+gBRa0OzxuedfzsnDVpX yFydYf1BCdZ+jzufD9uwztKWN/Kw8wyywmab/A9pHHvNijPZxa+JPD34WW3auNso2t3o5j OGOIQomNdsEhwg6WCrDA/rSh3a/SIrI= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-M8lNQCABOEGV4tmB7GxWwA-1; Mon, 17 Feb 2025 14:24:11 -0500 X-MC-Unique: M8lNQCABOEGV4tmB7GxWwA-1 X-Mimecast-MFC-AGG-ID: M8lNQCABOEGV4tmB7GxWwA_1739820251 Received: by mail-yb1-f199.google.com with SMTP id 3f1490d57ef6-e5789a8458eso5838514276.2 for ; Mon, 17 Feb 2025 11:24:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739820251; x=1740425051; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rdbMLJJGNPMZE86U034IIF2tHWWv7Jlyf8ALOn6BLhI=; b=nleEa0UWw2BmclyR6HarPJRZkdHBtE+JUdfyjbbzHeCqg+TInC6UX7w9UIkrMnFgP4 pegzV4sE7kiTCN96PS5KG+SnAmrvkAzaiP/rjMoZqb65ZL/i6LCw0cR4IGb06LHsC/Sf DRpBFuRJVaCuFuVkeXWKSRyTQ5czrS53FAOMx3rDnZ9rWpOOxuFyxOLoqc3xjYhYVO50 YZICOW/24gXxrFSMknnAL6mBTTQGqIa2+dextfLS6fqsIJo2y/yrPXSYlHxDbryC1YPH dbldcl2vmkrfI8hYbCZYZlXHMv2X/Tuva2Y/omg8DjfPgwgP/QzRsrUrYleJXmNYs3sI lsVQ== X-Forwarded-Encrypted: i=1; AJvYcCVpUbu1fUFnhykcKemU/8ilQiYt3cQp3oEsKraPrjUg1iUAil27ogZm6/Ejcn//D7brIgdFe1XS0g==@kvack.org X-Gm-Message-State: AOJu0Yw269Yy76t39XY3MnSLadB3Y+s8dbhavCkOHZ/jkJYCFn7+vgcw yxeb8lh1vv26EhoVWNHpyR2PV4rtF4z5C7UZM6wWJfLcF92zmLd6uQqCGoC84gdDpnxjhrTICUC oS4/dppF+63+x9AKHsr0ijlKIPDESUF3W+jEJEHreCYIpv4JDrtJQBaq8W5SUdb1LKmkxIz5njC 0iQzVFY34vDHtv5+OxagGsOR4= X-Gm-Gg: ASbGncubuHL6591s0h4DIAOP+podtqdtML2jaRGSI8jFYJ2Lhz8WIbljJb4dl9dvHak OhcJR60Ogk77+L1Gz7L3NAW4Sp12pM99Rdd/0vGAHzcx8fLxZkcxVPcrFf88miMDTcqf8Mv8/jL Q= X-Received: by 2002:a05:6902:707:b0:e58:14b:6f99 with SMTP id 3f1490d57ef6-e5dc901f547mr8915051276.1.1739820251064; Mon, 17 Feb 2025 11:24:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrYJ+VsXOI7bm6RpW9QE+8ogDjp6XZe+FrO+0Ua+m+u7LfKjMyLDagrscG092+H3ywzM9KEOxGNYAFwBDzmPg= X-Received: by 2002:a05:6902:707:b0:e58:14b:6f99 with SMTP id 3f1490d57ef6-e5dc901f547mr8915020276.1.1739820250714; Mon, 17 Feb 2025 11:24:10 -0800 (PST) MIME-Version: 1.0 References: <20250211004054.222931-1-npache@redhat.com> In-Reply-To: From: Nico Pache Date: Mon, 17 Feb 2025 12:23:45 -0700 X-Gm-Features: AWEUYZnrFfBm_wbf5EFCjaf6bQ2dpqtlNGkqHB1w5LssQl9ZQBUHAWZR74WN2LQ Message-ID: Subject: Re: [RFC v2 0/5] mm: introduce THP deferred setting To: Usama Arif Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, willy@infradead.org, kirill.shutemov@linux.intel.com, david@redhat.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, sunnanyong@huawei.com, audra@redhat.com, akpm@linux-foundation.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, tiwai@suse.de, baolin.wang@linux.alibaba.com, corbet@lwn.net, shuah@kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7WIHSY7ObHkemuZR1HIPn6bMKBc-sIYgqkXyFf4adjk_1739820251 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 89F222000A X-Stat-Signature: ntpt8kebzwyydk8pdguxno34fh8qysk3 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739820253-340417 X-HE-Meta: U2FsdGVkX1815rZEGePJRO4qEXpQTGCESpczZC6ZtuqnVP48N7bQWaU90l5GiQBw+5dCzRgy9vXJGOME9HapRZ4IXZhHsWZhtxuClAJi4ygwlcG0nQmtnGKhsQS0n0J6oPA3PYEA4JthZHlo3ar3JL5ExTXeRB2gRD0mut1HVgys1kX3dND3GwsTsdmR3U0gwUN5D4Dtb8lV5dDJnO8r67p1GxuY3ujcjjL0GB0NHKuDiP1K4q77pyEs8lKFzFAY3Qw4NCPuvdUfBsSnyAtXIkyC5xf3L9M+u2kYy8VW+v7bnR3+jMYBDGgXp9eDJavF7dZp/gGrJ1lHEugQaJjhn3GHAVeBAgT+IuDxJurKocs416RMO3/XhX2Omzmw/ZLT9iyhuE4xkp6eqOeBzanKZBBixW7YFSpYnH2vbIBEjwl5d83Dwx0T0j8DZaG3rWKv0whkH6jVs4QCqHh6uaqzW6hMR2T7b0VQeEkhJ8a/iu3aexvdJ9iCSxg2JLCNa6SUxnnBNAe7siyaphlBjXnQK9LLiD7M1q027BSMF2nrOItsiS2g6Z5IVks2CPToT0+mvbXA1Q3dZNSiqbqB/L5oxe8pyYT/YJ79gbRoxZGpkpOBsqs0/yBbQbCVfElHm0A63XaWSwNRHfGovqJjXwG8rY5VlMR4bnpygB7a2GRkm7i17d0Kd7PnOYbkeuBVrqW9k1QIA271rdLj3QdzGFJ6gSHzAae7i+SVY2Od0iMDTH8mMzcSracpWDOzbuBLD+8dEmjvM05Kdrq+ORcLDOAZATvWLM/iRCDwpTWckNWCpx41a+J2NT9wpP9fisTff5PfhW9P9XBNytHCv+YIYxw7flHYO2ivff3iKYwkVHoGtUaw815EyPTPhQqVgnK7KY6bnJXzoOwQ4Oaxoms3bGyeSav8dvCKoubZ5LujQlGAjz4UsgoaxoO0c9g1C19ySzMB+9c+Gj7Pa+3c5RK9812 rR2PEZMi K5vmhbEi2C39OeLbAmXLnRbkaUhmSfcAaUgOtNDGbkyNi+LGW+5U1Qvkw3UsaUbm/KkUx9UDwMC9m1tkioMvIJlHB+pnctR/M0NC+mHu5HrkfB7ewLpJKZp6VwQybivzuZyj7M+BES+zQWDW3GRXVCrvXm/tMd56yoxykMA0AT3z+R1elNQmnoiJLzP1JWmRavRqwuyU+9IeEsPcfxQpPaqoOQXbL7dIX8lxrB2qBZ/a/JVesbJ7Nl481TEdgafJ519vuDNBW+tpBy7SdIpjf9A7LBFK+sMqZiBxVXnjrlXCXlxHYkwiTYokGa2LEeI6q77gkAgh7v31a9DBsaTW288YipbuIljzSN2aitZ96KmHQ4lA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.133696, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 7:54=E2=80=AFAM Usama Arif = wrote: > > > > On 11/02/2025 00:40, Nico Pache wrote: > > This series is a follow-up to [1], which adds mTHP support to khugepage= d. > > mTHP khugepaged support was necessary for the global=3D"defer" and > > mTHP=3D"inherit" case (and others) to make sense. > > > > Hi Nico, > > Thanks for the patches! Hi Usama, Thank you for the review! > > Why is mTHP khugepaged a prerequisite for THP=3Ddefer? > THP=3Ddefer applies to PMD hugepages as well, so they should be independe= nt. Its not a hard prerequisite, but I explained it a little here: https://lore.kernel.org/lkml/CAA1CXcBPt4jHfH0Ggio5ghSYAQAXf08rO8R6b1faHzdjF= f_Ajw@mail.gmail.com/ In general, the sysfs didnt really make sense without it, and given mTHPs came along right when i was working on defer, I decided to add it to mTHP too. I worked on and tested these together so it felt right to sync up the V2s for both of them. Cheers, -- Nico > > >