From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 672C9C3ABA9 for ; Wed, 30 Apr 2025 18:39:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B48B6B00BA; Wed, 30 Apr 2025 14:39:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 763956B00BB; Wed, 30 Apr 2025 14:39:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B6436B00BC; Wed, 30 Apr 2025 14:39:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 33AA46B00BA for ; Wed, 30 Apr 2025 14:39:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1E84D120823 for ; Wed, 30 Apr 2025 18:39:44 +0000 (UTC) X-FDA: 83391573888.16.1195BE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 9C76B8000C for ; Wed, 30 Apr 2025 18:39:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eoq0GoUf; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746038382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IRjxDxDhTYKrorsZixsAP5Kxt917TzYAbdZEFQfMsaE=; b=l5HkX+hyWpslYWt7LhusyVpSPKXmkAlme2Dp/nlcLvuJFwk0E+qROYvrTt8mQCg8t+AdRy VgmEibRXk3CmNYgv7yLOwNhAqaopx5Y51sAKw5RDEpJE++jSs+cDSZB9B1H1vqNZr4wph0 uNNWggv+X7b8qlvLhpmcJN3n6qG2wSg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746038382; a=rsa-sha256; cv=none; b=je3LjqXiD8qovRiHayfFg/fnEh0paGknPpWBkxxfwD+HVmzAcT4+sHVxGEHCtyv58MNQPG 2ZJ49IgUfzHt/OpwYV4+SvWSiul65qkOpNTIh5B22pAHkuxttG+6v55MHsJtuSJX7kDMNj 5Pl5O4ZgeXa2DfgKACeY07DALH8GWqQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eoq0GoUf; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746038381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IRjxDxDhTYKrorsZixsAP5Kxt917TzYAbdZEFQfMsaE=; b=eoq0GoUf26MlbINVz+LTx0WINZIS5JBhFzfJ2Hg4hSdQu3l6V2A+wF4YMVdDxSduDRWtit FxTmBC/uEqcTANzPd+YQKkL+1tMA1ELy5WXC5/G2dURI1rK+vClDubrakfm+XpgawBMUsI jDmWWH9zrJa1WZyuAv3fjGbUT1RQbik= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-9Dtuv7d6NXi2RUMo0L8s2w-1; Wed, 30 Apr 2025 14:39:38 -0400 X-MC-Unique: 9Dtuv7d6NXi2RUMo0L8s2w-1 X-Mimecast-MFC-AGG-ID: 9Dtuv7d6NXi2RUMo0L8s2w_1746038377 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-706b84fe6edso2831827b3.3 for ; Wed, 30 Apr 2025 11:39:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746038377; x=1746643177; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IRjxDxDhTYKrorsZixsAP5Kxt917TzYAbdZEFQfMsaE=; b=oYjei8vAoP+5E8bltWnPnB0H+3TYxg/hN1+91wQyVRGDYXZRwUkGoMM9G/KFvPBmnH WiPIvjeSEXyDsvgESHIYFJ+vgQ9nec7tIpZMTwcNltIZji3H34rF0cBer3Q3rgP9NE8x 6GWjmOLJG4qcUl4Ah/MO/LJW/vzyOAV+RGHXVefbHnIJ75/bh4nii/tDGNvooGiitUC6 lJx7PQP1uiDvnC8XFUVpjEU1wMJA5We289OWan+rCKitJlFV4mIVHgIqNLA9r0qi3RBJ SHk5L8wZn6dLquM3HYca17xdpN2rQeo9wV8uTkjL8+QeiqEUJ0niLjjz5hUZY9aJTQbc ym8w== X-Gm-Message-State: AOJu0Yzhb46WO3FNoW9tEEPujY4uq6PQTBvfcMQVw6pmaJLOv+2kK+1n nOPFeelGgQwHqkgBYEstFSDOvPfa7j0rJgofDiMk1KCAJpTvJP/EbCy8z/QmryQBR0izo+L7/tN zehCQWHvcuzQk37D6bX+5f3Mpj0nB0wrK+bA4Z+u8NsfYUVxtTbyBqSkyzcONiRPfb4PNqztMV/ zU1Rmd6vVgzq/0NUmXJo1A7Xo= X-Gm-Gg: ASbGncsJNGNBz6YeA4bTvG68UB/1YEie/yJHPjbkYMpk+a1gZn6qAy0XM02+gm5FlgH /4ic7yl9L19lTT9JJSoKTJWKWIO2ZopqOO2/dkb5sb7oA3tFEQjcIQBn35xnxCr7/HZpRDqDZbi W5ItGH+kk= X-Received: by 2002:a05:690c:9:b0:6fd:a226:fb6c with SMTP id 00721157ae682-708abdabf95mr62404217b3.17.1746038377118; Wed, 30 Apr 2025 11:39:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUG8Gr8pCuMfJMWlcmWUQoisJmUZ1EDMBMinzj6P3MiMpx3S+K06g4TgDXVqU9n7uNHGfUH5de6C068UnlTA0= X-Received: by 2002:a05:690c:9:b0:6fd:a226:fb6c with SMTP id 00721157ae682-708abdabf95mr62403917b3.17.1746038376803; Wed, 30 Apr 2025 11:39:36 -0700 (PDT) MIME-Version: 1.0 References: <20250428182904.93989-1-npache@redhat.com> <20250428182904.93989-2-npache@redhat.com> In-Reply-To: From: Nico Pache Date: Wed, 30 Apr 2025 12:39:10 -0600 X-Gm-Features: ATxdqUFWpWLVzjLTZtwA2dC3DeeBs_qZQ8boE4jqqynD0FM3HxwqQb_YeWEGAHg Message-ID: Subject: Re: [PATCH v5 1/4] mm: defer THP insertion to khugepaged To: Zi Yan Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, david@redhat.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, ryan.roberts@arm.com, willy@infradead.org, peterx@redhat.com, shuah@kernel.org, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OK4xDhbTtAyaOar4CLzELWPttVRI-8uYFpy4Pr2brUo_1746038377 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9C76B8000C X-Rspam-User: X-Stat-Signature: ra494bho36rme9iwyzf1jjdxak7m8y4i X-HE-Tag: 1746038381-308640 X-HE-Meta: U2FsdGVkX1+GxWroCsKzIyTTPUdsf9TK99CAQc+VeSXCZsvASpZkf23tdb1aJHI2xO69dxDpdBn8pNVm6++9sHuliqC1omlZ3NvGh9jXG07vaeD+2M51SCWuSGlv8lhBRY8BJdP6+nV8Y7VbEnHScdPLvGrD/dDA8nOGvG0V5t4H/Rdym8rHRj7uxTYBiDYYjKuT3PkXRSc4mbeSnisdNSawMqWVNk++vGsjnTF9hBER2CmG6dos9jKk1s4yCjoTYVMIjgY/V0Ia3xTD9Wfa9HpcIgZ98wUFln8SI9D57FrEQKcrEGlLrnGtsWO/0gBatn2Q9IzoetADXEVWQinvQqyCfgotN6K8hK24tPHErXFYRW2wRQmXqe008HY99f4evQaibc6PRDaqyTMeUM8TDsYVSJOvPJ2lOYzv652iPgSbE8RJST0U1m/YCYm8l6OIMxg/NLPqXzzCTi7p2EpXRbEBC/2+76HeqUydrgGM5XM7vfoluBQ5X/O08aML0Th6foTjILYEHwq5zaBbS+0KZPo1v+TbvqhUQFikTEEdSLCXbdUcoWpC9RntBkRfI2gerq9XTe5Kc+9i2TbQM6Lm4wQNO1S9bUP09yiQk1UGQTu0IrF61REVwufpxK69t3mCgyWoxNqtIV6EhtlT37WJ+90wYy5s0hdGkwEkm/SdxqnYk9hXwddNHKJyU/U078/CUoOP5DgdLpiBNp5Ypi6kkg3di71jbhl64/NbKqL80Ix23Sn7bUdYdxnXjp0ziJl7rXg6Tk43AE0CrSR15iL8PIIYqGDNdSd7TPC8n22/cHaVkGdvJfVsB2dRqkx0FSC92uNa//PeRT8dBxOV0RzyZhjWaKRO1ib0hsAgYjryd8HqBPei+Hnj4NXG5TtyuPoxHNCAONx+n3nCbB1hGRwrvYlpBf5s1oYMb+nCynEYSPlWTqrz1Roi1F6U72olevxOaRoJTbWOKPFnVyf4Js2 1OPBhipm HunOiC8yfNm/P35DNhFNVQptkgBbulMW1+4SXzMNx/nPIQJH5tIToBDKCtpKRlE191IbbaodX7WvRkKd0i34GIyplLKoxdqW2hevnqZZyRJV/WAfYK4dwtJ57w0y3fBnuh/i+6BFKIMOd4DCArn0FSsDkzM4gtk37EpnZLCQks5CBih3rCeQf1fEKmeam3aMrESfc6u48NS5Bikx55uUn13sz9RFxlum8LyndvDIPiiJcX+3JASZv78hVWd2REF93HQVqkD5Lc9yz4NBAm45SxdPdt+xfUiu3L8N2/ABsGGo+u6+QCRQYMSZ6wdSO4s+PWWnFGS1VmzzpJcUn27DOJEH/U1boVKxAjvnfpRV9vstPA4Xv9EcOrY0fJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 29, 2025 at 7:49=E2=80=AFAM Zi Yan wrote: > > On 28 Apr 2025, at 14:29, Nico Pache wrote: > > > setting /transparent_hugepages/enabled=3Dalways allows applications > > to benefit from THPs without having to madvise. However, the pf handler > > s/pf/page fault > > > takes very few considerations to decide weather or not to actually use = a > > s/weather/whether > > > THP. This can lead to a lot of wasted memory. khugepaged only operates > > on memory that was either allocated with enabled=3Dalways or MADV_HUGEP= AGE. > > > > Introduce the ability to set enabled=3Ddefer, which will prevent THPs f= rom > > being allocated by the page fault handler unless madvise is set, > > leaving it up to khugepaged to decide which allocations will collapse t= o a > > THP. This should allow applications to benefits from THPs, while curbin= g > > some of the memory waste. > > > > Co-developed-by: Rafael Aquini > > Signed-off-by: Rafael Aquini > > Signed-off-by: Nico Pache > > --- > > include/linux/huge_mm.h | 15 +++++++++++++-- > > mm/huge_memory.c | 31 +++++++++++++++++++++++++++---- > > 2 files changed, 40 insertions(+), 6 deletions(-) > > > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > > index e3d15c737008..57e6c962afb1 100644 > > --- a/include/linux/huge_mm.h > > +++ b/include/linux/huge_mm.h > > @@ -48,6 +48,7 @@ enum transparent_hugepage_flag { > > TRANSPARENT_HUGEPAGE_UNSUPPORTED, > > TRANSPARENT_HUGEPAGE_FLAG, > > TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, > > + TRANSPARENT_HUGEPAGE_DEFER_PF_INST_FLAG, > > What does INST mean here? Can you add one sentence on this new flag > in the commit log to explain what it is short for? "INSERT". Someone else commented on the length of this FLAG name. I forgot to update it. I can shorten it to something like ..DEFER_FLAG or DEFER_PF_FLAG > > > > TRANSPARENT_HUGEPAGE_DEFRAG_DIRECT_FLAG, > > TRANSPARENT_HUGEPAGE_DEFRAG_KSWAPD_FLAG, > > TRANSPARENT_HUGEPAGE_DEFRAG_KSWAPD_OR_MADV_FLAG, > > @@ -186,6 +187,7 @@ static inline bool hugepage_global_enabled(void) > > { > > return transparent_hugepage_flags & > > ((1< > + (1< > (1< > } > > > > @@ -195,6 +197,12 @@ static inline bool hugepage_global_always(void) > > (1< > } > > > > +static inline bool hugepage_global_defer(void) > > +{ > > + return transparent_hugepage_flags & > > + (1< > +} > > + > > static inline int highest_order(unsigned long orders) > > { > > return fls_long(orders) - 1; > > @@ -291,13 +299,16 @@ unsigned long thp_vma_allowable_orders(struct vm_= area_struct *vma, > > unsigned long tva_flags, > > unsigned long orders) > > { > > + if ((tva_flags & TVA_IN_PF) && hugepage_global_defer() && > > + !(vm_flags & VM_HUGEPAGE)) > > + return 0; > > + > > /* Optimization to check if required orders are enabled early. */ > > if ((tva_flags & TVA_ENFORCE_SYSFS) && vma_is_anonymous(vma)) { > > unsigned long mask =3D READ_ONCE(huge_anon_orders_always)= ; > > - > > This newline should stay, right? Yes, I can fix that. > > The rest looks good to me. Thanks. Acked-by: Zi Yan Thank you! -- Nico > > Best Regards, > Yan, Zi >