From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED63C433EF for ; Wed, 6 Jul 2022 18:38:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 303D06B0072; Wed, 6 Jul 2022 14:38:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28CD46B0073; Wed, 6 Jul 2022 14:38:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12D136B0074; Wed, 6 Jul 2022 14:38:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F123D6B0072 for ; Wed, 6 Jul 2022 14:38:33 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id C857980DC1 for ; Wed, 6 Jul 2022 18:38:33 +0000 (UTC) X-FDA: 79657535706.17.C0614B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 6E0791C0016 for ; Wed, 6 Jul 2022 18:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657132711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6bZNuL7RAHnFV67f4D5x/92+2WjgdYrP06Pk08jyQTU=; b=S0f5jjNs+ciZVys8MoZE77deazBW76DEAwq3suJzq+CFuNHBVLNwWHv7O+i4Q2+z4IQrZ1 AFzwdtJKX4j2Ubwkmcwd/hcoPFepLrTtd6LQwG1vEMLGMYD9zmGbkz8oH8RNJmw0BFH7lo t93ETbdO0r4RQRZ+I4K+eo9mpyAISGU= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-SA1qDrDrM2mbmV4SnXds-w-1; Wed, 06 Jul 2022 14:38:30 -0400 X-MC-Unique: SA1qDrDrM2mbmV4SnXds-w-1 Received: by mail-ed1-f70.google.com with SMTP id x8-20020a056402414800b0042d8498f50aso12321557eda.23 for ; Wed, 06 Jul 2022 11:38:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6bZNuL7RAHnFV67f4D5x/92+2WjgdYrP06Pk08jyQTU=; b=vbl+ZFn5XDlzNQBxmyLIzfm7rCki0CtPHABaN3k0ml0IhTR1kgmbByxQxlDZz6yUX+ ArQwbrlq31TJbQwrPsEZYddiqMjePw4zAi1qy/uUgKZ0uiwvN32xVhRuWD4+4mv2VMxF BnXu+orCSFZkLFFgESxXuJJOVTq7piuYSTqsl73l7K1Gg30Fd3NMwsiS1+SnnSmv1l8t RWPn0oC/aox4JrTMvGK8BB9b32i3bHrF0PMruNigosKY+wkmXphqnewqH245TXOrZ52q PcSu5q+NwaPa6mzgwlOb3p75YbATukI9mI+ZWEveIzwnn58o1Mm4Qv5zYah9ZNEt9Xov b25g== X-Gm-Message-State: AJIora9fCVramR/Emd7uimdbJKMa+UtuFtWGSrYnFpjTi6iA9agbCxVc LMsqLnqYpWIOohFj1hWYNI6OA7imT7hNwKMnbhoUYIneIEDAnXJ23W1euGtSII4nX+dadRrZYZ7 Il6BukUBeCeuFLV7i0zd59SLNEXI= X-Received: by 2002:a05:6402:3514:b0:435:f24a:fbad with SMTP id b20-20020a056402351400b00435f24afbadmr54023797edd.311.1657132709552; Wed, 06 Jul 2022 11:38:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vXkS+TeYM2iH5bLiOApP8aVSIv6LgG4byRceGi0vcWQ4mpyVXCApsVKw0zrZulmdTMksv1p49XD8lx8TzmptI= X-Received: by 2002:a05:6402:3514:b0:435:f24a:fbad with SMTP id b20-20020a056402351400b00435f24afbadmr54023768edd.311.1657132709303; Wed, 06 Jul 2022 11:38:29 -0700 (PDT) MIME-Version: 1.0 References: <20220705185605.3889110-1-jsavitz@redhat.com> <20220705133456.d5572b2e36ebb36188369988@linux-foundation.org> In-Reply-To: <20220705133456.d5572b2e36ebb36188369988@linux-foundation.org> From: Nico Pache Date: Wed, 6 Jul 2022 14:38:03 -0400 Message-ID: Subject: Re: [PATCH] selftests/vm: enable running select groups of tests To: Andrew Morton Cc: Joel Savitz , LKML , Shuah Khan , Linux MM , linux-kselftest@vger.kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657132712; a=rsa-sha256; cv=none; b=eqxx+vONgY9ZsQEdx8xMp2vt6JzqbG6fsp446FeYGyuVXx6yeuas+m0Bp++l9+H+Govd1r nSVTAe8O2N3Cv8E67U/q+GzxypKl17wVSs+f/kjEC5Q8qsjGH1pTChtqIRgbLHX5Vz0zRo W+8YKD8cFLMKY0BHlmz/PZFZ64OVwfc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S0f5jjNs; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of npache@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657132712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6bZNuL7RAHnFV67f4D5x/92+2WjgdYrP06Pk08jyQTU=; b=WGP3YIPy8BDVqg4Es//FK70BPindl8Km2jobRkTT/FNyA16TVJt3uzRpCEhx9T8INl8P82 AmuN3gNlttxNDG76aOTBj16SiQrj2OfXHFmT/NtfkJUukpHKTPPxr0HP+PaBsHEEJcBEDr LDZvnhmOux65R69QSwGb10HNX9wZ/Wo= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6E0791C0016 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S0f5jjNs; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of npache@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=npache@redhat.com X-Stat-Signature: sdqebfjxs5s4ox31czi5txnyajh488jc X-HE-Tag: 1657132712-392227 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 5, 2022 at 4:35 PM Andrew Morton wrote: > > On Tue, 5 Jul 2022 14:56:05 -0400 Joel Savitz wrote: > > > Add the ability to run one or more groups of vm tests (specified > > by the environment variable TEST_ITEMS). Preserve existing default > > behavior of running all tests when TEST_ITEMS is empty or "default". > Hi Andrew, > What is the reason for this? What's the use case? The current design of vm selftests is all-or-none. We'd like to be able to selectively run these tests (We settled for selective groups of tests rather than individual tests). The main reason for doing this is our efforts to expand RedHats MM CI testing. There are two use cases for these changes that relate to our reasoning: 1) Our current CI has overlapping tests between LTP and vm selftests, so we'd like a way to prevent running the same test in two places. 2) We'd like the ability to skip a test if it is determined to be unstable or requires certain hardware requirements. By adding this functionality we are really expanding what we are able to do with the stock vm-selftests. > And why via the environment rather than via commandline args? Just a design choice I suppose. I'm sure Joel would be willing to implement it as a cmdline arg if you'd prefer that approach. Cheers, -- Nico