From: Nico Pache <npache@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joel Savitz <jsavitz@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>, Linux MM <linux-mm@kvack.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/vm: enable running select groups of tests
Date: Wed, 6 Jul 2022 14:38:03 -0400 [thread overview]
Message-ID: <CAA1CXcAFyMLBEi87A0+pBbUKtzfEeE-5uyqPugmHLmzgH8=w8w@mail.gmail.com> (raw)
In-Reply-To: <20220705133456.d5572b2e36ebb36188369988@linux-foundation.org>
On Tue, Jul 5, 2022 at 4:35 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 5 Jul 2022 14:56:05 -0400 Joel Savitz <jsavitz@redhat.com> wrote:
>
> > Add the ability to run one or more groups of vm tests (specified
> > by the environment variable TEST_ITEMS). Preserve existing default
> > behavior of running all tests when TEST_ITEMS is empty or "default".
>
Hi Andrew,
> What is the reason for this? What's the use case?
The current design of vm selftests is all-or-none. We'd like to be
able to selectively run these tests (We settled for selective groups
of tests rather than individual tests).
The main reason for doing this is our efforts to expand RedHats MM CI
testing. There are two use cases for these changes that relate to our
reasoning:
1) Our current CI has overlapping tests between LTP and vm selftests,
so we'd like a way to prevent running the same test in two places.
2) We'd like the ability to skip a test if it is determined to be
unstable or requires certain hardware requirements.
By adding this functionality we are really expanding what we are able
to do with the stock vm-selftests.
> And why via the environment rather than via commandline args?
Just a design choice I suppose. I'm sure Joel would be willing to
implement it as a cmdline arg if you'd prefer that approach.
Cheers,
-- Nico
next prev parent reply other threads:[~2022-07-06 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 18:56 Joel Savitz
2022-07-05 20:34 ` Andrew Morton
2022-07-06 18:38 ` Nico Pache [this message]
2022-07-06 18:50 ` Andrew Morton
2022-07-06 18:53 ` Joel Savitz
2022-08-15 1:55 ` Andrew Morton
2022-08-15 1:56 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA1CXcAFyMLBEi87A0+pBbUKtzfEeE-5uyqPugmHLmzgH8=w8w@mail.gmail.com' \
--to=npache@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jsavitz@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox