From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D12E0C2B9F8 for ; Tue, 25 May 2021 08:17:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D90E61400 for ; Tue, 25 May 2021 08:17:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D90E61400 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1E8BB6B006E; Tue, 25 May 2021 04:17:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 172346B0070; Tue, 25 May 2021 04:17:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F303F6B0071; Tue, 25 May 2021 04:17:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id C13006B006E for ; Tue, 25 May 2021 04:17:06 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5CD50688E for ; Tue, 25 May 2021 08:17:06 +0000 (UTC) X-FDA: 78179048052.29.F01CFEA Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by imf14.hostedemail.com (Postfix) with ESMTP id 97110C0042EE for ; Tue, 25 May 2021 08:16:59 +0000 (UTC) Received: by mail-oi1-f174.google.com with SMTP id v22so29545678oic.2 for ; Tue, 25 May 2021 01:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cHxyz17p2ZXeKQZplPbgBWJclFvSNiYWUobJtjVd2b8=; b=oMXs+07ESuQex86kh1Ni6ZiuW7ZpqCJzj5jbmNHsgSiMV3NzmC9f+86NI0/l4zWWpf 2zfx7FlvJ4EZ64tTlBS8DW4MB59X9+Uib4USjcm+fNoOv+fr0fantDE08a0oHgy84d3O pj0lv94wchKlyuGVkNh2olLV5N/yZTbRz403uElUR97D0xqHmLTbck8PZCtmZr/a/lPT 3suwuRw3hCBuNG0WW6ArWSDoGlS/bqRpgIvG4v6ewV/ASymO268cSlXt0D/mKZapcZzE fFGxb34jupaJiNZx0bBPSnJ4QCB3aQ+8M9OfLOAJwIg1xyDukN+9lXIfPF7hcWQERpvX V71A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cHxyz17p2ZXeKQZplPbgBWJclFvSNiYWUobJtjVd2b8=; b=e0ar/m/E2BUv7xF42uE1FkzHyScGtDi8hhgqDfiLdcq51TcM2Ant9KNrJjJ928WMPX yEH43AviziyEd4A6WtT5bkrjf6uMzOhRhiv4x0C2dE8wABVV5AhTFc9SZ1L7vx4i3jI1 oL1lGa2vlBjoJsPCNCYCjlhHKdPmZW79VjSDIHgRJNl42ft7Wnm7plq7bq1w6oQO5KEj KqpNXKamUkVmydGAUzkA2d6nq/YTCEotxN9qGmjskkXPsYN4MEF/qBxQuo9gyCSpRy0o kPpv3CCRxjySF4sqP1kFMMUlf6vcU7gYyj7XRYhG1EbarnxfRelX9Pd79zI0LZLZIce6 ybvQ== X-Gm-Message-State: AOAM532DO5/GSfl/fhHvPSxuSn7YRDGNytlfL9OZjDoNmhasOcef8AJK n5n/rmdl0U83zL9bR+Taj3PhzX/M7IDkmNd8A18= X-Google-Smtp-Source: ABdhPJzuS5AkmgLnuJd9ZUeOPOgxZTEbVykKwunae9GlQWX2Atb59IdLVG06N6TjcRFJUkGXgx5X87RJohtL/H5arnI= X-Received: by 2002:a05:6808:1304:: with SMTP id y4mr2119053oiv.20.1621930625363; Tue, 25 May 2021 01:17:05 -0700 (PDT) MIME-Version: 1.0 References: <20210517112044.233138-1-aisheng.dong@nxp.com> <20210517112044.233138-3-aisheng.dong@nxp.com> <01356cc7-61c3-fb15-1c85-939b6366a636@redhat.com> In-Reply-To: <01356cc7-61c3-fb15-1c85-939b6366a636@redhat.com> From: Dong Aisheng Date: Tue, 25 May 2021 16:15:59 +0800 Message-ID: Subject: Re: [PATCH 2/5] mm/sparse: free section usage memory in case populate_section_memmap failed To: David Hildenbrand Cc: Dong Aisheng , linux-mm@kvack.org, open list , Andrew Morton Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=oMXs+07E; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of dongas86@gmail.com designates 209.85.167.174 as permitted sender) smtp.mailfrom=dongas86@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 97110C0042EE X-Stat-Signature: rstbafy6bc3k4frz1dwbpif8fo3gqki6 X-HE-Tag: 1621930619-351886 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 25, 2021 at 3:52 PM David Hildenbrand wrote: > > On 17.05.21 13:20, Dong Aisheng wrote: > > Free section usage memory in case populate_section_memmap failed. > > We use map_count to track the remain unused memory to be freed. > > > > Cc: Andrew Morton > > Signed-off-by: Dong Aisheng > > --- > > mm/sparse.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/mm/sparse.c b/mm/sparse.c > > index 7ac481353b6b..98bfacc763da 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -549,12 +549,14 @@ static void __init sparse_init_nid(int nid, unsigned long pnum_begin, > > __func__, nid); > > pnum_begin = pnum; > > sparse_buffer_fini(); > > + memblock_free_early(__pa(usage), map_count * mem_section_usage_size()); > > goto failed; > > } > > check_usemap_section_nr(nid, usage); > > sparse_init_one_section(__nr_to_section(pnum), pnum, map, usage, > > SECTION_IS_EARLY); > > usage = (void *) usage + mem_section_usage_size(); > > + map_count--; > > } > > sparse_buffer_fini(); > > return; > > > > Why care about optimizing something that literally never fails, and if > it would fail, leave the system in a sub-optimal, mostly unusable state? > It just fixes the code logic. I'm going to listen to more comments, if everyone thinks it's not needed. I may drop in V2. Regards Aisheng > -- > Thanks, > > David / dhildenb >