From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA13C2B9F8 for ; Tue, 25 May 2021 08:40:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 244506140A for ; Tue, 25 May 2021 08:40:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 244506140A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 16A0C6B006C; Tue, 25 May 2021 04:40:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1138C6B006E; Tue, 25 May 2021 04:40:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEAB76B0070; Tue, 25 May 2021 04:40:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 7F85E6B006C for ; Tue, 25 May 2021 04:40:53 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1019B181AEF39 for ; Tue, 25 May 2021 08:40:53 +0000 (UTC) X-FDA: 78179107986.38.DE5B4A0 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf01.hostedemail.com (Postfix) with ESMTP id B62DD5001537 for ; Tue, 25 May 2021 08:40:46 +0000 (UTC) Received: by mail-ot1-f44.google.com with SMTP id d25-20020a0568300459b02902f886f7dd43so27893947otc.6 for ; Tue, 25 May 2021 01:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8ET8TH4a7icyzqhz8XmbF4WtAKB0L7qzDzL0Lz6SbV0=; b=PdYbSrbhEiB/6UsfOFN9mEke6zkgUYRAl7Hsx5O0I+lScAu7KVTzuNWWGeaBbJy0ID r2uM+CN2FlnTLULqzDffOZJ7jsLAOXe3pIBULS4LEVQdnfbtdIK7ov+lwMUY8FfQy9gQ FIuBVVdHaTKvbVBXxQ8PYD+S6zFor4KtWU08Ndusr7rcxUIhaMilbQPrFtcwcGjefkS/ a3Ka6yj+6896f/dQoIOdKuxrNvYAI7HtoQ3LrWllwqISOMeYtOb6tSUSaZE8zWpXMopy 5Rea1fKdNUNHdu0Qx2/PC6mrJr1bqbpt3czRmva8ptscX8UcyiVltHS69gVO8jzDY4+w 3qLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8ET8TH4a7icyzqhz8XmbF4WtAKB0L7qzDzL0Lz6SbV0=; b=C/LCBjA71mQ9X2Kl/86kmgbxtJFkgF9+IVSRYKrOUNWbNZR/LSjrBc/alWK64Y0RMC P9ZJNsQdEiKVHBdsUa38gmuxC1dIY0a+gsWup6M6TQzDqmn0Yv2ugfIWs/A9plmtxx4a A6YDypqG03gJ78SJ9JUMvpApO7Ey+CyRXD1GG2pLuDTlmmWPvntBl01OsEUsjz2AKJss NxiXX5THeflMpwdfUjkhLLSg+l7kzsvZt1EXmZNKwGs5ymZaMXr6HWB1EwikNUwEbrMh CyunsRTjp4ixbiAEE67VPVe6QNy7nxRD2USvjkUgP+O8E0GMehQgJUYPDO5CRfOuVkF2 mCzg== X-Gm-Message-State: AOAM533uZLQeWfIp4btZJlIAx/1OddfUH7hnvt+9qGBYAh0/TrA+icQ+ mAHZuYdG/lqdikQB3t1xoddOKOw1jguHeoDaqnK4tXG6Be0= X-Google-Smtp-Source: ABdhPJzlheYhN78NwTb8+1mxjOpGFYfJQS1zrtf3mbG2zBzuuzfK2O1mcYCS9AqXChGNsM5/0xFPY+md9fpUyPTbrfc= X-Received: by 2002:a05:6830:812:: with SMTP id r18mr11481269ots.248.1621932052205; Tue, 25 May 2021 01:40:52 -0700 (PDT) MIME-Version: 1.0 References: <20210517112044.233138-1-aisheng.dong@nxp.com> <20210517112044.233138-6-aisheng.dong@nxp.com> <69b5a56c-e9a0-01e7-5fd5-78c6e656fa68@redhat.com> In-Reply-To: <69b5a56c-e9a0-01e7-5fd5-78c6e656fa68@redhat.com> From: Dong Aisheng Date: Tue, 25 May 2021 16:39:45 +0800 Message-ID: Subject: Re: [PATCH 5/5] mm/page_alloc: improve memmap_pages and dma_reserve dbg msg To: David Hildenbrand Cc: Dong Aisheng , linux-mm@kvack.org, open list , Andrew Morton Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=PdYbSrbh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of dongas86@gmail.com designates 209.85.210.44 as permitted sender) smtp.mailfrom=dongas86@gmail.com X-Stat-Signature: kj5sy41y6u91yi3qp4yaaj3f544es13p X-Rspamd-Queue-Id: B62DD5001537 X-Rspamd-Server: rspam02 X-HE-Tag: 1621932046-484480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 25, 2021 at 4:01 PM David Hildenbrand wrote: > > On 17.05.21 13:20, Dong Aisheng wrote: > > Make debug message more accurately. > > > > Cc: Andrew Morton > > Signed-off-by: Dong Aisheng > > --- > > mm/page_alloc.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 3100fcb08500..16f494352f58 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -7263,14 +7263,15 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > > pr_debug(" %s zone: %lu pages used for memmap\n", > > zone_names[j], memmap_pages); > > } else > > - pr_warn(" %s zone: %lu pages exceeds freesize %lu\n", > > + pr_warn(" %s zone: %lu memmap pages exceeds freesize %lu\n", > > zone_names[j], memmap_pages, freesize); > > } > > > > /* Account for reserved pages */ > > if (j == 0 && freesize > dma_reserve) { > > freesize -= dma_reserve; > > - pr_debug(" %s zone: %lu pages reserved\n", zone_names[0], dma_reserve); > > + pr_debug(" %s zone: %lu pages reserved for dma\n", > > + zone_names[0], dma_reserve); > > ... which is not really correct I think. See the comment above > set_dma_reserve(). It's called dma_reserve because it involves the first > zone -- where many unfreeable allocations like the kernel image end up. > > Memory is not reserved for dma purposes ... and the zone name should be > sufficient. You're right. I will drop this line of change. Thanks Regards Aisheng > > -- > Thanks, > > David / dhildenb > >