From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B93C4708F for ; Tue, 1 Jun 2021 08:41:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A58861263 for ; Tue, 1 Jun 2021 08:41:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A58861263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A3A16B0096; Tue, 1 Jun 2021 04:41:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17C676B0098; Tue, 1 Jun 2021 04:41:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 043576B0099; Tue, 1 Jun 2021 04:41:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id C93606B0096 for ; Tue, 1 Jun 2021 04:41:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5D179181AC9C6 for ; Tue, 1 Jun 2021 08:41:00 +0000 (UTC) X-FDA: 78204509880.14.62DDCA6 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by imf18.hostedemail.com (Postfix) with ESMTP id DE46D200109B for ; Tue, 1 Jun 2021 08:40:48 +0000 (UTC) Received: by mail-oo1-f52.google.com with SMTP id v13-20020a4aa40d0000b02902052145a469so3332187ool.3 for ; Tue, 01 Jun 2021 01:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XYdknBQo193eNCNhduTrPIy+Y/+hGQ3dFnlOg4zBZ6I=; b=dx8s1vD5Cd514KEwrT2NzfZZ0rJW+QulznUM8B/TAOkv+nyGIkniISQpHXU2YPdJX4 Eof6mdP92MI3sjLn4XKfCyeu/vGbuasjuYb0q4hP55hGzDYHxU5MUlDX9CjUjrCJXN/2 7rywZp/Ob/I7IStWwM3m5eOxcGcCInbwnA1PTbtdOaeFH5r2BC0mbZ9z2zPCZpeJzInH wqgO3ozo95P9wtbwFodaPB/YJLxQBdGeWmwp1IbPr3nHKJwtNn/rpzUjQ58bpFAQN5Vo kXJW/c1mGJGSI0seRN+tbXwAfFigr68Op/rAqMQhWgkOukyOhmdsBVkErMOnYOcZZajZ ZOBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XYdknBQo193eNCNhduTrPIy+Y/+hGQ3dFnlOg4zBZ6I=; b=qvPxG1ejZo1qMF7dXHaNEfg3AwTrS2GYD6RQDIgdPKvvb+P/1SIStnlfOdh+htLbWi qMnrGU5Gu0mWvv9sh7cxYeCfvEAHZm0Rxe07ue14hzS8ybXd0rIrTgzXyvf6ptvTedOj NFc8h8yZ0SdjWWsMIDc0DC6bFKrltlNacKDoCfdeU6dT4lI6G52AJ9lrgsTVcPKXHMpq T0cDO9r3HQhrSuAj2xN2hymT8eHe35FwdcU4RTtqYlqguweua6LKnJIsyYevtgVwIToD zFh1K9xBOX9XSdl142O0pEGyGYQ3Ly/P4FzwdrJu5QVQA/NX1v32xOUVcKbgmA1S2hzN t6ow== X-Gm-Message-State: AOAM53140KXOQnwi6kpE+LhnXlVLZqZDbWmg8g4dyW5XlIPUXNcBo9aD pKaX62YzlOKaOtJunAd5K5/O581CR0R2LTbkMl4= X-Google-Smtp-Source: ABdhPJxiBCo8GVxBekn8AmRO6NxZpaGfSwUtcBA71Cb4KQQnIa0AwnREyRkVYK+ptly73bpwJbfp89zU3ZNNfpln1gM= X-Received: by 2002:a4a:d89a:: with SMTP id b26mr19548775oov.11.1622536859448; Tue, 01 Jun 2021 01:40:59 -0700 (PDT) MIME-Version: 1.0 References: <20210531091908.1738465-1-aisheng.dong@nxp.com> <20210531091908.1738465-7-aisheng.dong@nxp.com> <274fb19f-d14c-bb45-b69a-a7c8b4c1722e@redhat.com> In-Reply-To: <274fb19f-d14c-bb45-b69a-a7c8b4c1722e@redhat.com> From: Dong Aisheng Date: Tue, 1 Jun 2021 16:39:49 +0800 Message-ID: Subject: Re: [PATCH V2 6/6] mm/sparse: remove one duplicated #ifdef CONFIG_SPARSEMEM_EXTREME To: David Hildenbrand Cc: Dong Aisheng , linux-mm@kvack.org, open list Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=dx8s1vD5; spf=pass (imf18.hostedemail.com: domain of dongas86@gmail.com designates 209.85.161.52 as permitted sender) smtp.mailfrom=dongas86@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DE46D200109B X-Stat-Signature: qg4ufokbjiugt97bc1udejzoij8k6zoq X-HE-Tag: 1622536848-435241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 1, 2021 at 4:26 PM David Hildenbrand wrote: > > On 31.05.21 11:19, Dong Aisheng wrote: > > Those two blocks of code contained by #ifdef CONFIG_SPARSEMEM_EXTREME > > condition are right along with each other. Not need using another #ifdef > > condition. > > > > Signed-off-by: Dong Aisheng > > --- > > ChangeLog: > > *new patch > > --- > > mm/sparse.c | 18 ++++++++---------- > > 1 file changed, 8 insertions(+), 10 deletions(-) > > > > diff --git a/mm/sparse.c b/mm/sparse.c > > index 6412010478f7..2905ee9fde10 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -114,16 +114,7 @@ static int __meminit sparse_index_init(unsigned long section_nr, int nid) > > > > return 0; > > } > > -#else /* !SPARSEMEM_EXTREME */ > > -static inline int sparse_index_init(unsigned long section_nr, int nid) > > -{ > > - return 0; > > -} > > > > -static inline void sparse_alloc_section_roots(void) {} > > -#endif > > - > > -#ifdef CONFIG_SPARSEMEM_EXTREME > > unsigned long __section_nr(struct mem_section *ms) > > { > > unsigned long root_nr; > > @@ -142,11 +133,18 @@ unsigned long __section_nr(struct mem_section *ms) > > > > return (root_nr * SECTIONS_PER_ROOT) + (ms - root); > > } > > -#else > > +#else /* !SPARSEMEM_EXTREME */ > > +static inline int sparse_index_init(unsigned long section_nr, int nid) > > +{ > > + return 0; > > +} > > + > > unsigned long __section_nr(struct mem_section *ms) > > { > > return (unsigned long)(ms - mem_sections[0]); > > } > > + > > +static inline void sparse_alloc_section_roots(void) {} > > #endif > > Want to tag that one (endif) with /* SPARSEMEM_EXTREME */ as well while > at it? Thanks, i could add it in v3 later with your tag. Regards Aisheng > > Acked-by: David Hildenbrand > > -- > Thanks, > > David / dhildenb >