From: "Alex Zhu (Kernel)" <alexlzhu@fb.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Rik van Riel <riel@fb.com>, Kernel Team <Kernel-team@fb.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] mm: add thp_utilization metrics to /proc/thp_utilization
Date: Fri, 5 Aug 2022 19:51:32 +0000 [thread overview]
Message-ID: <CA8C72B6-E509-4FB0-BEAA-C4368EB7A419@fb.com> (raw)
In-Reply-To: <Yu1uabedm+NYnnAj@casper.infradead.org>
>
> Ah! So when that exists, this interface tells us "how well" we're doing.
>
Yes, exactly.
>
> Yeah, debugfs seems like a better place. And I'd love to see the shrinker
> code. Before you mentioned that I was having all kinds of peculiar
> feelings about this code. For example, suppose you have incredibly hot
> 256kB of data, but the other 1792kB of data are never touched ... that
> could cause us to do entirely the wrong thing and break up this THP.
> Having it as a shrinker makes sense because the hot 256kB will keep the
> THP from reaching the end of the list and being reclaimed.
Sounds good, I’ll move this to debugfs then. Will follow up with the shrinker code
in another patch. The shrinker relies on this scanning thread to figure out which
THPs to reclaim.
What are your thoughts regarding integrating this with DAMON?
next prev parent reply other threads:[~2022-08-05 19:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 18:40 alexlzhu
2022-08-05 18:50 ` Matthew Wilcox
2022-08-05 19:04 ` Rik van Riel
2022-08-05 19:24 ` Matthew Wilcox
2022-08-05 19:51 ` Alex Zhu (Kernel) [this message]
2022-08-08 17:55 ` Yang Shi
2022-08-08 18:35 ` Rik van Riel
2022-08-09 17:11 ` Yang Shi
2022-08-09 17:15 ` Alex Zhu (Kernel)
2022-08-09 23:35 ` Yu Zhao
2022-08-10 17:07 ` Yang Shi
2022-08-10 17:14 ` Alex Zhu (Kernel)
2022-08-10 17:54 ` Yu Zhao
2022-08-10 21:39 ` Alex Zhu (Kernel)
2022-08-10 21:56 ` Yu Zhao
2022-08-11 0:00 ` Alex Zhu (Kernel)
2022-08-11 1:15 ` Yu Zhao
2022-08-11 2:08 ` Alex Zhu (Kernel)
2022-08-11 19:20 ` Alex Zhu (Kernel)
2022-08-11 21:55 ` Yu Zhao
2022-08-11 22:12 ` Yang Shi
2022-08-11 22:59 ` Yu Zhao
2022-08-07 6:03 ` kernel test robot
2022-08-07 6:44 ` kernel test robot
2022-08-07 6:55 ` kernel test robot
2022-08-08 17:52 ` Yang Shi
2022-08-05 20:28 William Kucharski
2022-08-05 21:14 William Kucharski
2022-08-05 21:46 ` Alex Zhu (Kernel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA8C72B6-E509-4FB0-BEAA-C4368EB7A419@fb.com \
--to=alexlzhu@fb.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@fb.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox