From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx162.postini.com [74.125.245.162]) by kanga.kvack.org (Postfix) with SMTP id 0512F6B0069 for ; Wed, 5 Dec 2012 15:25:54 -0500 (EST) Received: by mail-ea0-f169.google.com with SMTP id a12so2680388eaa.14 for ; Wed, 05 Dec 2012 12:25:53 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20121205095221.GB2489@suse.de> References: <1349801921-16598-1-git-send-email-mgorman@suse.de> <1349801921-16598-6-git-send-email-mgorman@suse.de> <20121204141501.GA2797@suse.de> <20121205095221.GB2489@suse.de> Date: Wed, 5 Dec 2012 22:25:53 +0200 Message-ID: Subject: Re: [PATCH] tmpfs: fix shared mempolicy leak From: Tommi Rantala Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Hugh Dickins , Stable , Andi Kleen , Andrew Morton , KOSAKI Motohiro , Dave Jones , Christoph Lameter , LKML , Linux-MM 2012/12/5 Mel Gorman : > On Tue, Dec 04, 2012 at 11:24:30PM -0800, Hugh Dickins wrote: >> From: Mel Gorman >> >> Commit 00442ad04a5e ("mempolicy: fix a memory corruption by refcount >> imbalance in alloc_pages_vma()") changed get_vma_policy() to raise the >> refcount on a shmem shared mempolicy; whereas shmem_alloc_page() went >> on expecting alloc_page_vma() to drop the refcount it had acquired. >> This deserves a rework: but for now fix the leak in shmem_alloc_page(). > > Thanks Hugh for turning gibber into a patch! > > Signed-off-by: Mel Gorman > > Tommi, just in case, can you confirm this fixes the problem for you please? Confirmed! No more complaints from kmemleak. Thanks, Tommi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org