Thank you very much for your reply. We will continue to improve according to your comments. On Tue, Jun 7, 2022 at 8:55 PM David Hildenbrand wrote: > On 06.06.22 05:27, Huanpeng Xin wrote: > > From: xinhuanpeng > > > > add a new page migratetype reserved for > > non-costly non-NOWARN page allocation failure. > > Sorry to say, but this patch description is not expressive enough. I > have absolutely no clue what you are trying to achieve and why we should > care. > > Especially, why do we care about locally grouping these allocations > (that's what pageblock flags are for after all)? > > Your Kconfig option is also not particularly user friendly to read either: > > "This enables the migration type MIGRATE_EMERGENCY,which reserves > a small amount of memory for non-costly non-NOWARN page allocation > failure." > > Usually we reserve memory via different mechanisms, like atomic > reserves? Why can't something like that be used. > > On first sight, defining a new pageblock migratype feels wrong to me. > But then, I have no clue what you are actually trying to achieve. > > -- > Thanks, > > David / dhildenb > >