From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34EAC54E58 for ; Thu, 21 Mar 2024 17:36:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DAA96B0089; Thu, 21 Mar 2024 13:36:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 289566B0092; Thu, 21 Mar 2024 13:36:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 150E86B0093; Thu, 21 Mar 2024 13:36:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 06D2A6B0089 for ; Thu, 21 Mar 2024 13:36:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C71834053B for ; Thu, 21 Mar 2024 17:36:04 +0000 (UTC) X-FDA: 81921749448.28.28AAAC0 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf07.hostedemail.com (Postfix) with ESMTP id B258440016 for ; Thu, 21 Mar 2024 17:36:02 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=jo9WwZ+N; spf=pass (imf07.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.216.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711042563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vsfbKLAUh8XM/wv/UPL1Y+U6O1X/nvyFQ8Pnzrk40Sw=; b=lKFijvjhvyoMgSmJm3NPTERK0JtH01VlR07QQRlzSPW3UmNh3P07q3ErNuyZCRukiStGxj uRubiGDyL0yUYHYcLqMMyAFXAwA+r2LgYxVMKsOxMK3wCvU1PoFa0Gx9SALI5a0MbzT5G2 WQngSwNArC3p2eRCGuQJk9yBBI/tzp4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=jo9WwZ+N; spf=pass (imf07.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.216.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711042563; a=rsa-sha256; cv=none; b=iWzeRMGC6Sb6/R04jIex06EpuEKYNXX5sBVxCioec2PnoLIXyU8aSnWfy6ynnubSmlNJo2 tuCOHU0d8rWPecRtET3DSp32xB1SXKudRI+/Pk8Q7PLOcP4jhvYpdlkil4WS2s1W7JRTXt wHqF/BcsnkUjzYObJbcJh9KmG0RtVeA= Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-29f749b6667so981887a91.0 for ; Thu, 21 Mar 2024 10:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1711042561; x=1711647361; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vsfbKLAUh8XM/wv/UPL1Y+U6O1X/nvyFQ8Pnzrk40Sw=; b=jo9WwZ+N/BhKTwEKXKsk02kj3W7OSN2DY7P+flo9+/OuYhwEoGUhxoxEY4TZEBThDg 0XA4l7RJnMuAEDhDbLokC2Skas3UhO7AVMqSzqRmHiOB2KULAzdwFIRKgED5dTYdX2Sm rPOiYrfyBSsYoE1J36Xzr1YmVfNVUH9U4/h91wgqfPFQacWB/gKxaYLRZry2CUJbl4O9 nMcnOVhLk0Lp3ylzq3EtoTAUb32Kkmkgt1Tdzw4sv+gbuHi6Ugx6eEh0i6O9SmQL5SbS QDdaqZMKvm7QrhnwT9M+UhV0ZHWY+5WZ7TbMgPhBVqTlnHjKydXl7EeR5OP8LONrFvHS kD+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711042561; x=1711647361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vsfbKLAUh8XM/wv/UPL1Y+U6O1X/nvyFQ8Pnzrk40Sw=; b=Cl3vXjSitKoune3hqlLiItRHjGb0oLJLi3oySs02Jca79siTSp81TZlcoXwVg01eMU bKt9PxDqxsB7ku1Qrm1J3Ci4IPtMtE3U1sXuulH+M8CMI210DQtNdFV+pmFkIG97zgI+ CltE09DQIjPXSNeEiBWOX3GQ3AjX7B187nyOnXLsUg0L6BcYTUjhyODUwLk5n9SsKGud 5B3LiBoAIDV6mIqPhiKd9t8iE8D00QFophsdr9FrrEQ0VVl065yDsAFqc/0ks6EkyexY PTsDbBVrPCAdRb2vSxPZ+pzeB/6DW6Ua/JzpKN5DtM9NFA9FTiXn7534lbmDebyBqRGX IjrQ== X-Forwarded-Encrypted: i=1; AJvYcCXcYOqGx5OCO23qDe+CvsFTtRM/EDCzkU9NIU4xTZO+Rg1vy7ni1fmQYgANzH9ZIzopXgyzh/R4IpuLA+iXPcm1oR4= X-Gm-Message-State: AOJu0YyT0VOr4tFfUAhdtVS7GhCZA5baufWk7ARseKkShycmQUoGUeFT IoZE4HYO6NQgse67AHu/34+84EoIieO1PMYzv43Z4v4vn1UK180nrjjRqKRpI2b+igcE4uySE+c 3Rtwuvh325IG9MNRIG6wjmIutX34cj93yJSLSng== X-Google-Smtp-Source: AGHT+IEEvUgKCoe83Piw/bKLamr51mzAzLttIB5KuW88MMJX3WuBeL2E3S4MGjImKWAtXRAgbaTD+vv8IjwGdcel2GM= X-Received: by 2002:a17:90a:aa86:b0:29c:3b42:2955 with SMTP id l6-20020a17090aaa8600b0029c3b422955mr5375pjq.46.1711042561453; Thu, 21 Mar 2024 10:36:01 -0700 (PDT) MIME-Version: 1.0 References: <9fe46711-65ca-4818-b5d0-a16d2851d4b1@linux.dev> <20240321151757.GC777580@cmpxchg.org> In-Reply-To: From: Johannes Weiner Date: Thu, 21 Mar 2024 13:35:50 -0400 Message-ID: Subject: Re: zswap doing io in GFP_NOIO reclaim context To: Kent Overstreet Cc: Chengming Zhou , Yosry Ahmed , Nhat Pham , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B258440016 X-Rspam-User: X-Stat-Signature: us6f8zxef5mcbnfb47htj5diikus6ifo X-Rspamd-Server: rspam01 X-HE-Tag: 1711042562-653930 X-HE-Meta: U2FsdGVkX18vlHzYB+eqVMGUX8z2sPKgAhJvWcxCqBQuuF0yczJCOEH/QKmyCkgWBfsZya9TMp3P7MJbtHLyZpBN0edtqtwY9PV9lqln7XApJ3EFwu+ZEC+dvTsbnd5jSBlFElIRGUjxR9PmN+7HQad+McJZx6FYyxQ6iwOeGHr4CG89963aSrXwaqnfjGUgK2Hmtp2voqnwIrBvpzAjGc7PTVb2rZsMdXTcGU+yHUI4AMMzteBdm9ZdzEmTKj11KvkBqgEknpqR8Y39e1k7xsHnRRYhQFR2IvMIU+PtoC1a2vb8ftiH0/l67pB8Gm2+/57mVFB3/MAb22EfGFdzJr2UedLKXBmvJAgtA84BTVksSjJvW4pdAMZHccj+ZRb893TKDE9Q3FnfwJRr4vqKxqQ5270zCftdaAS9gxAc3esDM818yBylpagFfVVsJqYuV6p98iGtHsiK4kcjf/ntnHA3obQMqRqxOvb4C9FRMjE+2yRPKPNWJwDQiB0RmqlP8pblkfhme3CE7dXk1kW0Ht0oB+t7Tt7RmapL77VHtnamuZc9u1vm+6UTD9VDKIvwawwDDezcdSV9jIf0/yDPQ/+pDKRPHSDOTh3cnjfXKec+LIGsGGOkcLdBCTlIE1hF2C0JEWBkjEXhv/U1kD6uCUZIFv1NOpLCLZXis+2RA7+iylNo2ylY7sIitmzXzgT8K6mzfkcRES+E3t3sf+CbnYYFMvyIfPUIiM0d3QoKSIQF5EjB4n3zB0Idl9tRu7D9hBfIIQHirBo64J+8jncMsZz+l07yezA2J88SKqt2QZKMKkeSYt3PAR6CVQ0tly0POE8VqINdB/VMQLl2A1VtLZecB7Mi1/TREtj0fMc3YPcmpFRanGvFfAn5kEsNLk6EB+dv1RA5J8wEQ9GiQmMH1Eejau0hmNWv8vtkaBa2i88uWmb3mvsXFjyQbhbB93VstbZLc+YcrUWCrrjPPZv aplJex4G 0JG8VWYwI1M3xdb44IdeReS3wstjOmq1pnZExKw32svgmmLCqK+tqzgowKC48+eT8Ao4pUGYM3D1dbPZQmbMsZWk53x7Sli1NSNxVkehqLwHubiHeAJeyKulddqXbOViyr14jyrRN/beaf2PYUfebbfycPBAS9e1hHqFgjEdhN9s8nVNMkZvHNTSbpK7cKpUd6DwFvqOft1c7EaHa4TB/rIqHiI0ngyzSHxdAe7SC/FFHGsHCQyBDyJvUsdG7NslCX9ljuu7vUi32cTPKwk02ZH0uPTUMwu0HHDHreQ6DLD7j6oDizqNLZDDdZqzHg3epQGovIy20QeqD4iQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.059757, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 12:45=E2=80=AFPM Kent Overstreet wrote: > On Thu, Mar 21, 2024 at 11:17:57AM -0400, Johannes Weiner wrote: > > But the shrinker directly calls __swap_writepage(), which will submit > > IO, and may even enter the fs. We definitely have to filter for that: > > Are you applying the fix? You're listed as maintainer Yeah, I'll send a proper fix to Andrew, who routes MM patches, later today. Do you want somebody in particular on the Reported-by?