From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD2EC61DA4 for ; Thu, 9 Feb 2023 07:12:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D36726B0071; Thu, 9 Feb 2023 02:12:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE6626B0072; Thu, 9 Feb 2023 02:12:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAEE16B0074; Thu, 9 Feb 2023 02:12:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AD4646B0071 for ; Thu, 9 Feb 2023 02:12:49 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 75093A2B81 for ; Thu, 9 Feb 2023 07:12:49 +0000 (UTC) X-FDA: 80446886058.06.181B4C8 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf04.hostedemail.com (Postfix) with ESMTP id A0B9A40019 for ; Thu, 9 Feb 2023 07:12:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AoYrrJJs; spf=pass (imf04.hostedemail.com: domain of haoluo@google.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=haoluo@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675926767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4WVs22Kg7Btgcs7NcU/V4V2lSD7tkAUiSfve9Y1LNwY=; b=U31kw9U4m+tPNkFgvwLm8kFqxJpzEwAm8N5I1AtjKj/0KFTp3wVJJ7Y7UyrdzGKoeGm5kL Q4ROCMeERhdDIbPs/2eql6n3+WcvSez+MofzOiH9j/1GL2VTFjCK/InQDn3fix1VD9unkl 6QyhS72IU5xeA9KnV0TiSFYocFo4UnA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AoYrrJJs; spf=pass (imf04.hostedemail.com: domain of haoluo@google.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=haoluo@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675926767; a=rsa-sha256; cv=none; b=obXCIKJUyBvN5A/Ag1tN+sB62KaQGluaW35ZbYs89ebIRAWD+9I1tJm5j5aAzH44aazL/Y 3a5nYbZJ/THWVyOfJPpYsv7iUlnHFygyaFFxOZrQN71xA6X/aAdRbhkOuWJrwPoRDo8UiE 7SZrEhzbZoSLlZzrdFN3tqCWWLuW7o8= Received: by mail-pj1-f49.google.com with SMTP id bx22so1263025pjb.3 for ; Wed, 08 Feb 2023 23:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4WVs22Kg7Btgcs7NcU/V4V2lSD7tkAUiSfve9Y1LNwY=; b=AoYrrJJs6k9GtmQ4jMGk0yXnsurRdiogv4N9KaUtAvk7czZiKUvynb//Bfa2EC5y3x bThSbc2PuWdlSa6zqhkSM3mNpiJHJPK8QHZP0bb0ANnmBRq9y6M6tosCkqa0HtjZEr7m pdZWvIjuSCgtmifIjb6P+QJwoD6nwQX/OA31bMpYqq3qigQS8QSqGSlSiq47cdl+XVQx 2JCuvOxpC3CK/kIQhAqtz+Zi7zTcsXfsqIKsjnrCzTvJoB5FP4M6IVUUoVQ4vN1tGuCr X41zK9YDiG7cBtw8BW3R1Jb/SbukYgAhUI7qDCI7mUA4yRA0v5Gq7Ipcnhb/YmqWIm3T qicw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4WVs22Kg7Btgcs7NcU/V4V2lSD7tkAUiSfve9Y1LNwY=; b=7NgOZRsed409/KImUxV8Zn5zuywioPdHql529DazWjcyw2tJLH0nXnqxjV34yw1Re3 Eu/hYU/0JLQePaYBjsbPotH7b2wYt75VXjFycs/jzprGtTYMaGhRNx7hLyAlrWm7juSy ONLKRnzFudvXRjYYW3Wtc0z3lqd6L2rbSVBfjDRsi99MS7gS39w/d2C3d65Yfn8pjnBq W5aoItXoEhlFPdzArSvmE6i/EC9x6YYbJQr5IrQUSsfyCaHVvtM+8j2V7I04WmL+imcq Hjx0HO2FxUfHouQJT+jLtMw/Wh5zRNadS/GfF66BbWhvR+SFwZ4yNg0RVqwTsPh47FE3 tYUQ== X-Gm-Message-State: AO0yUKU+VEmYPtUB+lAnr3xtnkuVI7VY8mFsvr8Nx0EvtduWVSIJFWU+ 6RhrgnTD6ey5dHPt+acNQQwBcsls/eCvxiDtUuDLww== X-Google-Smtp-Source: AK7set/JAGjMaYyKUc3wik1Zpc3z1fF27fTbmID4hmKb+mM1VoQt/VnzqKCHgPPcXP/4CDxya8Ss+VkiNAm6JDV2cqw= X-Received: by 2002:a17:902:b78a:b0:199:26df:77b6 with SMTP id e10-20020a170902b78a00b0019926df77b6mr2518442pls.3.1675926766145; Wed, 08 Feb 2023 23:12:46 -0800 (PST) MIME-Version: 1.0 References: <20230201135737.800527-1-jolsa@kernel.org> In-Reply-To: From: Hao Luo Date: Wed, 8 Feb 2023 23:12:34 -0800 Message-ID: Subject: Re: [RFC 0/5] mm/bpf/perf: Store build id in file object To: Jiri Olsa Cc: Matthew Wilcox , Alexei Starovoitov , Andrii Nakryiko , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 8a5rbbd9tzgj8yxpjzo84hsz5n1yngqx X-Rspam-User: X-Rspamd-Queue-Id: A0B9A40019 X-Rspamd-Server: rspam06 X-HE-Tag: 1675926767-275470 X-HE-Meta: U2FsdGVkX18D7Rj2aIWMXBJcXfX+GRO1RT3wCbeb/AXrNQF35u79H7rS9vWcBdJ+42fBSr1ZaOIgPzBDKchDKJRgQalU5SFS3gdy9dR+Dxgrac25V1qHRt82PTSbHNoomakOe9puash1rDU4eZZT1c5O2OyFTv9Pimd9FXvBiTIz6VsC7CC/fn2A21Jly1bq4ZV31sN+wCdRz2jjJmx8HRqvYFJ5IQ3n81ZbX8lFgNBW/F7yG7rSBlj6Iv2V/SkFDe7o77dUPXoTsTXejixuh84695SMHaNC5fzPT/jq4OLfFeFvOTDP0LawTft8YZmwcx8NMTTp1sYwauQ0X+wOviMeqoIGhN0qVf/EzK5rxldX3lrXCtpKJdFrpZjz7tICfWaMhRqJVh8OrIbvqxJVZ6ZG4RVpFXVE9Ahu2wWGoye7AGgSJGzQhr0kG8B8rS0p80/W/9mtymO5wNexetNBuZvlzyQJsEiIlbSBRq6nZDW2BpUMtkpHZZoZuxJOkbLH92HhJg/HyhcjEt2ZlPo1A1NV3LWUizyyQYtt4+p+0x2LhRhWXbSRpxojliFyaJ/v6cSjELQs7GB3Py4i2N7C5wdCQ78n5sgYsgKgw5sEGO4MO81+0S4h7Y3jUgQqhCzmBsjQSSIxcZSOgGsa566yi2jZZAzuXhmPmzZ14LfOooSpu5aAUWzTyg/IGdO6iDw5TrIgr9VB5TyHSJ+PWlaNS8NJHltITAzXaG4JY9g9lmtyG3N7Ljcu2GsHhfLJfqbBKC/IZ4j0XcUYm4w6hzYuik8vH1rAwvOM54A/PTQMeijDwPZdYvY69nWWBAKeYW7WXKrS5u/MZsLvOUrkG9/242RZ47bPaXPogJ+8sZ7uA1HShwEAnecjYO3qAl5hZ3cCzU3R4O5NAUK91IVHPdapWe0JD/rc6YDydeKfthuyUJJdIXaAV6e/JkGBAZi30+ZlURYVzO1oCdSdtNfpSKw GmbeyhFQ NO78o2MQSGt4Jj7dRqPjUqziN15soZiCUgPT/b7xazmODawrf4Z9BuOjXd/0HlV8FXf3FBFHLJjJ0DsRoRIukrcQnSkv7FoEH4ErHXDWbsmsGD17ctFUb8s/6qn61ICwiljK32jmHLTv1JzAgWUvJtO79QnIfPezT6rs+K/vEglUzj4R5Mc5JvxjkHJot2ZUcN1EVB0LG9pi5AAyArXboMJCqR7n9XNVfd5XUAi39GERSmfRha/fHfyB8draX3Scxu/TxNUD0ndi3a9EgNt61OT4A5GzRndUyUuk/3i+/UquvVFF/mbJZJp/7nnwHEv+5N2OsB6vFaaBMuDQNwRSbOCauAOxY3Wyx+xTB5mcAH+JFHkRoL9XzLc+kC/G9HVByCy3LP54koCfH8BnBnU9dhuhn/Up30q8Wt0AQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 2, 2023 at 7:33 AM Jiri Olsa wrote: > > On Thu, Feb 02, 2023 at 03:10:30PM +0000, Matthew Wilcox wrote: > > On Wed, Feb 01, 2023 at 02:57:32PM +0100, Jiri Olsa wrote: > > > hi, > > > we have a use cases for bpf programs to use binary file's build id. > > > > What is your use case? Is it some hobbyist thing or is it something > > that distro kernels are all going to enable? > > > > our use case is for hubble/tetragon [1] and we are asked to report > buildid of executed binary.. but the monitoring process is running > in its own pod and can't access the the binaries outside of it, so > we need to be able to read it in kernel > > I understand Hao Luo has also use case for that [2] > Sorry for the late reply. We use BPF to profile stacktraces and build id is more useful than instruction addresses. However, sometimes we need to record stacktraces from an atomic context. In that case, if the page that contains the build id string is not in the page cache, we would fail to get build id. Storing the build id in file object solves this problem and helps us get build id more reliably. > jirka > > > [1] https://github.com/cilium/tetragon/ > [2] https://lore.kernel.org/bpf/CA+khW7gAYHmoUkq0UqTiZjdOqARLG256USj3uFwi6z_FyZf31w@mail.gmail.com/