From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1ECEC433EF for ; Tue, 22 Mar 2022 21:37:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A4826B0072; Tue, 22 Mar 2022 17:37:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 453076B0073; Tue, 22 Mar 2022 17:37:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31B226B0074; Tue, 22 Mar 2022 17:37:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 1FF0E6B0072 for ; Tue, 22 Mar 2022 17:37:52 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A92B28249980 for ; Tue, 22 Mar 2022 21:37:51 +0000 (UTC) X-FDA: 79273334742.23.28C9CE9 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf13.hostedemail.com (Postfix) with ESMTP id 420C620029 for ; Tue, 22 Mar 2022 21:37:51 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id r7so12118150wmq.2 for ; Tue, 22 Mar 2022 14:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=26rbbh0Rc+t58fCPLrjVyxltmsz2gfaAhKsT3lin0qU=; b=E4pneTceurMqMrK/ctTcQD8Ux5MsPoAf7fXe0dR1Vi4+NasJnWwgPDWsS6IXE9SFsC K1mTPuhYcB3HpxJ3GEoMt51U3jeaO33AhpL9EhWKpmlv7h+yq2ib41Gzqf2UnxTK9lFe lIgfBHrtuhDX/MQbhz14gDLxT4el9mInINuuKPju736gzx84bNf2sCrZElIomNmnijXu jxWc82KJL8l2Lt6orpyEBw05omUgb/E4mNF9v8fCam3yWbwaksgIqrexxXEa7F9cbCQ4 WjouLCEeXkVb0xOFv6iujceESI7xqmeY4d3POejaRm5rslth8ExLDhKZOvTTIpdH6JAd 3fqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=26rbbh0Rc+t58fCPLrjVyxltmsz2gfaAhKsT3lin0qU=; b=Kjl5zO5VT2DapaJspRg5a4FKlDlSfc/tXFnsKlmomJ/TH9yqkl6kjVFOXAyq5RV8Nj 4xJNNjcUlPXlq2KGh8tysiwmxY345a2gE3ZLEMfvW05gZIT143pdG/V8LSa4R3mq6Wfe VUHyZFh0yU9cHuN7IpkouJfDakMVDOpsuLH2HGMOQzuMoM5s7duJ9w/TzsrZnu41myBR UWFRAIgK3lS0hM17xdh5gdyfDxyaqKBy631+LnHs9kywlFuxUq0Px2wrLffoLplQ+7Iq B7TdKlchVot/ByaOg0tj75cOv3OLs4Pm9JNNSx8JnWdeURXzGvHs5GqgPir0oS2bS5h7 9m2g== X-Gm-Message-State: AOAM531bkhN4hrjqqtZqHV/7Gc1dLFYNsGFwGIUfpJooXM9/Uljv+wc7 Ya7kpArhGJBfTqT5vRYy6arBMiC3Z0O2xm78ZfymKA== X-Google-Smtp-Source: ABdhPJzY+0z4BHVsf8We2C79D5dl6jKrbqOozKCmCl71iCXf7SCI56T7IFhb+A0USGMYR3NGtuLZI7lZ3ehDt5Z3lhI= X-Received: by 2002:a1c:f605:0:b0:37b:b5de:89a0 with SMTP id w5-20020a1cf605000000b0037bb5de89a0mr5795110wmc.88.1647985069723; Tue, 22 Mar 2022 14:37:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hao Luo Date: Tue, 22 Mar 2022 14:37:38 -0700 Message-ID: Subject: Re: [RFC bpf-next] Hierarchical Cgroup Stats Collection Using BPF To: Yonghong Song Cc: Yosry Ahmed , Tejun Heo , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Johannes Weiner , Shakeel Butt , Stanislav Fomichev , David Rientjes , bpf , KP Singh , cgroups@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: f9ckjkmydt5suwsq4y45yqfjpx4kd773 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E4pneTce; spf=pass (imf13.hostedemail.com: domain of haoluo@google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=haoluo@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 420C620029 X-HE-Tag: 1647985071-298587 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002624, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 22, 2022 at 11:09 AM Yonghong Song wrote: > > Hi, Yosry, I heard this was discussed in bpf office hour which I > didn't attend. Could you summarize the conclusion and what is the > step forward? We also have an internal tool which collects cgroup > stats and this might help us as well. Thanks! > Hi Yonghong, Yosry is out of office this entire week. I don't know whether he has access to corp email account, so please allow me to reply on his behalf. So instead of using rstat in bpf (by providing a map interface), it's better to leverage the flexibility provided by bpf to extend rstat. "We can achieve a similar outcome with a less intrusive design." Yosry "will look at programs providing their own aggregators and maintaining their own stats, and only making callbacks to/from rstat." As the next step, Yosry is going to work on an RFC patchset to drive the discussion, when he is back. It's great to see that this is helpful to you as well! I am looking forward to collaboration if there is a need. Hao